starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Support using the Accent Color for cursorColor, selectionBackground, etc. #7979

New Issue
Open
opened 2026-01-31 01:17:34 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 01:17:34 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (May 6, 2020).

Can there be support for the Accent Color brushes, so if I were to set my cursor or selction to my Accent Color, as it changes, that change will be reflected in Windows Terminal?

So that might need to be it's own separate feature request. The cursor and the selection are drawn in DirectX down in TermControl, so they work differently than a lot of the things in this spec (which are all XAML elements).

For those, we'd need to accept something like "cursorColor": "accent". When we did that, CascadiaSettings would know that the string isn't a "#rrggbb" color, so it could look up the color when we're building the TerminalSettings to pass to the TermControl. However, after that point, if the user changes their accent color, that wouldn't be reflected dynamically in the Terminal, until the user manually refreshes their settings.

It's not a horrible idea, but probably something we should move to it's own thread for discussion, since I don't think it really fits in with a lot of the other things in this spec.

Originally posted by @zadjii-msft in https://github.com/microsoft/terminal/pull/5772#issuecomment-624908257

#6338 is related.

Originally created by @zadjii-msft on GitHub (May 6, 2020). > > > Can there be support for the Accent Color brushes, so if I were to set my cursor or selction to my Accent Color, as it changes, that change will be reflected in Windows Terminal? So that might need to be it's own separate feature request. The cursor and the selection are drawn in DirectX down in `TermControl`, so they work differently than a lot of the things in this spec (which are all XAML elements). For those, we'd need to accept something like `"cursorColor": "accent"`. When we did that, `CascadiaSettings` would know that the string isn't a "#rrggbb" color, so it could look up the color when we're building the `TerminalSettings` to pass to the `TermControl`. However, after that point, if the user changes their accent color, that wouldn't be reflected dynamically in the Terminal, until the user manually refreshes their settings. It's not a horrible idea, but probably something we should move to it's own thread for discussion, since I don't think it really fits in with a lot of the other things in this spec. _Originally posted by @zadjii-msft in https://github.com/microsoft/terminal/pull/5772#issuecomment-624908257_ #6338 is related.
claunia commented 2026-01-31 01:17:35 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (May 6, 2020):

When Xaml becomes a theming system for the App, any WinUI System brushes should become valid strings for setting colours in the console settings.

Perhaps you could use a prefix like xaml: xaml:AccentColor when referencing known colours.

@mdtauk commented on GitHub (May 6, 2020): When Xaml becomes a theming system for the App, any WinUI System brushes should become valid strings for setting colours in the console settings. Perhaps you could use a prefix like **xaml:** ``xaml:AccentColor`` when referencing known colours.
claunia commented 2026-01-31 01:17:35 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 9, 2022):

Note to future self: This should become the "ThemeColor can be used at the Control layer" thread. For unification of ThemeColor, SelectionColor, and generally the colors for a control. That would automatically get us accent support in color schemes.

@zadjii-msft commented on GitHub (Sep 9, 2022): Note to future self: This should become the "ThemeColor can be used at the Control layer" thread. For unification of `ThemeColor`, `SelectionColor`, and generally the colors for a control. That would automatically get us `accent` support in color schemes.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Area-TerminalControl Help Wanted Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7979
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?