Tab close button doesn't color properly when changing tab color #7983

Open
opened 2026-01-31 01:17:39 +00:00 by claunia · 0 comments
Owner

Originally created by @cinnamon-msft on GitHub (May 7, 2020).

Originally assigned to: @zadjii-msft on GitHub.

Environment

Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): Built from master, latest commit: 1d72e77

Any other software?

Steps to reproduce

Color the tab using the tab color picker (right click and select Color...).
Choose a light color (when using the dark Terminal theme).

Expected behavior

The "X" on the tab should be the same color as the tab title text.
image

Actual behavior

The "X" doesn't change color depending on the tab color.
image

Originally created by @cinnamon-msft on GitHub (May 7, 2020). Originally assigned to: @zadjii-msft on GitHub. <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: 10.0.18363.0 Windows Terminal version (if applicable): Built from master, latest commit: 1d72e77 Any other software? ``` # Steps to reproduce Color the tab using the tab color picker (right click and select Color...). Choose a light color (when using the dark Terminal theme). # Expected behavior The "X" on the tab should be the same color as the tab title text. ![image](https://user-images.githubusercontent.com/48369326/81257514-50dbfb00-8fe8-11ea-9e14-e3e3a9f874fe.png) # Actual behavior The "X" doesn't change color depending on the tab color. ![image](https://user-images.githubusercontent.com/48369326/81257493-4457a280-8fe8-11ea-99fc-353d34e8b711.png)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7983