starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Terminal: ANSI Underlines are rendered in the wrong color/not at all #804

New Issue
Closed
opened 2026-01-30 22:04:45 +00:00 by claunia · 7 comments
claunia commented 2026-01-30 22:04:45 +00:00
Owner
Copy Link

Originally created by @dhrdlicka on GitHub (May 8, 2019).

Originally assigned to: @miniksa on GitHub.

  • Your Windows build number: (Type ver at a Windows Command Prompt)
    Microsoft Windows [Version 10.0.18885.1001]

  • What you're doing and what's happening: (Copy & paste specific commands and their output, or include screen shots)
    When running colortest-16 in WSL from inside Windows Terminal, underline sequences are rendered in strange colors (if they get rendered at all). Here is a comparison between the Terminal and the classic console:
    Screenshot

  • What's wrong / what should be happening instead:
    The Terminal should render ANSI underlines in the current foreground color.

Originally created by @dhrdlicka on GitHub (May 8, 2019). Originally assigned to: @miniksa on GitHub. * **Your Windows build number: (Type `ver` at a Windows Command Prompt)** `Microsoft Windows [Version 10.0.18885.1001]` * **What you're doing and what's happening: (Copy & paste specific commands and their output, or include screen shots)** When running `colortest-16` in WSL from inside Windows Terminal, underline sequences are rendered in strange colors (if they get rendered at all). Here is a comparison between the Terminal and the classic console: ![Screenshot](https://i.imgur.com/c4xlwHD.png) * **What's wrong / what should be happening instead:** The Terminal should render ANSI underlines in the current foreground color.
claunia commented 2026-01-30 22:04:47 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 8, 2019):

I believe @miniksa already has this one on his plate for after Build :)

@zadjii-msft commented on GitHub (May 8, 2019): I believe @miniksa already has this one on his plate for after Build :)
claunia commented 2026-01-30 22:04:47 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (May 14, 2019):

Yeah I'll get to this.

@miniksa commented on GitHub (May 14, 2019): Yeah I'll get to this.
claunia commented 2026-01-30 22:04:48 +00:00
Author
Owner
Copy Link

@rbeesley commented on GitHub (Jun 19, 2019):

I saw this, but doing research on whether I should file a bug or not, I couldn't find anything which defined what the behavior actually should be. In some cases, the color of the underline seems to benefit the visibility. Is there a way to use escape codes to set the color of the underline?

@rbeesley commented on GitHub (Jun 19, 2019): I saw this, but doing research on whether I should file a bug or not, I couldn't find anything which defined what the behavior actually should be. In some cases, the color of the underline seems to benefit the visibility. Is there a way to use escape codes to set the color of the underline?
claunia commented 2026-01-30 22:04:48 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 25, 2019):

I'm 99% sure that this is in CustomTextRenderer::_FillRectangle in the DxRenderer. We think it's a BGR vs RGB problem.

@zadjii-msft commented on GitHub (Jul 25, 2019): I'm 99% sure that this is in `CustomTextRenderer::_FillRectangle` in the DxRenderer. We think it's a BGR vs RGB problem.
claunia commented 2026-01-30 22:04:49 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 26, 2019):

I take that back; I don't know how the DxRenderer draws underlines. They're not coming from CustomTextRenderer::DrawUnderline, that's for sure.

@zadjii-msft commented on GitHub (Jul 26, 2019): I take that back; I don't know how the DxRenderer draws underlines. They're not coming from `CustomTextRenderer::DrawUnderline`, that's for sure.
claunia commented 2026-01-30 22:04:50 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Jul 29, 2019):

It's probably in PaintBufferGridLines given that an underline has been traditionally part of the box drawing set.

bd5cae1328/src/renderer/dx/DxRenderer.cpp (L929-L1001)

@miniksa commented on GitHub (Jul 29, 2019): It's probably in `PaintBufferGridLines` given that an underline has been traditionally part of the box drawing set. https://github.com/microsoft/terminal/blob/bd5cae13281401cda50cff29b6dda29b8350cc07/src/renderer/dx/DxRenderer.cpp#L929-L1001
claunia commented 2026-01-30 22:04:50 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Aug 27, 2019):

:tada:This issue was addressed in #2491, which has now been successfully released as Windows Terminal Preview v0.4.2382.0.🎉

Handy links:

@ghost commented on GitHub (Aug 27, 2019): :tada:This issue was addressed in #2491, which has now been successfully released as `Windows Terminal Preview v0.4.2382.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.4.2382.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Issue-Bug Needs-Tag-Fix Product-Terminal Resolution-Fix-Committed Work-Item
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#804
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?