starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Card suite Unicode characters are the wrong width #8046

New Issue
Closed
opened 2026-01-31 01:19:24 +00:00 by claunia · 8 comments
claunia commented 2026-01-31 01:19:24 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (May 9, 2020).

Originally assigned to: @leonMSFT on GitHub.

Environment

Windows build number: Version 10.0.18362.657
Windows Terminal version (if applicable): Commit 7ae34336da

Steps to reproduce

  1. Build commit 7ae34336da
  2. Open a bash shell
  3. Execute printf "\u2660\u2663\u2665\u2666\n"

Expected behavior

This should print our the four card suite Unicode characters, each being one cell wide. Here's what it used to look like in conhost:

image

Actual behavior

Each characters occupies two cells now.

image

I wouldn't be too concerned if these were some recently invented emoji like crying kitten, or dancing monkey with umbrella. But these characters are from the default cmd shell code page (CP437), and they've been narrow characters for going on 40 years now. They're even included in the WGL4 character repertoire. Changing their width is almost guaranteed to break things.

I'm sorry I didn't bring this up before PR #5795 was merged, but I wasn't paying attention to the actual characters that were being changed. I only noticed now when I was testing some of my own code and found that this broke Vttest (it uses the diamond character in a couple of the tests).

Originally created by @j4james on GitHub (May 9, 2020). Originally assigned to: @leonMSFT on GitHub. # Environment Windows build number: Version 10.0.18362.657 Windows Terminal version (if applicable): Commit 7ae34336da0be8428738df5e13dfc4c5f1df6f75 # Steps to reproduce 1. Build commit 7ae34336da0be8428738df5e13dfc4c5f1df6f75 2. Open a bash shell 3. Execute `printf "\u2660\u2663\u2665\u2666\n"` # Expected behavior This should print our the four card suite Unicode characters, each being one cell wide. Here's what it used to look like in conhost: ![image](https://user-images.githubusercontent.com/4181424/81461502-39e20800-91a4-11ea-8944-c878ad4c8499.png) # Actual behavior Each characters occupies two cells now. ![image](https://user-images.githubusercontent.com/4181424/81461517-45cdca00-91a4-11ea-8b37-5da63e426a9e.png) I wouldn't be too concerned if these were some recently invented emoji like crying kitten, or dancing monkey with umbrella. But these characters are from the default cmd shell code page ([CP437](https://en.wikipedia.org/wiki/Code_page_437)), and they've been narrow characters for going on 40 years now. They're even included in the [WGL4](https://en.wikipedia.org/wiki/Windows_Glyph_List_4) character repertoire. Changing their width is almost guaranteed to break things. I'm sorry I didn't bring this up before PR #5795 was merged, but I wasn't paying attention to the actual characters that were being changed. I only noticed now when I was testing some of my own code and found that this broke _Vttest_ (it uses the diamond character in a couple of the tests).
claunia commented 2026-01-31 01:19:26 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (May 9, 2020):

I've just been checking the rest of the CP437 characters, and there are few more that I think shouldn't be wide:

  • U+263A white smiling face
  • U+2640 female sign
  • U+2642 male sign
@j4james commented on GitHub (May 9, 2020): I've just been checking the rest of the CP437 characters, and there are few more that I think shouldn't be wide: * U+263A white smiling face * U+2640 female sign * U+2642 male sign
claunia commented 2026-01-31 01:19:26 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 9, 2020):

Augh, we deserve this for our hubris. Thank you. 😁

@DHowett-MSFT commented on GitHub (May 9, 2020): Augh, we deserve this for our hubris. Thank you. 😁
claunia commented 2026-01-31 01:19:26 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 9, 2020):

crying kitten, or dancing monkey with umbrella

(I'll have you know that I am still laughing at this.)

@DHowett-MSFT commented on GitHub (May 9, 2020): > crying kitten, or dancing monkey with umbrella (I'll have you know that I am still laughing at this.)
claunia commented 2026-01-31 01:19:26 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 11, 2020):

I'm actually yanking this into the v1 milestone -- we broke it in the run-up to v1, we should darned well fix it for v1.

@DHowett-MSFT commented on GitHub (May 11, 2020): I'm actually yanking this into the v1 milestone -- we broke it in the run-up to v1, we should darned well fix it for v1.
claunia commented 2026-01-31 01:19:27 +00:00
Author
Owner
Copy Link

@leonMSFT commented on GitHub (May 11, 2020):

grr now I'm wondering what other glyphs have incorrect widths... like when printed inside of terminal, I'm getting the emoji presentation like so:
image

@leonMSFT commented on GitHub (May 11, 2020): grr now I'm wondering what other glyphs have incorrect widths... like when printed inside of terminal, I'm getting the emoji presentation like so: ![image](https://user-images.githubusercontent.com/57155886/81589114-06eb7000-936e-11ea-8d0b-1e9cf0db9ae8.png)
claunia commented 2026-01-31 01:19:27 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 11, 2020):

This one looks like it's font-specific. Because Cascadia Code has those glyphs, I get:

image

@DHowett-MSFT commented on GitHub (May 11, 2020): This one looks like it's font-specific. Because Cascadia Code has those glyphs, I get: ![image](https://user-images.githubusercontent.com/14316954/81589725-85e0a880-936e-11ea-9cb3-20899529659e.png)
claunia commented 2026-01-31 01:19:27 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (May 12, 2020):

Note that the white smiling face was supposedly added to Cascadia Code in PR 213 (https://github.com/microsoft/cascadia-code/pull/213) so I'm assuming that should be rendered correctly whenever the font is next released.

However, I'm curious what fallback font is producing the color versions of all of these characters. Every fixed space font I've tried seems to have them as monochrome. It's only when the glyphs aren't included that I'm getting a fallback that's in color. Where is that coming from?

@j4james commented on GitHub (May 12, 2020): Note that the white smiling face was supposedly added to Cascadia Code in PR 213 (https://github.com/microsoft/cascadia-code/pull/213) so I'm assuming that should be rendered correctly whenever the font is next released. However, I'm curious what fallback font is producing the color versions of all of these characters. Every fixed space font I've tried seems to have them as monochrome. It's only when the glyphs aren't included that I'm getting a fallback that's in color. Where is that coming from?
claunia commented 2026-01-31 01:19:27 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 12, 2020):

So, it looks like there's an automatic fallback (in DirectWrite) to "Segoe UI Emoji" for this codepoint range.

@DHowett-MSFT commented on GitHub (May 12, 2020): So, it looks like there's an automatic fallback (in DirectWrite) to "Segoe UI Emoji" for this codepoint range.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Server Impact-Compatibility Impact-Correctness Issue-Bug Needs-Triage Priority-0 Product-Conhost Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#8046
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?