starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

What do references to the 17763 SDK in project files have to do with the building requirement of a 18362 SDK? #814

New Issue
Closed
opened 2026-01-30 22:05:18 +00:00 by claunia · 6 comments
claunia commented 2026-01-30 22:05:18 +00:00
Owner
Copy Link

Originally created by @fghzxm on GitHub (May 8, 2019).

  • Your Windows build number: (Type ver at a Windows Command Prompt)
    10.0.18362.86

  • What you're doing and what's happening: (Copy & paste specific commands and their output, or include screen shots)

:: commit d5b8e7c32f7a419a7d467eab038251ee529056e6
> grep -r . -I -Fwe 17763
./build/scripts/Create-AppxBundle.ps1:    $MakeAppxPath = "C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x86\MakeAppx.exe"
./packages/Microsoft.UI.Xaml.2.1.190405001-prerelease/build/Microsoft.UI.Xaml.targets:        Text="Microsoft.UI.Xaml nuget package requires TargetPlatformVersion >= 10.0.17763.0 (current project is $(MicrosoftUIXamlTargetPlatformCheckValue))"
./packages/Microsoft.UI.Xaml.2.1.190405001-prerelease/build/Microsoft.UI.Xaml.targets:        Condition="$(MicrosoftUIXamlTargetPlatformCheckValue) < 17763" />
./pkg/appx/OpenConsolePackage.wapproj:    <TargetPlatformVersion>10.0.17763.0</TargetPlatformVersion>
./samples/ConPTY/EchoCon/EchoCon/EchoCon.vcxproj:    <WindowsTargetPlatformVersion>10.0.17763.0</WindowsTargetPlatformVersion>
./src/cascadia/CascadiaPackage/CascadiaPackage.wapproj:    <TargetPlatformVersion>10.0.17763.0</TargetPlatformVersion>
./src/cascadia/CascadiaPackage/CascadiaPackage.wapproj:    <TargetPlatformMinVersion>10.0.17763.0</TargetPlatformMinVersion>
./src/cascadia/TerminalCore/lib/terminalcore-lib.vcxproj:    <WindowsTargetPlatformMinVersion>10.0.17763.0</WindowsTargetPlatformMinVersion>
./src/cascadia/TerminalCore/lib/terminalcore-lib.vcxproj:    <WindowsTargetPlatformVersion>10.0.17763.0</WindowsTargetPlatformVersion>
./src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj:    <WindowsTargetPlatformVersion>10.0.17763.0</WindowsTargetPlatformVersion>
./src/common.build.pre.props:    <WindowsTargetPlatformVersion>10.0.17763.0</WindowsTargetPlatformVersion>
./src/cppwinrt.build.pre.props:    <!-- 17763 is RS5 -->
./src/cppwinrt.build.pre.props:    <WindowsTargetPlatformVersion Condition=" '$(WindowsTargetPlatformVersion)' == '' ">10.0.17763.0</WindowsTargetPlatformVersion>
./src/cppwinrt.build.pre.props:    <WindowsTargetPlatformMinVersion>10.0.17763.0</WindowsTargetPlatformMinVersion>
./src/tools/vtpipeterm/VtPipeTerm.vcxproj:    <WindowsTargetPlatformVersion>10.0.17763.0</WindowsTargetPlatformVersion>
  • What's wrong / what should be happening instead:
    What do those references to the 17763 SDK in the project files have to do with the building requirement of a 18362 SDK?
Originally created by @fghzxm on GitHub (May 8, 2019). * Your Windows build number: (Type `ver` at a Windows Command Prompt) `10.0.18362.86` * What you're doing and what's happening: (Copy & paste specific commands and their output, or include screen shots) ```cmd :: commit d5b8e7c32f7a419a7d467eab038251ee529056e6 > grep -r . -I -Fwe 17763 ./build/scripts/Create-AppxBundle.ps1: $MakeAppxPath = "C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x86\MakeAppx.exe" ./packages/Microsoft.UI.Xaml.2.1.190405001-prerelease/build/Microsoft.UI.Xaml.targets: Text="Microsoft.UI.Xaml nuget package requires TargetPlatformVersion &gt;= 10.0.17763.0 (current project is $(MicrosoftUIXamlTargetPlatformCheckValue))" ./packages/Microsoft.UI.Xaml.2.1.190405001-prerelease/build/Microsoft.UI.Xaml.targets: Condition="$(MicrosoftUIXamlTargetPlatformCheckValue) &lt; 17763" /> ./pkg/appx/OpenConsolePackage.wapproj: <TargetPlatformVersion>10.0.17763.0</TargetPlatformVersion> ./samples/ConPTY/EchoCon/EchoCon/EchoCon.vcxproj: <WindowsTargetPlatformVersion>10.0.17763.0</WindowsTargetPlatformVersion> ./src/cascadia/CascadiaPackage/CascadiaPackage.wapproj: <TargetPlatformVersion>10.0.17763.0</TargetPlatformVersion> ./src/cascadia/CascadiaPackage/CascadiaPackage.wapproj: <TargetPlatformMinVersion>10.0.17763.0</TargetPlatformMinVersion> ./src/cascadia/TerminalCore/lib/terminalcore-lib.vcxproj: <WindowsTargetPlatformMinVersion>10.0.17763.0</WindowsTargetPlatformMinVersion> ./src/cascadia/TerminalCore/lib/terminalcore-lib.vcxproj: <WindowsTargetPlatformVersion>10.0.17763.0</WindowsTargetPlatformVersion> ./src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj: <WindowsTargetPlatformVersion>10.0.17763.0</WindowsTargetPlatformVersion> ./src/common.build.pre.props: <WindowsTargetPlatformVersion>10.0.17763.0</WindowsTargetPlatformVersion> ./src/cppwinrt.build.pre.props: <!-- 17763 is RS5 --> ./src/cppwinrt.build.pre.props: <WindowsTargetPlatformVersion Condition=" '$(WindowsTargetPlatformVersion)' == '' ">10.0.17763.0</WindowsTargetPlatformVersion> ./src/cppwinrt.build.pre.props: <WindowsTargetPlatformMinVersion>10.0.17763.0</WindowsTargetPlatformMinVersion> ./src/tools/vtpipeterm/VtPipeTerm.vcxproj: <WindowsTargetPlatformVersion>10.0.17763.0</WindowsTargetPlatformVersion> ``` * What's wrong / what should be happening instead: What do those references to the 17763 SDK in the project files have to do with the building requirement of a 18362 SDK?
claunia added the Resolution-Fix-AvailableIssue-BugProduct-TerminalArea-Build labels 2026-01-30 22:05:18 +00:00
claunia commented 2026-01-30 22:05:19 +00:00
Author
Owner
Copy Link

@fghzxm commented on GitHub (May 8, 2019):

Contrasting to the grep above, searching for the string "18362":

> grep -r . -I -Fwe 18362
./README.md:* You must be running Windows 1903 (build >= 10.0.18362.0) or above in order to run Windows Terminal
./README.md:* You must have the [1903 SDK](https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk) (build 10.0.18362.0) installed
./src/cascadia/CascadiaPackage/Package.appxmanifest:    <TargetDeviceFamily Name="Windows.Universal" MinVersion="10.0.18362.0" MaxVersionTested="10.0.18362.0" />
:: Notice: no .props or .vcxproj files are there!

This is confusing. I guess this repo can actually be built with the 17763 SDK, since it has been referring to 17763 all along whilst being able to build?

@fghzxm commented on GitHub (May 8, 2019): Contrasting to the grep above, searching for the string "18362": ```cmd > grep -r . -I -Fwe 18362 ./README.md:* You must be running Windows 1903 (build >= 10.0.18362.0) or above in order to run Windows Terminal ./README.md:* You must have the [1903 SDK](https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk) (build 10.0.18362.0) installed ./src/cascadia/CascadiaPackage/Package.appxmanifest: <TargetDeviceFamily Name="Windows.Universal" MinVersion="10.0.18362.0" MaxVersionTested="10.0.18362.0" /> :: Notice: no .props or .vcxproj files are there! ``` This is confusing. I guess this repo can actually be built with the 17763 SDK, since it has been referring to 17763 all along whilst being able to build?
claunia commented 2026-01-30 22:05:19 +00:00
Author
Owner
Copy Link

@hapylestat commented on GitHub (May 8, 2019):

@fghzxm yes, you could build Terminal with 17763 SDK, tested it. But no chance to run it on same run-time version.

@hapylestat commented on GitHub (May 8, 2019): @fghzxm yes, you could build Terminal with 17763 SDK, tested it. But no chance to run it on same run-time version.
claunia commented 2026-01-30 22:05:19 +00:00
Author
Owner
Copy Link

@fghzxm commented on GitHub (May 8, 2019):

@hapylestat Have you tried building with 17763 and running on 18362 (which is my configuration)?

@fghzxm commented on GitHub (May 8, 2019): @hapylestat Have you tried building with 17763 and running on 18362 (which is my configuration)?
claunia commented 2026-01-30 22:05:19 +00:00
Author
Owner
Copy Link

@fghzxm commented on GitHub (May 8, 2019):

@hapylestat I can build it with 17763 and run it on 18362. I'm yet to do some further testing but everything seems fine now.

@fghzxm commented on GitHub (May 8, 2019): @hapylestat I can build it with 17763 and run it on 18362. I'm yet to do some further testing but everything seems fine now.
claunia commented 2026-01-30 22:05:20 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 8, 2019):

That might just be an artifact of our dev process that never got updated. IIRC we were using the 17763 SDK for a while, but since the package required 18362 to run, we switched to that SDK, yet clearly didn't get all the references updated.

@zadjii-msft commented on GitHub (May 8, 2019): That might just be an artifact of our dev process that never got updated. IIRC we were using the 17763 SDK for a while, but since the package required 18362 to run, we switched to that SDK, yet clearly didn't get all the references updated.
claunia commented 2026-01-30 22:05:20 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jul 11, 2019):

You know, I think we changed this with #1012.

@DHowett-MSFT commented on GitHub (Jul 11, 2019): You know, I think we changed this with #1012.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build Issue-Bug Product-Terminal Resolution-Fix-Available
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#814
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?