starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

commandLine setting not properly escaping? #8255

New Issue
Closed
opened 2026-01-31 01:24:42 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 01:24:42 +00:00
Owner
Copy Link

Originally created by @emmatyping on GitHub (May 19, 2020).

Environment

Windows build number: Microsoft Windows [Version 10.0.19592.1001]
Windows Terminal version (if applicable): 0.11.1333.0

Steps to reproduce

Create a profile with the command line setting copied verbatim from https://github.com/microsoft/terminal/blob/master/doc/user-docs/ThirdPartyToolProfiles.md#developer-command-prompt-for-visual-studio

Expected behavior

A new VS Developer Command prompt opens

Actual behavior

A new shell displays

'C:/Program' is not recognized as an internal or external command,
operable program or batch file.

and a normal CMD prompt, as the above indicates the argument isn't being escaped properly.

Originally created by @emmatyping on GitHub (May 19, 2020). # Environment ```none Windows build number: Microsoft Windows [Version 10.0.19592.1001] Windows Terminal version (if applicable): 0.11.1333.0 ``` # Steps to reproduce Create a profile with the command line setting copied verbatim from https://github.com/microsoft/terminal/blob/master/doc/user-docs/ThirdPartyToolProfiles.md#developer-command-prompt-for-visual-studio # Expected behavior A new VS Developer Command prompt opens # Actual behavior A new shell displays ``` 'C:/Program' is not recognized as an internal or external command, operable program or batch file. ``` and a normal CMD prompt, as the above indicates the argument isn't being escaped properly.
claunia added the Issue-QuestionNeeds-Tag-FixResolution-Answered labels 2026-01-31 01:24:42 +00:00
claunia commented 2026-01-31 01:24:43 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 19, 2020):

I think this actually means that you don't have VS installed in that location. I realize that sounds weird, but...

Here's my profile, with the same level of escaping

{                                                                                                                                                       
    "name": "Developer Pwsh",                                                                                                                           
    "guid": "{1bb0520b-2f63-4db8-943d-8cb18e05957c}",                                                                                                   
    "commandline": "%comspec% /c \"C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\Common7\\Tools\\VsDevCmd.bat\" && pwsh -nologo", 
    "icon": "ms-appx:///ProfileIcons/pwsh-preview.png"                                                                                                  
},

Here's what I get if I specify Enterprise:

image

And if I specify Professional (which I do not have):

image

@DHowett commented on GitHub (May 19, 2020): I think this actually means that you don't have VS installed in that location. I realize that sounds weird, but... Here's my profile, with the same level of escaping ``` { "name": "Developer Pwsh", "guid": "{1bb0520b-2f63-4db8-943d-8cb18e05957c}", "commandline": "%comspec% /c \"C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\Common7\\Tools\\VsDevCmd.bat\" && pwsh -nologo", "icon": "ms-appx:///ProfileIcons/pwsh-preview.png" }, ``` Here's what I get if I specify `Enterprise`: ![image](https://user-images.githubusercontent.com/189190/82291586-1a926a00-995e-11ea-92ae-843a26f81a2e.png) And if I specify `Professional` (which I do not have): ![image](https://user-images.githubusercontent.com/189190/82291596-1f571e00-995e-11ea-8ae5-91c0e74698c8.png)
claunia commented 2026-01-31 01:24:43 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 19, 2020):

(This is the same thing that happens if you specify a path with spaces to a thing that doesn't exist in the Run dialog.)

image
image

@DHowett commented on GitHub (May 19, 2020): (This is the same thing that happens if you specify a path with spaces to a thing that doesn't exist in the Run dialog.) ![image](https://user-images.githubusercontent.com/189190/82291634-36960b80-995e-11ea-8ed5-b43eb39d98f9.png) ![image](https://user-images.githubusercontent.com/189190/82291640-38f86580-995e-11ea-9186-b71ca943660f.png)
claunia commented 2026-01-31 01:24:43 +00:00
Author
Owner
Copy Link

@emmatyping commented on GitHub (May 19, 2020):

D'oh! Thank you, indeed that seems to be the issue. Thank you :)

Unfortunate that the error is rather inscrutable.

@emmatyping commented on GitHub (May 19, 2020): D'oh! Thank you, indeed that seems to be the issue. Thank you :) Unfortunate that the error is rather inscrutable.
claunia commented 2026-01-31 01:24:43 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 19, 2020):

Alas! It definitely is. I'd say we could make it better, but . . . changing cmd is a no-go 😄

@DHowett commented on GitHub (May 19, 2020): Alas! It definitely is. I'd say we could make it better, but . . . changing `cmd` is a no-go :smile:
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Question Needs-Tag-Fix Resolution-Answered
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#8255
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?