starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Some of the 6x6x6 palette entries are incorrect #8272

New Issue
Closed
opened 2026-01-31 01:25:08 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 01:25:08 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (May 19, 2020).

Environment

Windows build number: Version 10.0.18362.720
Windows Terminal version (if applicable): Commit c1df53f014

Steps to reproduce

Look at the RGB values for colors 178 to 195 in Initialize256ColorTable method here:
c1df53f014/src/types/utils.cpp (L363-L380)

Compare them to the same index colors in XTerm's palette here:
c3a6a55610/256colres.h (L171-L188)

Expected behavior

The RGB values should be the same.

Actual behavior

Out red component for that range is DF rather than D7. Although funnily enough, the preceding colors in that block (160 to 177) are actually using the correct red value.

For further confirmation, you can see the formula VTE uses to initialize the palette here:
6a9580bab8/src/vte.cc (L2351-L2358)

With that formula, the only possible values for a component are 00, 5F, 87, AF, D7, and FF.

Originally created by @j4james on GitHub (May 19, 2020). # Environment Windows build number: Version 10.0.18362.720 Windows Terminal version (if applicable): Commit c1df53f01439e10023692e14d701986e74f59210 # Steps to reproduce Look at the RGB values for colors 178 to 195 in `Initialize256ColorTable` method here: https://github.com/microsoft/terminal/blob/c1df53f01439e10023692e14d701986e74f59210/src/types/utils.cpp#L363-L380 Compare them to the same index colors in XTerm's palette here: https://github.com/ThomasDickey/xterm-snapshots/blob/c3a6a556105c9f90529f36791e549ef674fc9394/256colres.h#L171-L188 # Expected behavior The RGB values should be the same. # Actual behavior Out _red_ component for that range is `DF` rather than `D7`. Although funnily enough, the preceding colors in that block (160 to 177) are actually using the correct _red_ value. For further confirmation, you can see the formula VTE uses to initialize the palette here: https://github.com/GNOME/vte/blob/6a9580bab89c8d82d67cff538e1d0c483c6e142f/src/vte.cc#L2351-L2358 With that formula, the only possible values for a component are `00`, `5F`, `87`, `AF`, `D7`, and `FF`.
claunia added the Needs-TriageResolution-Fix-CommittedNeeds-Tag-Fix labels 2026-01-31 01:25:08 +00:00
claunia commented 2026-01-31 01:25:09 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jun 18, 2020):

:tada:This issue was addressed in #5999, which has now been successfully released as Windows Terminal Preview v1.1.1671.0.🎉

Handy links:

@ghost commented on GitHub (Jun 18, 2020): :tada:This issue was addressed in #5999, which has now been successfully released as `Windows Terminal Preview v1.1.1671.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.1.1671.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 01:25:09 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jun 30, 2020):

:tada:This issue was addressed in #5999, which has now been successfully released as Windows Terminal v1.0.1811.0.🎉

Handy links:

@ghost commented on GitHub (Jun 30, 2020): :tada:This issue was addressed in #5999, which has now been successfully released as `Windows Terminal v1.0.1811.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.0.1811.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Needs-Tag-Fix Needs-Triage Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#8272
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?