starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Terminal should support ANSI SGR 53 overline attribute #8278

New Issue
Closed
opened 2026-01-31 01:25:16 +00:00 by claunia · 8 comments
claunia commented 2026-01-31 01:25:16 +00:00
Owner
Copy Link

Originally created by @rbanffy on GitHub (May 19, 2020).

Description of the new feature/enhancement

Most recent terminal applications have extensive support for ANSI terminal commands and attributes. One extremely useful one is the overline (SGR 53) attribute that can be used for status lines and other similar uses.

Windows Terminal on Windows

Gnome Terminal on Ubuntu

Originally created by @rbanffy on GitHub (May 19, 2020). # Description of the new feature/enhancement Most recent terminal applications have extensive support for ANSI terminal commands and attributes. One extremely useful one is the overline (SGR 53) attribute that can be used for status lines and other similar uses. ![Windows Terminal on Windows](https://user-images.githubusercontent.com/184714/82364538-52092100-9a07-11ea-92f2-d43396b06584.png) ![Gnome Terminal on Ubuntu](https://user-images.githubusercontent.com/184714/82364620-6a793b80-9a07-11ea-918a-068cd8fe809d.png)
claunia commented 2026-01-31 01:25:18 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 19, 2020):

Yep, we probably should.I'm mildly worried that the ExtendedAttributes enum used all the flags in a BYTE, but we'll figure it out.

c78f264b4b/src/inc/conattrs.hpp (L11-L24)

@zadjii-msft commented on GitHub (May 19, 2020): Yep, we probably should.I'm mildly worried that the `ExtendedAttributes` enum used all the flags in a `BYTE`, but we'll figure it out. https://github.com/microsoft/terminal/blob/c78f264b4b64b58589d4cb34697aaf4e18499266/src/inc/conattrs.hpp#L11-L24
claunia commented 2026-01-31 01:25:18 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 19, 2020):

So for this one we also have the LVB gridline attributes, technically. We need to figure out how they combine with underline/overline and grid bottom/top

@DHowett commented on GitHub (May 19, 2020): So for this one we also have the LVB gridline attributes, technically. We need to figure out how they combine with underline/overline and grid bottom/top
claunia commented 2026-01-31 01:25:18 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (May 19, 2020):

So for this one we also have the LVB gridline attributes, technically.

Yeah, I was just going to suggest using the COMMON_LVB_GRID_HORIZONTAL for this as a quick fix. It's no worse than our current usage of COMMON_LVB_UNDERSCORE for underline. I hacked together a quick implementation to test, and it looked OK to me. I'm not exactly sure where the overline is supposed to be rendered, but Mintty at least seems to have it at the very top of the cell. Haven't checked other implementations yet.

As for running out of bits in ExtendedAttributes , note that the lower byte of the _wAttrLegacy word is actually unused as far as I can tell, so we should have an additional 8 bits to play around with.

@j4james commented on GitHub (May 19, 2020): > So for this one we also have the LVB gridline attributes, technically. Yeah, I was just going to suggest using the `COMMON_LVB_GRID_HORIZONTAL` for this as a quick fix. It's no worse than our current usage of `COMMON_LVB_UNDERSCORE` for underline. I hacked together a quick implementation to test, and it looked OK to me. I'm not exactly sure where the overline is supposed to be rendered, but Mintty at least seems to have it at the very top of the cell. Haven't checked other implementations yet. As for running out of bits in `ExtendedAttributes` , note that the lower byte of the `_wAttrLegacy` word is actually unused as far as I can tell, so we should have an additional 8 bits to play around with.
claunia commented 2026-01-31 01:25:18 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 19, 2020):

Lower byte of ... legacy ...

Holy crap! I never noticed this. That's clever/evil/cl-evil.

@DHowett commented on GitHub (May 19, 2020): > Lower byte of ... legacy ... Holy crap! I never noticed this. That's clever/evil/cl-evil.
claunia commented 2026-01-31 01:25:18 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 19, 2020):

I was just going to suggest using the COMMON_LVB_GRID_HORIZONTAL for this as a quick fix

That's brilliant and I love it

@zadjii-msft commented on GitHub (May 19, 2020): > I was just going to suggest using the `COMMON_LVB_GRID_HORIZONTAL` for this as a quick fix That's brilliant and I love it
claunia commented 2026-01-31 01:25:18 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jun 25, 2020):

FYI, I've got a branch with this implemented, but it's built on top of #6506, so I'll only be able to do a PR once that's merged, which may be a while.

@j4james commented on GitHub (Jun 25, 2020): FYI, I've got a branch with this implemented, but it's built on top of #6506, so I'll only be able to do a PR once that's merged, which may be a while.
claunia commented 2026-01-31 01:25:19 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 22, 2020):

:tada:This issue was addressed in #6754, which has now been successfully released as Windows Terminal Preview v1.2.2022.0.🎉

Handy links:

@ghost commented on GitHub (Jul 22, 2020): :tada:This issue was addressed in #6754, which has now been successfully released as `Windows Terminal Preview v1.2.2022.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.2.2022.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 01:25:19 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 21, 2020):

🎉 As of Windows Insider build 20197, this is also supported in the traditional console.

@DHowett commented on GitHub (Aug 21, 2020): 🎉 As of Windows Insider build 20197, this is also supported in the traditional console.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Area-VT Issue-Task Product-Conhost Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#8278
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?