starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

The explorer context menu should only appear on shift+click #8453

New Issue
Open
opened 2026-01-31 01:29:49 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 01:29:49 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (May 21, 2020).

Follow-up from #6100.

The Explorer context menu is notoriously cluttered. We shouldn't add to that clutter if we can avoid it. This issue represents me taking the time to investigate how exactly to make the menu only appear on shift+right click, not just right click.

Originally created by @zadjii-msft on GitHub (May 21, 2020). Follow-up from #6100. The Explorer context menu is notoriously cluttered. We shouldn't add to that clutter if we can avoid it. This issue represents me taking the time to investigate how exactly to make the menu only appear on shift+right click, not _just_ right click.
claunia added the Help WantedIssue-TaskProduct-TerminalArea-ShellExtension labels 2026-01-31 01:29:50 +00:00
claunia commented 2026-01-31 01:29:50 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 1, 2020):

Alright so we took a quick peek through the code and we're not sure exactly how to do this. Fortunately, PowerToys does seem to do something similar:

d16ebba9e0/src/modules/powerrename/dll/PowerRenameExt.cpp (L60-L110)

Looks like they implement another interface, IContextMenu. If someone in the community was passionate about decluttering the context menu, we'd definitely appreciate a similar PR 😄

EDIT: As mentioned in an offline thread:

You should stick to the IExplorerCommand implementation and avoid IContextMenu if possible.

and also mentioned here:

If you return ECS_HIDDEN as a function of the keyboard state (if (GetKeyState(VK_SHIFT) < 0) or GetAsyncKeyState(), read the docs on both, I'm not sure which is the right one to use in this case) this can be hidden conditionally. This depends on the shell calling your handler coincident with presenting the UI. I think that is always true but might not always be. Pay attention to this issue and lets discuss with the File Explorer owners.

@zadjii-msft commented on GitHub (Jun 1, 2020): ~Alright so we took a quick peek through the code and we're not sure exactly how to do this. Fortunately, PowerToys does seem to do something similar:~ ~https://github.com/microsoft/PowerToys/blob/d16ebba9e0f06e7a0d41d981aeb1fd0a78192dc0/src/modules/powerrename/dll/PowerRenameExt.cpp#L60-L110~ ~Looks like they implement another interface, `IContextMenu`. If someone in the community was passionate about decluttering the context menu, we'd definitely appreciate a similar PR 😄~ EDIT: As mentioned in an offline thread: > You should stick to the IExplorerCommand implementation and avoid IContextMenu if possible. and also mentioned [here](https://github.com/microsoft/terminal/pull/6100#discussion_r433367245): > > If you return `ECS_HIDDEN` as a function of the keyboard state (if `(GetKeyState(VK_SHIFT) < 0)` or `GetAsyncKeyState()`, read the docs on both, I'm not sure which is the right one to use in this case) this can be hidden conditionally. This depends on the shell calling your handler coincident with presenting the UI. I think that is always true but might not always be. Pay attention to this issue and lets discuss with the File Explorer owners.
claunia commented 2026-01-31 01:29:50 +00:00
Author
Owner
Copy Link

@rescenic commented on GitHub (Jun 26, 2020):

Yeah, it's ugly long name. I am trying to disable that context menu. But I can't find Windows Terminal Preview context menu item using Nirsoft tools, like ShellExView and ShellMenuView.
img

@rescenic commented on GitHub (Jun 26, 2020): Yeah, it's ugly long name. I am trying to disable that context menu. But I can't find Windows Terminal Preview context menu item using Nirsoft tools, like ShellExView and ShellMenuView. ![img](https://i.ibb.co/zZChTNN/23-06-2020-863-23-33-27.png)
claunia commented 2026-01-31 01:29:51 +00:00
Author
Owner
Copy Link

@igorakkerman commented on GitHub (Jul 4, 2020):

Please make this configurable, Terminal is a core application in my work and should not be a secondary function.

@igorakkerman commented on GitHub (Jul 4, 2020): Please make this configurable, Terminal is a core application in my work and should not be a secondary function.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-ShellExtension Help Wanted Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#8453
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?