starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

A few typos in razzle.cmd #846

New Issue
Closed
opened 2026-01-30 22:06:19 +00:00 by claunia · 4 comments
claunia commented 2026-01-30 22:06:19 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (May 8, 2019).

As mentioned in #436, there are a few typos, where we're searching %ProgramFiles% but setting %ProgramFiles(x86)%.

3d7c260581/tools/razzle.cmd (L40-L43)

3d7c260581/tools/razzle.cmd (L48-L51)

3d7c260581/tools/razzle.cmd (L56-L59)

If we get a PR that uses vswhere instead of searching manually, then this won't be needed obviously

Originally created by @zadjii-msft on GitHub (May 8, 2019). As mentioned in #436, there are a few typos, where we're searching `%ProgramFiles%` but setting `%ProgramFiles(x86)%`. https://github.com/Gnbrkm41/Terminal/blob/3d7c2605818e7278453d85a2d76c3c8356dc95bb/tools/razzle.cmd#L40-L43 https://github.com/Gnbrkm41/Terminal/blob/3d7c2605818e7278453d85a2d76c3c8356dc95bb/tools/razzle.cmd#L48-L51 https://github.com/Gnbrkm41/Terminal/blob/3d7c2605818e7278453d85a2d76c3c8356dc95bb/tools/razzle.cmd#L56-L59 If we get a PR that uses `vswhere` instead of searching manually, then this won't be needed obviously
claunia added the Help WantedIssue-BugArea-Build labels 2026-01-30 22:06:19 +00:00
claunia commented 2026-01-30 22:06:20 +00:00
Author
Owner
Copy Link

@Gnbrkm41 commented on GitHub (May 8, 2019):

oops, my bad

@Gnbrkm41 commented on GitHub (May 8, 2019): oops, my bad
claunia commented 2026-01-30 22:06:20 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 9, 2019):

This will also be resolved by #606.

@DHowett-MSFT commented on GitHub (May 9, 2019): This will also be resolved by #606.
claunia commented 2026-01-30 22:06:20 +00:00
Author
Owner
Copy Link

@Gnbrkm41 commented on GitHub (May 11, 2019):

shouldn't this be closed now? 😁

@Gnbrkm41 commented on GitHub (May 11, 2019): shouldn't this be closed now? 😁
claunia commented 2026-01-30 22:06:20 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 13, 2019):

Yep, good catch

@zadjii-msft commented on GitHub (May 13, 2019): Yep, good catch
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build Help Wanted Issue-Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#846
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?