starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Extra space cell inserted after unicode character #8529

New Issue
Closed
opened 2026-01-31 01:31:44 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 01:31:44 +00:00
Owner
Copy Link

Originally created by @willmcgugan on GitHub (May 23, 2020).

Originally assigned to: @lhecker on GitHub.

Environment

Platform ServicePack Version      VersionString
-------- ----------- -------      -------------
 Win32NT             10.0.18363.0 Microsoft Windows NT 10.0.18363.0

Terminal v1.0.1401.0

Steps to reproduce

Write the following string to the terminal (Python):

>>> print("│\x1b[33m\U0001F862\x1b[0m│")

This string is a unicode box char, followed by a foreground yellow escape, a unicode arrow, a reset escape, and another box character.

Expected behavior

The string should render three characters: a vertical line, yellow arrow, vertical line.

Actual behavior

There is an extra space after the arrow.

Screen Shot 2020-05-23 at 14 45 16

Note that this only occurs with that particular unicode character. If I replace that unicode arrow with any other character then it renders as expected.

Originally created by @willmcgugan on GitHub (May 23, 2020). Originally assigned to: @lhecker on GitHub. # Environment ```none Platform ServicePack Version VersionString -------- ----------- ------- ------------- Win32NT 10.0.18363.0 Microsoft Windows NT 10.0.18363.0 Terminal v1.0.1401.0 ``` # Steps to reproduce Write the following string to the terminal (Python): ``` >>> print("│\x1b[33m\U0001F862\x1b[0m│") ``` This string is a unicode box char, followed by a foreground yellow escape, a [unicode arrow](https://www.fileformat.info/info/unicode/char/1f862/index.htm), a reset escape, and another box character. # Expected behavior The string should render three characters: a vertical line, yellow arrow, vertical line. # Actual behavior There is an extra space after the arrow. <img width="424" alt="Screen Shot 2020-05-23 at 14 45 16" src="https://user-images.githubusercontent.com/554369/82732307-503fa600-9d04-11ea-868c-b041aab85d5f.png"> Note that this only occurs with that particular unicode character. If I replace that unicode arrow with any other character then it renders as expected.
claunia commented 2026-01-31 01:31:46 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 23, 2020):

This is wild. Through-and-through, the infrastructure believes this to be a single-cell glyph. We're doing the right thing by the UCD, but then when the pseudoconsole emits it it emits it with an additional cursor move.

␛[?25h|␛[33m🡢␛[m␛[1C|␍␊
                 ^^^^
                 here
@DHowett commented on GitHub (May 23, 2020): This is _wild_. Through-and-through, the infrastructure believes this to be a single-cell glyph. We're doing the right thing by the UCD, but then _when the pseudoconsole emits it_ it emits it with an additional cursor move. ``` ␛[?25h|␛[33m🡢␛[m␛[1C|␍␊ ^^^^ here ```
claunia commented 2026-01-31 01:31:46 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 23, 2020):

(And of course, only when there's a color run break. This sound ominously related to our attribute run splitter and how it thinks the cursor moves when it splits runs.)

@DHowett commented on GitHub (May 23, 2020): (And of course, only when there's a color run break. This sound ominously related to our attribute run splitter and how it thinks the cursor moves when it splits runs.)
claunia commented 2026-01-31 01:31:47 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (May 24, 2020):

I think this is actually a conhost problem - you'll see the same issue there. The conpty sequence is just trying to reproduce the state of the conhost buffer which is already incorrect.

And the color change isn't really what's triggering it - any control character will do. The state machine splits up runs of text separated by control characters. And once a run of text is written, the cursor position is moved forward the expected number of columns (which in this case is off by 1). The next run of text is then starting in the wrong position, so you get a gap.

And the reason why it's off by 1 is because the character is processed as a surrogate pair, which the WriteCharsLegacy function sees as two characters, thus moving forward two columns.

@j4james commented on GitHub (May 24, 2020): I think this is actually a conhost problem - you'll see the same issue there. The conpty sequence is just trying to reproduce the state of the conhost buffer which is already incorrect. And the color change isn't really what's triggering it - any control character will do. The state machine splits up runs of text separated by control characters. And once a run of text is written, the cursor position is moved forward the expected number of columns (which in this case is off by 1). The next run of text is then starting in the wrong position, so you get a gap. And the reason why it's off by 1 is because the character is processed as a surrogate pair, which the `WriteCharsLegacy` function sees as two characters, thus moving forward two columns.
claunia commented 2026-01-31 01:31:47 +00:00
Author
Owner
Copy Link

@lursyy commented on GitHub (Dec 21, 2020):

I have another arrow example which I believe is related:

The robbyrussell prompt for zsh and fish uses the "➜" (U+279C) character.
It renders nicely (i.e. two characters wide) in the VS Code integrated terminal (irrespective of the font setting). Here I selected the first character for illustration:
image

In MS Terminal however, it renders as a single arrow followed by space (again, with first char selected):
image

FWIW:

  • When copying the single-character arrow from MS Terminal, I get ➜.
  • When copying the first part of the double-character arrow (i.e. the "stem") from VS Code, I get ➜.
  • When copying the second part of the double-character arrow (i.e. the "tip") from VS Code, I get . (Seems to be a plain old space?)

Do VS Code and MS Terminal share some of the underlying infrastructure in that regard? If so, one could take a look at how it works over there?

@lursyy commented on GitHub (Dec 21, 2020): I have another arrow example which I believe is related: The [robbyrussell](https://github.com/oh-my-fish/theme-robbyrussell) prompt for zsh and fish uses the "➜" (U+279C) character. It renders nicely (i.e. two characters wide) in the VS Code integrated terminal (irrespective of the font setting). Here I selected the first character for illustration: ![image](https://user-images.githubusercontent.com/13033130/102775266-c84e7700-438c-11eb-8984-9bcfc4c07406.png) In MS Terminal however, it renders as a single arrow followed by space (again, with first char selected): ![image](https://user-images.githubusercontent.com/13033130/102775354-f9c74280-438c-11eb-92ed-b12d269e4dcb.png) FWIW: * When copying the single-character arrow from MS Terminal, I get `➜`. * When copying the *first part* of the double-character arrow (i.e. the "stem") from VS Code, I get `➜`. * When copying the *second part* of the double-character arrow (i.e. the "tip") from VS Code, I get ` `. (Seems to be a plain old space?) Do VS Code and MS Terminal share some of the underlying infrastructure in that regard? If so, one could take a look at how it works over there?
claunia commented 2026-01-31 01:31:47 +00:00
Author
Owner
Copy Link

@thchr commented on GitHub (Jan 5, 2022):

There's a similar issue with the 𝑝 character (unicode U+1D45D): sometimes, a space will be inserted after 𝑝, sometimes it won't.
Similarly, even typing 𝑝 in WSL displayed on Terminal will basically garble that whole line.

@thchr commented on GitHub (Jan 5, 2022): There's a similar issue with the `𝑝` character (unicode U+1D45D): sometimes, a space will be inserted after 𝑝, sometimes it won't. Similarly, even typing `𝑝` in WSL displayed on Terminal will basically garble that whole line.
claunia commented 2026-01-31 01:31:47 +00:00
Author
Owner
Copy Link

@suasgn commented on GitHub (Nov 16, 2022):

I face a similar issue as described on oh-my-posh/issues#3088

image

The font I use is Caskaydia Cove Nerd Font

Oh My Posh v12.14.0

Windows Terminal - Version: 1.15.2875.0

@suasgn commented on GitHub (Nov 16, 2022): I face a similar issue as described on [oh-my-posh/issues#3088](https://github.com/JanDeDobbeleer/oh-my-posh/issues/3088) ![image](https://user-images.githubusercontent.com/5080378/202193877-9294b70f-dc12-430e-bd29-fb33d5301961.png) The font I use is [Caskaydia Cove Nerd Font](https://github.com/ryanoasis/nerd-fonts/releases/download/v2.2.2/CascadiaCode.zip) Oh My Posh v12.14.0 Windows Terminal - Version: 1.15.2875.0
claunia commented 2026-01-31 01:31:47 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 24, 2023):

:tada:This issue was addressed in #14640, which has now been successfully released as Windows Terminal Preview v1.17.1023.🎉

Handy links:

@ghost commented on GitHub (Jan 24, 2023): :tada:This issue was addressed in #14640, which has now been successfully released as `Windows Terminal Preview v1.17.1023`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.17.1023) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Output Help Wanted Issue-Bug Priority-2 Product-Conhost Product-Conpty Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#8529
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?