starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Please add acrylic:"false" to user json if it is not specified in a profile #8614

New Issue
Closed
opened 2026-01-31 01:33:49 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 01:33:49 +00:00
Owner
Copy Link

Originally created by @Karl-WE on GitHub (May 27, 2020).

Description of the new feature/enhancement

Current version generates two settings json files. A baseline that may not be edited (ctrl+settings) and a user locale one that a user can edit.
Both will have auto generated profiles for recognized products ex. PoSh 7, cmd etc.
That's great.

For all users that might not want to dig deep into all possible settings that a json can possibly hold it's not easy to understand without reading docs and knowing of the existence of the global settings json how to enable acrylic, one of the liked gimmicks of terminal.

The reason is that in all profiles of the global json have acrylic set to false by default.

Again changing the default json isn't possible.

Adding acrylic manually can be quite some work if one has many consoles installed.

Adding this frequent option manually is prone to user errors when setting this up or copy and adding from the default json. Especially json formatting issues without using a proper editor like VSC. Not all might want to install VSC or other code aware editors as notepad++ but by default we have Microsoft Notepad (app).

Currently the local user json is missing acrylic.

Proposed technical implementation details (optional)

While generating the user local json, parse for profiles that are missing the setting for acrylic.

Add acrylic:"false",

If it does exist in a profile don't touch.

This would ease the usage.

Originally created by @Karl-WE on GitHub (May 27, 2020). # Description of the new feature/enhancement Current version generates two settings json files. A baseline that may not be edited (ctrl+settings) and a user locale one that a user can edit. Both will have auto generated profiles for recognized products ex. PoSh 7, cmd etc. That's great. For all users that might not want to dig deep into all possible settings that a json can possibly hold it's not easy to understand without reading docs and knowing of the existence of the global settings json how to enable acrylic, one of the liked gimmicks of terminal. The reason is that in all profiles of the global json have acrylic set to false by default. Again changing the default json isn't possible. Adding acrylic manually can be quite some work if one has many consoles installed. Adding this frequent option manually is prone to user errors when setting this up or copy and adding from the default json. Especially json formatting issues without using a proper editor like VSC. Not all might want to install VSC or other code aware editors as notepad++ but by default we have Microsoft Notepad (app). Currently the local user json is missing acrylic. # Proposed technical implementation details (optional) While generating the user local json, parse for profiles that are missing the setting for acrylic. Add acrylic:"false", If it does exist in a profile don't touch. This would ease the usage.
claunia commented 2026-01-31 01:33:50 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 27, 2020):

This is a bit of a slippery slope though - if we are okay adding useAcrylic and acrylicOpacity, then why aren't we okay adding all the backgroundImage* properties? Following this through to conclusion would lead to the default settings file we generate containing full lists of all the available properties, which is one of the things we're explicitly trying to avoid.

The right long-term solution for "easier settings management" is probably just the settings UI in #1564.

@zadjii-msft commented on GitHub (May 27, 2020): This is a bit of a slippery slope though - if we are okay adding `useAcrylic` and `acrylicOpacity`, then why aren't we okay adding all the `backgroundImage*` properties? Following this through to conclusion would lead to the default settings file we generate containing full lists of all the available properties, which is one of the things we're explicitly trying to _avoid_. The right long-term solution for "easier settings management" is probably just the settings UI in #1564.
claunia commented 2026-01-31 01:33:50 +00:00
Author
Owner
Copy Link

@Karl-WE commented on GitHub (May 27, 2020):

I would be fine to add all or at least the major features.
Why not, as long we don't have the GUI for this. A full list might get unreadable. I agree.

@Karl-WE commented on GitHub (May 27, 2020): I would be fine to add all or at least the major features. Why not, as long we don't have the GUI for this. A full list might get unreadable. I agree.
claunia commented 2026-01-31 01:33:50 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 27, 2020):

Yea, the full list was horribly unmanagable. It's overall been much easier on users to just include the settings that people want changed in their settings.

Since we're not about to start adding more settings to the default settings file, I'm gonna close this out. Thanks!

@zadjii-msft commented on GitHub (May 27, 2020): Yea, the full list was horribly unmanagable. It's overall been much easier on users to just include the settings that people want _changed_ in their settings. Since we're not about to start adding more settings to the default settings file, I'm gonna close this out. Thanks!
claunia commented 2026-01-31 01:33:51 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 27, 2020):

@Karl-WE However, I recognize that you've been with us for quite a long time! The new "default" template settings file is a lot different from the one you got when you started with Terminal 0.1 or 0.2.

If you back up your settings and delete the file, you might have a nicer time. Some of the default bindings changed, which might catch you out. Scott Hanselman wrote up a blog post about refreshing your settings, if you're interested.

@DHowett commented on GitHub (May 27, 2020): @Karl-WE However, I recognize that you've been with us for quite a long time! The new "default" template settings file is a lot different from the one you got when you started with Terminal 0.1 or 0.2. If you back up your settings and delete the file, you might have a nicer time. Some of the default bindings changed, which might catch you out. Scott Hanselman wrote up a blog post about [refreshing your settings](https://www.hanselman.com/blog/NowIsTheTimeToMakeAFreshNewWindowsTerminalProfilesjson.aspx), if you're interested.
claunia commented 2026-01-31 01:33:51 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 27, 2020):

The new format also supports a defaults block that lets you set a setting once for all profiles.

@DHowett commented on GitHub (May 27, 2020): The new format also supports a defaults block that lets you set a setting once for _all_ profiles.
claunia commented 2026-01-31 01:33:51 +00:00
Author
Owner
Copy Link

@Karl-WE commented on GitHub (May 27, 2020):

@zadjii-msft @DHowett thanks for your taking time to explain. How about a last idea on this:
users that might have old settings jsons, might get a notification as explained by Dustin on the first start after an upgrade. This will ensure awareness and consistent expierence across the users. What do you think? If you agree I'll take the time for a new issue-feature.

@Karl-WE commented on GitHub (May 27, 2020): @zadjii-msft @DHowett thanks for your taking time to explain. How about a last idea on this: users that might have old settings jsons, might get a notification as explained by Dustin on the first start after an upgrade. This will ensure awareness and consistent expierence across the users. What do you think? If you agree I'll take the time for a new issue-feature.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Question Needs-Attention Needs-Triage Product-Terminal Resolution-Answered
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#8614
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?