Specifying a font with name longer than 32 characters causes the app to crash #862

Closed
opened 2026-01-30 22:07:02 +00:00 by claunia · 3 comments
Owner

Originally created by @luk1337 on GitHub (May 8, 2019).

The font handling code uses LF_FACESIZE define from wingdi.h which is set to 32, however some fonts like "Droid Sans Mono Dotted for Powerline" use name longer than that which makes the Terminal app crash when trying to load font.

Originally created by @luk1337 on GitHub (May 8, 2019). The font handling code uses LF_FACESIZE define from wingdi.h which is set to 32, however some fonts like "Droid Sans Mono Dotted for Powerline" use name longer than that which makes the Terminal app crash when trying to load font.
Author
Owner

@DHowett-MSFT commented on GitHub (May 9, 2019):

Alas, it’s true. Thanks for the report!


From: luk1337 notifications@github.com
Sent: Wednesday, May 8, 2019 3:17:58 PM
To: microsoft/Terminal
Cc: Subscribed
Subject: [microsoft/Terminal] Specifying a font with name longer than 32 characters causes the app to crash (#602)

The font handling code uses LF_FACESIZE define from wingdi.h which is set to 32, however some fonts like "Droid Sans Mono Dotted for Powerline" use name longer than that which makes the Terminal app crash when trying to load font.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTerminal%2Fissues%2F602&data=01%7C01%7Cduhowett%40microsoft.com%7C33a2886931ab4ba559fc08d6d4030741%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=8p8HtsfYgH55%2FikZhch1BqknprXpYbfLa1sjzV6V%2Fto%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADNHLGVXI5MHSPIQGIKP2KDPUNGRNANCNFSM4HLVUXAA&data=01%7C01%7Cduhowett%40microsoft.com%7C33a2886931ab4ba559fc08d6d4030741%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=ROr4XMTNuP2CxAfZQzpIE%2BAv5MW0RitYRjgn8KXlZjc%3D&reserved=0.

@DHowett-MSFT commented on GitHub (May 9, 2019): Alas, it’s true. Thanks for the report! ________________________________ From: luk1337 <notifications@github.com> Sent: Wednesday, May 8, 2019 3:17:58 PM To: microsoft/Terminal Cc: Subscribed Subject: [microsoft/Terminal] Specifying a font with name longer than 32 characters causes the app to crash (#602) The font handling code uses LF_FACESIZE define from wingdi.h which is set to 32, however some fonts like "Droid Sans Mono Dotted for Powerline" use name longer than that which makes the Terminal app crash when trying to load font. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTerminal%2Fissues%2F602&data=01%7C01%7Cduhowett%40microsoft.com%7C33a2886931ab4ba559fc08d6d4030741%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=8p8HtsfYgH55%2FikZhch1BqknprXpYbfLa1sjzV6V%2Fto%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADNHLGVXI5MHSPIQGIKP2KDPUNGRNANCNFSM4HLVUXAA&data=01%7C01%7Cduhowett%40microsoft.com%7C33a2886931ab4ba559fc08d6d4030741%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=ROr4XMTNuP2CxAfZQzpIE%2BAv5MW0RitYRjgn8KXlZjc%3D&reserved=0>.
Author
Owner

@DHowett-MSFT commented on GitHub (May 9, 2019):

This will require us to tease apart the FontInfoBase parts that pertain to GDI alone and the parts that can be generic for DX.

@DHowett-MSFT commented on GitHub (May 9, 2019): This will require us to tease apart the `FontInfoBase` parts that pertain to GDI alone and the parts that can be generic for DX.
Author
Owner

@ghost commented on GitHub (Oct 23, 2019):

:tada:This issue was addressed in #3107, which has now been successfully released as Windows Terminal Preview v0.6.2951.0.🎉

Handy links:

@ghost commented on GitHub (Oct 23, 2019): :tada:This issue was addressed in #3107, which has now been successfully released as `Windows Terminal Preview v0.6.2951.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.6.2951.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#862