Shell extension displays an error when you launch it from the root of a drive #8652

Closed
opened 2026-01-31 01:34:39 +00:00 by claunia · 5 comments
Owner

Originally created by @DHowett on GitHub (May 28, 2020).

Originally assigned to: @zadjii-msft on GitHub.

image

Originally created by @DHowett on GitHub (May 28, 2020). Originally assigned to: @zadjii-msft on GitHub. ![image](https://user-images.githubusercontent.com/189190/83201470-62ea1e80-a0fa-11ea-9ab0-20ca4581ec97.png)
Author
Owner

@zadjii-msft commented on GitHub (May 29, 2020):

what the heck

image

I might need you to investigate this one, because I can't repro this 😨

Maybe this is a (Preview) bug?

@zadjii-msft commented on GitHub (May 29, 2020): what the heck ![image](https://user-images.githubusercontent.com/18356694/83262501-b607b400-a182-11ea-8301-6bdb55153314.png) I might need you to investigate this one, because I can't repro this 😨 Maybe this is a (Preview) bug?
Author
Owner

@DHowett commented on GitHub (May 29, 2020):

Hmm! I’ll look, since you can’t repro.

@DHowett commented on GitHub (May 29, 2020): Hmm! I’ll look, since you can’t repro.
Author
Owner

@beviu commented on GitHub (Jun 5, 2020):

I tried to debug this:

  • On my computer, the IShellItemArray* psiItemArray argument in OpenTerminalHere::Invoke is nullptr when I click on the "Open Windows Terminal (Dev Build)" button without selecting anything (on the folder empty area).
  • Note: GetCurrentDirectory() always returns C:\Windows\System32 wherever I am in the explorer view, so it seems to be useless here.
@beviu commented on GitHub (Jun 5, 2020): I tried to debug this: * On my computer, the `IShellItemArray* psiItemArray` argument in `OpenTerminalHere::Invoke` is `nullptr` when I click on the "Open Windows Terminal (Dev Build)" button without selecting anything (on the folder empty area). * Note: `GetCurrentDirectory()` always returns `C:\Windows\System32` wherever I am in the explorer view, so it seems to be useless here.
Author
Owner

@zadjii-msft commented on GitHub (Jun 8, 2020):

For the record, this is a bug that's being tracked by MSFT:24623699 internally.

@zadjii-msft commented on GitHub (Jun 8, 2020): For the record, this is a bug that's being tracked by MSFT:24623699 internally.
Author
Owner

@ghost commented on GitHub (Jun 18, 2020):

:tada:This issue was addressed in #6415, which has now been successfully released as Windows Terminal Preview v1.1.1671.0.🎉

Handy links:

@ghost commented on GitHub (Jun 18, 2020): :tada:This issue was addressed in #6415, which has now been successfully released as `Windows Terminal Preview v1.1.1671.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.1.1671.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#8652