starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Light schemes are unusable: bold text is white #8717

New Issue
Closed
opened 2026-01-31 01:36:19 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 01:36:19 +00:00
Owner
Copy Link

Originally created by @mscha on GitHub (May 31, 2020).

Environment

Windows build number: 10.0.19041.264
Windows Terminal version (if applicable): 1.0.1401.0

Any other software?

Steps to reproduce

Configure a WSL profile to use a light color scheme, e.g. Solarized Light.
Open that profile.
Output some bold text, e.g.:

echo `tput bold`Hello`tput sgr0` World

Expected behavior

Ideally, the output should be:
Hello World
with “Hello” in bold. But as long as bold fonts are not supported, it should be emphasized using a slightly different color.

Actual behavior

The word “Hello” is white, and therefore basically invisible. “World” is written in the standard text color.

The “bold color” logic currently assumes that white is a reasonable “bold” color for the standard text color. This might be true on most dark schemes, but not on light schemes.

Originally created by @mscha on GitHub (May 31, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: 10.0.19041.264 Windows Terminal version (if applicable): 1.0.1401.0 Any other software? ``` # Steps to reproduce Configure a WSL profile to use a light color scheme, e.g. Solarized Light. Open that profile. Output some bold text, e.g.: echo `tput bold`Hello`tput sgr0` World <!-- A description of how to trigger this bug. --> # Expected behavior Ideally, the output should be: **Hello** World with “Hello” in bold. But as long as bold fonts are not supported, it should be emphasized using a slightly different color. <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> # Actual behavior The word “Hello” is white, and therefore basically invisible. “World” is written in the standard text color. The “bold color” logic currently assumes that white is a reasonable “bold” color for the standard text color. This might be true on most dark schemes, but not on light schemes. <!-- What's actually happening? -->
claunia added the Resolution-Duplicate label 2026-01-31 01:36:19 +00:00
claunia commented 2026-01-31 01:36:20 +00:00
Author
Owner
Copy Link

@fishfacemcgee commented on GitHub (Jun 3, 2020):

There are similar readability issues on Solarized Dark, too:

Solarized Dark:

image

The same text on Solarized Light:

image

@fishfacemcgee commented on GitHub (Jun 3, 2020): There are similar readability issues on Solarized Dark, too: Solarized Dark: ![image](https://user-images.githubusercontent.com/1767723/83666775-79c9be80-a59b-11ea-9dfe-1b6c77c2540a.png) The same text on Solarized Light: ![image](https://user-images.githubusercontent.com/1767723/83666802-85b58080-a59b-11ea-8aba-ed0c785e84c8.png)
claunia commented 2026-01-31 01:36:20 +00:00
Author
Owner
Copy Link

@Artoria2e5 commented on GitHub (Jun 3, 2020):

This is related to #109. Instead of turning bold into the bright colors, they should have a (default, IMO) option for actual bold text. There's also missing support for italics, underline, etc.

Yeah, @jdebp's wonderful tests now show good underline. The 8-bit one works under 65001; the Unicode one with forced UTF-8 was never supposed to work I guess.

@Artoria2e5 commented on GitHub (Jun 3, 2020): This is related to #109. Instead of turning bold into the bright colors, they should have a (default, IMO) option for actual bold text. There's also missing support for italics, ~~underline~~, etc. * * * Yeah, @jdebp's wonderful tests now show good underline. The 8-bit one works under 65001; the Unicode one with forced UTF-8 was never supposed to work I guess.
claunia commented 2026-01-31 01:36:20 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 3, 2020):

image

but your point stands

@DHowett commented on GitHub (Jun 3, 2020): ![image](https://user-images.githubusercontent.com/189190/83676654-e17a0c80-a58f-11ea-964e-0d99c8952002.png) but your point stands
claunia commented 2026-01-31 01:36:20 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jun 5, 2020):

I think this particular issue is more a duplicate of #5682. Regardless of whether we add support for a bold font face, our handling of bright default colors could do with some work. That could include making use of the bold color when the color scheme provides one, or a fallback that just fabricates a brighter version of the default foreground color. At the moment the bright default combo only works if the default color matches one of the first 8 palette entries.

@j4james commented on GitHub (Jun 5, 2020): I think this particular issue is more a duplicate of #5682. Regardless of whether we add support for a bold font face, our handling of bright default colors could do with some work. That could include making use of the bold color when the color scheme provides one, or a fallback that just fabricates a brighter version of the default foreground color. At the moment the bright default combo only works if the default color matches one of the first 8 palette entries.
claunia commented 2026-01-31 01:36:21 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 5, 2020):

Yea, this largely seems like it's discussion that's better suited in #5682. Thanks all!

/dup #5682

@zadjii-msft commented on GitHub (Jun 5, 2020): Yea, this largely seems like it's discussion that's better suited in #5682. Thanks all! /dup #5682
claunia commented 2026-01-31 01:36:21 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jun 5, 2020):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Jun 5, 2020): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#8717
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?