starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Color0 (black) being set and used as default background in Solarized Light theme #8721

New Issue
Closed
opened 2026-01-31 01:36:23 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 01:36:23 +00:00
Owner
Copy Link

Originally created by @djwf on GitHub (Jun 1, 2020).

Environment

Microsoft Windows NT 10.0.19041.0
Windows Terminal Version: 1.0.1401.0
WSLtty Version: 3.1.4.2

Steps to reproduce

Enable the solarized light theme (add "colorScheme": "Solarized Light" to WSL profile).

Open Windows Terminal WSL console.

Execute the following printf "\033[49;39mDEFBG-DEFFG\033[40;39mCOLOR0-DEFFG\033[0m\n".

Expected behavior

The expected behavior is demonstrated by executing the printf command listed in steps to reproduce in wsltty, using the color configuration listed below.

ForegroundColour=101,123,131 # base00, #657b83
BackgroundColour=253,246,227 # base3,  #fdf6e3
CursorColour=38,139,210      # blue,   #268bd2
# Solarized colors for (min|wsl)tty.
# Color 0
Black=7,54,66           # base02,  #073642
# Color 1
Red=220,50,47           # red,     #dc322f
# Color 2
Green=133,153,0         # green,   #859900
# Color 3
Yellow=181,137,0        # yellow,  #b58900
# Color 4
Blue=38,139,210         # blue,    #268bd2
# Color 5
Magenta=211,54,130      # magenta, #d33682
# Color 6
Cyan=42,161,152         # cyan,    #2aa198
# Color 7
White=238,232,213       # base2,   #eee8d5
# Color 8
BoldBlack=0,43,54       # base03,  #002b36
# Color 9
BoldRed=203,75,22       # orange,  #cb4b16
# Color 10
BoldGreen=88,110,117    # base01,  #586e75
# Color 11
BoldYellow=101,123,131  # base00,  #657b83
# Color 12
BoldBlue=131,148,150    # base0,   #839496
# Color 13
BoldMagenta=108,113,196 # violet,  #6c71c4
# Color 14
BoldCyan=147,161,161    # base1,   #93a1a1
# Color 15
BoldWhite=253,246,227   # base3,   #fdf6e3

The result was the following:

wsltty-color0-defaultbg

The command colortest-8 can also be used to see the issue, by looking at the reverse section. In wsltty the reverse section is as follows.

wsltty-colortest-8-reverse

Actual behavior

The actual behavior is that the default background color seems to be written to color0 ("black" in the color scheme). See the outcome of the printf command listed in steps to reproduce executed in a Windows Terminal WSL console below.

winterm-color0-defaultbg

Note that the default background color in the image is the same as color0, even though the Solarized Light scheme defines them to be different colors. This can also be seen in the output of colortest-8, where the background of the header of each row in the reverse section should be gray, and the background of the color named fields in the first row of the reverse section should be whatever the "black" color is set to, as seen below.

winterm-colortest-8-reverse

I also tried creating my own color scheme by copying the Solarized Light scheme, and making sure the background, foreground, and black (color0) colors were set (see scheme below). The results were the same as using the built in Solarized Light.

        {
            "name": "Solarized Light (djwf)",
            "foreground": "#657B83",
            "background": "#FDF6E3",
            "cursorColor": "#268BD2",
            "black": "#073642",
            "red": "#DC322F",
            "green": "#859900",
            "yellow": "#B58900",
            "blue": "#268BD2",
            "purple": "#D33682",
            "cyan": "#2AA198",
            "white": "#EEE8D5",
            "brightBlack": "#002B36",
            "brightRed": "#CB4B16",
            "brightGreen": "#586E75",
            "brightYellow": "#657B83",
            "brightBlue": "#839496",
            "brightPurple": "#6C71C4",
            "brightCyan": "#93A1A1",
            "brightWhite": "#FDF6E3"
        }

I think that's it, please let me know if you need more information.

Originally created by @djwf on GitHub (Jun 1, 2020). # Environment ```none Microsoft Windows NT 10.0.19041.0 Windows Terminal Version: 1.0.1401.0 WSLtty Version: 3.1.4.2 ``` # Steps to reproduce Enable the solarized light theme (add "colorScheme": "Solarized Light" to WSL profile). Open Windows Terminal WSL console. Execute the following `printf "\033[49;39mDEFBG-DEFFG\033[40;39mCOLOR0-DEFFG\033[0m\n"`. # Expected behavior The expected behavior is demonstrated by executing the `printf` command listed in steps to reproduce in `wsltty`, using the color configuration listed below. ```ini ForegroundColour=101,123,131 # base00, #657b83 BackgroundColour=253,246,227 # base3, #fdf6e3 CursorColour=38,139,210 # blue, #268bd2 # Solarized colors for (min|wsl)tty. # Color 0 Black=7,54,66 # base02, #073642 # Color 1 Red=220,50,47 # red, #dc322f # Color 2 Green=133,153,0 # green, #859900 # Color 3 Yellow=181,137,0 # yellow, #b58900 # Color 4 Blue=38,139,210 # blue, #268bd2 # Color 5 Magenta=211,54,130 # magenta, #d33682 # Color 6 Cyan=42,161,152 # cyan, #2aa198 # Color 7 White=238,232,213 # base2, #eee8d5 # Color 8 BoldBlack=0,43,54 # base03, #002b36 # Color 9 BoldRed=203,75,22 # orange, #cb4b16 # Color 10 BoldGreen=88,110,117 # base01, #586e75 # Color 11 BoldYellow=101,123,131 # base00, #657b83 # Color 12 BoldBlue=131,148,150 # base0, #839496 # Color 13 BoldMagenta=108,113,196 # violet, #6c71c4 # Color 14 BoldCyan=147,161,161 # base1, #93a1a1 # Color 15 BoldWhite=253,246,227 # base3, #fdf6e3 ``` The result was the following: ![wsltty-color0-defaultbg](https://user-images.githubusercontent.com/73162/83369872-a7401d80-a38b-11ea-8871-d6f774d208e6.png) The command `colortest-8` can also be used to see the issue, by looking at the reverse section. In `wsltty` the reverse section is as follows. ![wsltty-colortest-8-reverse](https://user-images.githubusercontent.com/73162/83370192-9f34ad80-a38c-11ea-96f1-ae001f55f272.png) # Actual behavior The actual behavior is that the default background color seems to be written to color0 ("black" in the color scheme). See the outcome of the `printf` command listed in steps to reproduce executed in a Windows Terminal WSL console below. ![winterm-color0-defaultbg](https://user-images.githubusercontent.com/73162/83369884-adce9500-a38b-11ea-9989-655f4b92d3ea.png) Note that the default background color in the image is the same as color0, even though the Solarized Light scheme defines them to be different colors. This can also be seen in the output of `colortest-8`, where the background of the header of each row in the reverse section should be gray, and the background of the color named fields in the first row of the reverse section should be whatever the "black" color is set to, as seen below. ![winterm-colortest-8-reverse](https://user-images.githubusercontent.com/73162/83370267-e28f1c00-a38c-11ea-89cb-bf235d885047.png) I also tried creating my own color scheme by copying the Solarized Light scheme, and making sure the background, foreground, and black (color0) colors were set (see scheme below). The results were the same as using the built in Solarized Light. ```js { "name": "Solarized Light (djwf)", "foreground": "#657B83", "background": "#FDF6E3", "cursorColor": "#268BD2", "black": "#073642", "red": "#DC322F", "green": "#859900", "yellow": "#B58900", "blue": "#268BD2", "purple": "#D33682", "cyan": "#2AA198", "white": "#EEE8D5", "brightBlack": "#002B36", "brightRed": "#CB4B16", "brightGreen": "#586E75", "brightYellow": "#657B83", "brightBlue": "#839496", "brightPurple": "#6C71C4", "brightCyan": "#93A1A1", "brightWhite": "#FDF6E3" } ``` I think that's it, please let me know if you need more information.
claunia added the Resolution-Duplicate label 2026-01-31 01:36:23 +00:00
claunia commented 2026-01-31 01:36:24 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 1, 2020):

Thanks for the report! This is another version of #293 -- we were changing the palette in legacy applications for compatibility reasons. We'll be fixing that shortly.

/sup #293.

@DHowett commented on GitHub (Jun 1, 2020): Thanks for the report! This is another version of #293 -- we were changing the palette in legacy applications for compatibility reasons. We'll be fixing that shortly. /sup #293.
claunia commented 2026-01-31 01:36:24 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 1, 2020):

heh. /dup #293. 😄

@DHowett commented on GitHub (Jun 1, 2020): heh. /dup #293. :smile:
claunia commented 2026-01-31 01:36:25 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jun 1, 2020):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Jun 1, 2020): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
claunia commented 2026-01-31 01:36:25 +00:00
Author
Owner
Copy Link

@djwf commented on GitHub (Jun 1, 2020):

Whoops: I thought I'd searched sufficiently, but apparently not. Thanks for the heads up and link!

@djwf commented on GitHub (Jun 1, 2020): Whoops: I thought I'd searched sufficiently, but apparently not. Thanks for the heads up and link!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#8721
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?