Theme only work in profile Deafults. #8758

Closed
opened 2026-01-31 01:37:12 +00:00 by claunia · 9 comments
Owner

Originally created by @ghost on GitHub (Jun 2, 2020).

Hey, I have set my color scheme to a theme called Atom.
{ "name": "Atom", "black": "#000000", "red": "#fd5ff1", "green": "#87c38a", "yellow": "#ffd7b1", "blue": "#85befd", "purple": "#b9b6fc", "cyan": "#85befd", "white": "#e0e0e0", "brightBlack": "#000000", "brightRed": "#fd5ff1", "brightGreen": "#94fa36", "brightYellow": "#f5ffa8", "brightBlue": "#96cbfe", "brightPurple": "#b9b6fc", "brightCyan": "#85befd", "brightWhite": "#e0e0e0", "background": "#161719", "foreground": "#c72a2a"//"#c5c8c6" }
I Have verified it works, but only in the profile defaults. I can't set them in the profiles section per profile.

Originally created by @ghost on GitHub (Jun 2, 2020). Hey, I have set my color scheme to a theme called Atom. { "name": "Atom", "black": "#000000", "red": "#fd5ff1", "green": "#87c38a", "yellow": "#ffd7b1", "blue": "#85befd", "purple": "#b9b6fc", "cyan": "#85befd", "white": "#e0e0e0", "brightBlack": "#000000", "brightRed": "#fd5ff1", "brightGreen": "#94fa36", "brightYellow": "#f5ffa8", "brightBlue": "#96cbfe", "brightPurple": "#b9b6fc", "brightCyan": "#85befd", "brightWhite": "#e0e0e0", "background": "#161719", "foreground": "#c72a2a"//"#c5c8c6" } I Have verified it works, but only in the profile defaults. I can't set them in the profiles section per profile.
Author
Owner

@DHowett commented on GitHub (Jun 3, 2020):

As requested in the other thread, can you share a gist of your full settings file? Thanks!

@DHowett commented on GitHub (Jun 3, 2020): As requested in the other thread, can you share a [gist](https://gist.github.com) of your full settings file? Thanks!
Author
Owner
@ghost commented on GitHub (Jun 5, 2020): https://gist.github.com/IveGotRoot/2a978cb14c35428f12a0f554a5f29239
Author
Owner

@DHowett commented on GitHub (Jun 5, 2020):

I mean, you have two profiles that explicitly set the colorScheme to Campbell. Are those the ones that aren't working?

@DHowett commented on GitHub (Jun 5, 2020): I mean, you have two profiles that _explicitly_ set the `colorScheme` to `Campbell`. Are those the ones that aren't working?
Author
Owner

@ghost commented on GitHub (Jun 6, 2020):

All of them aren't working

@ghost commented on GitHub (Jun 6, 2020): All of them aren't working
Author
Owner

@ghost commented on GitHub (Jun 7, 2020):

I have them set as an experiment, I was just trying to set the theme to atom. Both of them were replaced correctly for the atom theme. I could only get it if I set the theme in default.

@ghost commented on GitHub (Jun 7, 2020): I have them set as an experiment, I was just trying to set the theme to atom. Both of them were replaced correctly for the atom theme. I could only get it if I set the theme in default.
Author
Owner

@zadjii-msft commented on GitHub (Jun 9, 2020):

Ah okay, I see it. The first profile in your list of profiles is... odd. It's got a source, but no guid, so it's not actually being correlated to any profile. If you wanted to change the properties of the "Windows Powershell" profile, you'd want the following:

            {
                "guid" : "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "name" : "Powershell",
                "acrylicOpacity" : 0.7,
                "fontFace" : "Cascadia Code PL",
                "colorScheme" : "Atom"
            },
@zadjii-msft commented on GitHub (Jun 9, 2020): Ah okay, I see it. The first profile in your list of profiles is... odd. It's got a `source`, but no `guid`, so it's not actually being correlated to _any_ profile. If you wanted to change the properties of the "Windows Powershell" profile, you'd want the following: ```json { "guid" : "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}", "name" : "Powershell", "acrylicOpacity" : 0.7, "fontFace" : "Cascadia Code PL", "colorScheme" : "Atom" }, ```
Author
Owner

@ghost commented on GitHub (Jun 9, 2020):

Thanks, It had no guid by default. Is that intentional?

@ghost commented on GitHub (Jun 9, 2020): Thanks, It had no guid by default. Is that intentional?
Author
Owner

@zadjii-msft commented on GitHub (Jun 9, 2020):

Definitely not - the ones that have the "source" property are dynamically generated and need the GUID to help the dynamic generator figure out which profile it is.

The "Windows Powershell" profile isn't dynamically generated, since it's always available on every version of Windows. It's defined in defaults.json, and also requires a GUID so the terminal can know that you're trying to change it's settings.

@zadjii-msft commented on GitHub (Jun 9, 2020): Definitely not - the ones that have the `"source"` property are [_dynamically generated_](https://docs.microsoft.com/en-us/windows/terminal/dynamic-profiles) and need the GUID to help the dynamic generator figure out which profile it is. The "Windows Powershell" profile _isn't_ dynamically generated, since it's always available on every version of Windows. It's defined in [`defaults.json`](https://github.com/microsoft/terminal/blob/master/src/cascadia/TerminalApp/defaults.json), and also requires a GUID so the terminal can know that you're trying to change it's settings.
Author
Owner

@ghost commented on GitHub (Jun 13, 2020):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost commented on GitHub (Jun 13, 2020): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#8758