starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

CascadiaSettings::LoadAll(true) config file content compares to itself #893

New Issue
Closed
opened 2026-01-30 22:08:33 +00:00 by claunia · 2 comments
claunia commented 2026-01-30 22:08:33 +00:00
Owner
Copy Link

Originally created by @bef178 on GitHub (May 9, 2019).

in CascadiaSettingsSerialization.cpp (how to cite existing code)

fileData => actualData => root => obj => resultPtr => json => serializedSettings
then comparing actualData and serializedSettings

Looks like during the transformation only default key bindings are added, which is not configurable and won't be saved. So I believe the config content compares to itself (format change?).

Does it expect comparing the config file content to in-memory in-using config?
Or, does it expect add default config and explicitly write default configs to config file?

Please correct me if I miss something.

1

Originally created by @bef178 on GitHub (May 9, 2019). in CascadiaSettingsSerialization.cpp (how to cite existing code) fileData => **actualData** => root => obj => resultPtr => json => **serializedSettings** then comparing actualData and serializedSettings Looks like during the transformation only default key bindings are added, which is not configurable and won't be saved. So I believe the config content compares to itself (format change?). Does it expect comparing the config file content to in-memory in-using config? Or, does it expect add default config and explicitly write default configs to config file? Please correct me if I miss something. ![1](https://user-images.githubusercontent.com/2749912/57459472-e5146480-72a5-11e9-94c0-dab9c54ca7ca.png)
claunia added the Issue-Question label 2026-01-30 22:08:33 +00:00
claunia commented 2026-01-30 22:08:34 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 9, 2019):

The purpose of what's happening here is to ensure the settings that are on disk match our runtime idea of what the settings schema is, and if the schema has changed, update the file on disk.

  1. So we'll parse the settings from the disk, to an in memory object.
  2. Then we'll try serializing that object.
  3. We'll compare the serialized one to the contents on disk. If they're different, it's possible the schema has changed, so re-write the updated schema to the disk.

The problem is that unfortunately, we're just doing a string compare, not a logical compare of the parsed json tree itself. This is unfortunately not something that Windows.Data.Json provides for us, which is why we're looking at alternatives. See #475 for a bigger discussion on the topic.

You're correct that the keybindings aren't getting serialized - they are added after all this serialization code. Adding support for serializing them is one of my top features right now :)

@zadjii-msft commented on GitHub (May 9, 2019): The purpose of what's happening here is to ensure the settings that are on disk match our runtime idea of what the settings schema is, and if the schema has changed, update the file on disk. 1. So we'll parse the settings from the disk, to an in memory object. 2. Then we'll try serializing that object. 3. We'll compare the serialized one to the contents on disk. If they're different, it's possible the schema has changed, so re-write the updated schema to the disk. The problem is that unfortunately, we're just doing a string compare, not a logical compare of the parsed json tree itself. This is unfortunately not something that Windows.Data.Json provides for us, which is why we're looking at alternatives. See #475 for a bigger discussion on the topic. You're correct that the keybindings aren't getting serialized - they are added after all this serialization code. Adding support for serializing them is one of my top features right now :)
claunia commented 2026-01-30 22:08:34 +00:00
Author
Owner
Copy Link

@bef178 commented on GitHub (May 9, 2019):

Thanks for clarification.

@bef178 commented on GitHub (May 9, 2019): Thanks for clarification.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Question
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#893
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?