starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Graphics Improvement: Update to DXGI 1.6 #8938

New Issue
Closed
opened 2026-01-31 01:41:51 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 01:41:51 +00:00
Owner
Copy Link

Originally created by @WSLUser on GitHub (Jun 9, 2020).

Description of the new feature/enhancement

Make use of features described in https://docs.microsoft.com/en-us/windows/win32/direct3ddxgi/dxgi-1-3-improvements, https://docs.microsoft.com/en-us/windows/win32/direct3ddxgi/dxgi-1-4-improvements, https://docs.microsoft.com/en-us/windows/win32/direct3ddxgi/dxgi-1-5-improvements, and https://docs.microsoft.com/en-us/windows/win32/direct3ddxgi/dxgi-1-6-improvements. Probably should bug the DXGI team to consolidate all the features into one header instead needing to import a bunch.

Proposed technical implementation details (optional)

Just read the docs and make improvements as described to boost efficiency of the renderer. Related: https://github.com/microsoft/terminal/issues/6436 and https://github.com/microsoft/terminal/pull/6435, which starts the process.

Originally created by @WSLUser on GitHub (Jun 9, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement Make use of features described in https://docs.microsoft.com/en-us/windows/win32/direct3ddxgi/dxgi-1-3-improvements, https://docs.microsoft.com/en-us/windows/win32/direct3ddxgi/dxgi-1-4-improvements, https://docs.microsoft.com/en-us/windows/win32/direct3ddxgi/dxgi-1-5-improvements, and https://docs.microsoft.com/en-us/windows/win32/direct3ddxgi/dxgi-1-6-improvements. Probably should bug the DXGI team to consolidate all the features into one header instead needing to import a bunch. <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> # Proposed technical implementation details (optional) Just read the docs and make improvements as described to boost efficiency of the renderer. Related: https://github.com/microsoft/terminal/issues/6436 and https://github.com/microsoft/terminal/pull/6435, which starts the process. <!-- A clear and concise description of what you want to happen. -->
claunia added the Issue-QuestionNeeds-Tag-FixResolution-Answered labels 2026-01-31 01:41:51 +00:00
claunia commented 2026-01-31 01:41:53 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 10, 2020):

Hey, thanks for bringing this up! Like the performance discussion, I'd like to make sure we scope this to actual actionable improvements. Right now, we're restricted from taking on too much of a dependency beyond DXGI 1.2, and I'd like to see individual issues filed for things that will individually benefit the Terminal.

I had a look at the release notes for 1.2 - 1.6, and I'm not seeing anything that sticks out to me. We tried to support variable refresh rate displays, and it didn't help #649; @greg904 is introducing the 1.2 dependency and we're fine with that, but nothing else here seems salient.

I'm gonna close this one out as "non-actionable" - it's a big grab bag of APIs to read through and support, and that's not a committable unit of work.

Separate workitems like "switch to RegisterVideoMemoryBudgetChangeNotificationEvent" are more likely to be accepted, with proper justification, than "read this long list and see if any apply."

😄

Also,

Probably should bug the DXGI team to consolidate all the features into one header instead needing to import a bunch.

They're versioned for a reason. Applications must choose to take a dependency on a newer version. That's not gonna change!

@DHowett commented on GitHub (Jun 10, 2020): Hey, thanks for bringing this up! Like the performance discussion, I'd like to make sure we scope this to _actual actionable improvements_. Right now, we're restricted from taking on too much of a dependency beyond DXGI 1.2, and I'd like to see individual issues filed for things that will individually benefit the Terminal. I had a look at the release notes for 1.2 - 1.6, and I'm not seeing anything that sticks out to me. We tried to support variable refresh rate displays, and it didn't help #649; @greg904 is introducing the 1.2 dependency and we're fine with that, but nothing else here seems salient. I'm gonna close this one out as "non-actionable" - it's a big grab bag of APIs to read through and support, and that's not a committable unit of work. Separate workitems like "switch to RegisterVideoMemoryBudgetChangeNotificationEvent" are more likely to be accepted, with proper justification, than "read this long list and see if any apply." :smile: Also, > Probably should bug the DXGI team to consolidate all the features into one header instead needing to import a bunch. They're versioned for a reason. Applications must _choose_ to take a dependency on a newer version. That's not gonna change!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Question Needs-Tag-Fix Resolution-Answered
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#8938
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?