starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Closing the last tab doesn't close the Terminal #898

New Issue
Closed
opened 2026-01-30 22:08:38 +00:00 by claunia · 5 comments
claunia commented 2026-01-30 22:08:38 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (May 9, 2019).

From #460:

Closing the terminal when the last tab is closed is also something we should be doing, but that might be a bit trickier of a PR. I think we're manually suppressing the close action on the last tab currently, but that could be replaced with just closing the app (somehow).

Originally created by @zadjii-msft on GitHub (May 9, 2019). From #460: > Closing the terminal when the last tab is closed is also something we should be doing, but that might be a bit trickier of a PR. I think we're manually suppressing the close action on the last tab currently, but that could be replaced with just closing the app (somehow).
claunia commented 2026-01-30 22:08:39 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (May 9, 2019):

You could disable the tabs ability to close when it is the only tab, so to exit you must click on the close button on the window itself

@mdtauk commented on GitHub (May 9, 2019): You could disable the tabs ability to close when it is the only tab, so to exit you must click on the close button on the window itself
claunia commented 2026-01-30 22:08:39 +00:00
Author
Owner
Copy Link

@tkmikan commented on GitHub (May 10, 2019):

With "alwaysShowTabs": true, the terminal is closed after a middle/wheel click at the last tab, but it takes about 3-5 sec or more.
(nothing happens when clicking the close button of the last tab).

@tkmikan commented on GitHub (May 10, 2019): With `"alwaysShowTabs": true`, the terminal is closed after a middle/wheel click at the last tab, but it takes about 3-5 sec or more. (nothing happens when clicking the close button of the last tab).
claunia commented 2026-01-30 22:08:39 +00:00
Author
Owner
Copy Link

@bef178 commented on GitHub (May 13, 2019):

Do we settle what is the expected behavior?

@bef178 commented on GitHub (May 13, 2019): Do we settle what is the expected behavior?
claunia commented 2026-01-30 22:08:39 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 13, 2019):

@mdtauk that seems like a good and reasonable setting, like preventing accidental closing with Ctrl+W.

@tkmikan I believe the behavior you're seeing is that the terminal actually crashes when you middle click the last tab. I believe that fix is #648, though that just prevents closing the last tab with middle click.

Should closing the last tab with the tab's close button and Ctrl+W be enabled, we should also make sure it's possible to close the last tab with middle-click again.

@zadjii-msft commented on GitHub (May 13, 2019): @mdtauk that seems like a good and reasonable _setting_, like preventing accidental closing with Ctrl+W. @tkmikan I believe the behavior you're seeing is that the terminal actually _crashes_ when you middle click the last tab. I believe that fix is #648, though that just prevents closing the last tab with middle click. Should closing the last tab with the tab's close button and Ctrl+W be enabled, we should also make sure it's possible to close the last tab with middle-click again.
claunia commented 2026-01-30 22:08:40 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 29, 2019):

I believe this is done? Somebody fact-check me?

@DHowett-MSFT commented on GitHub (May 29, 2019): I believe this is done? Somebody fact-check me?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Help Wanted Issue-Bug Product-Terminal Resolution-Fix-Available
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#898
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?