starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

cursor draws behind underline #9015

New Issue
Open
opened 2026-01-31 01:43:52 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 01:43:52 +00:00
Owner
Copy Link

Originally created by @DHowett on GitHub (Jun 14, 2020).

It is particularly noticeable with the emptyBox cursor.

image

Originally created by @DHowett on GitHub (Jun 14, 2020). It is particularly noticeable with the `emptyBox` cursor. ![image](https://user-images.githubusercontent.com/189190/84587141-8b983680-add1-11ea-83a4-6f73c1e141c5.png)
claunia added the Area-RenderingIssue-BugPriority-3In-PRProduct-Terminal labels 2026-01-31 01:43:52 +00:00
claunia commented 2026-01-31 01:43:53 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 15, 2020):

Oh, cause underlines are drawn on top of the text, in a third pass, aren't they ;___;

This is probably a regression from #6337, isn't it.

I suppose I could still do the post-text pass in PaintCursor. I'm tentatively tossing blocking/1.1 on this, feel free to punt.

@zadjii-msft commented on GitHub (Jun 15, 2020): Oh, cause underlines are drawn on top of the text, in a _third_ pass, aren't they ;___; This is probably a regression from #6337, isn't it. I suppose I could still do the post-text pass in `PaintCursor`. I'm tentatively tossing blocking/1.1 on this, feel free to punt.
claunia commented 2026-01-31 01:43:53 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jun 16, 2020):

If you're looking at possibly changing the render-order here, you may want to think about how this would be impacted by underline/decoration color, should we ever choose to support that. Because if the underline color is different from the text color, I think it should technically be rendered below the text. To make things more complicated, strike-though would still have to be rendered above the text.

I'm not particularly keen on that functionality myself, but just thought it worth mentioning here in case it affects how you want to approach this.

@j4james commented on GitHub (Jun 16, 2020): If you're looking at possibly changing the render-order here, you may want to think about how this would be impacted by underline/decoration color, should we ever choose to support that. Because if the underline color is different from the text color, I think it should technically be rendered _below_ the text. To make things more complicated, strike-though would still have to be rendered _above_ the text. I'm not particularly keen on that functionality myself, but just thought it worth mentioning here in case it affects how you want to approach this.
claunia commented 2026-01-31 01:43:54 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Jun 19, 2020):

Here's another thing to throw in there. Technically we have underline information provided to us by DirectWrite that we're currently ignoring in favor of just drawing a line at the bottom of the box. The DWrite underline information compensates for the stylistic properties of the font. We may want to be using that instead.

@miniksa commented on GitHub (Jun 19, 2020): Here's another thing to throw in there. Technically we have underline information provided to us by DirectWrite that we're currently ignoring in favor of just drawing a line at the bottom of the box. The DWrite underline information compensates for the stylistic properties of the font. We may want to be using that instead.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering In-PR Issue-Bug Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9015
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?