Find with color highlights and find with regrex match support #9032

Closed
opened 2026-01-31 01:44:16 +00:00 by claunia · 2 comments
Owner

Originally created by @lpstudy on GitHub (Jun 15, 2020).

Description of the new feature/enhancement

  1. Currently, to find the text in terminal, it only highlights only one that matches. Do we consider to highlights all the matched texts?

  2. Currently find do not support regrex expression, do we consider to support it?

  3. Bug report
    Current find dialog in one panel does not disappear even I change the focus to other panels. This may lead to ESC does not work for closing find dialog.

Proposed technical implementation details (optional)

image

Originally created by @lpstudy on GitHub (Jun 15, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement 1. Currently, to find the text in terminal, it only highlights only one that matches. Do we consider to highlights all the matched texts? 2. Currently `find` do not support regrex expression, do we consider to support it? 3. Bug report Current `find` dialog in one panel does not disappear even I change the focus to other panels. This may lead to ESC does not work for closing `find ` dialog. # Proposed technical implementation details (optional) ![image](https://user-images.githubusercontent.com/2081195/84621479-3d884d80-af0d-11ea-82a8-0918bc6ce1fe.png)
claunia added the Issue-FeatureResolution-Duplicate labels 2026-01-31 01:44:17 +00:00
Author
Owner

@zadjii-msft commented on GitHub (Jun 15, 2020):

Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #3920 for more discussion.

/dup #3920

@zadjii-msft commented on GitHub (Jun 15, 2020): Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #3920 for more discussion. /dup #3920
Author
Owner

@ghost commented on GitHub (Jun 15, 2020):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Jun 15, 2020): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9032