starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

EndPaint outside of lock for DxEngine #9045

New Issue
Closed
opened 2026-01-31 01:44:35 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 01:44:35 +00:00
Owner
Copy Link

Originally created by @miniksa on GitHub (Jun 15, 2020).

The EndPaint command will naturally send all the queued drawing commands onto the underlying rendering target/bitmap/surface. Since all the data has already been captured and queued, there's no real sense in holding the lock on the I/O thread while the draw commands are performed. So this should probably move into the Present phase. But it will have to be reconciled with the invalid rectangle/scroll things that are usually done at EndPaint time.

Originally created by @miniksa on GitHub (Jun 15, 2020). The EndPaint command will naturally send all the queued drawing commands onto the underlying rendering target/bitmap/surface. Since all the data has already been captured and queued, there's no real sense in holding the lock on the I/O thread while the draw commands are performed. So this should probably move into the `Present` phase. But it will have to be reconciled with the invalid rectangle/scroll things that are usually done at `EndPaint` time.
claunia commented 2026-01-31 01:44:36 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 16, 2022):

🤔

Why did we never do this? This might have just sorted out like, a bunch of the miscellaneous deadlocks we're tracking (ala #12607)

@zadjii-msft commented on GitHub (Aug 16, 2022): 🤔 Why did we never do this? This might have just sorted out like, a bunch of the miscellaneous deadlocks we're tracking (ala #12607)
claunia commented 2026-01-31 01:44:36 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 16, 2022):

@lhecker tell me why this wouldn't work:
https://github.com/microsoft/terminal/compare/dev/migrie/b/6523-endpaint-outside-lock?w=1

@zadjii-msft commented on GitHub (Aug 16, 2022): @lhecker tell me why this wouldn't work: https://github.com/microsoft/terminal/compare/dev/migrie/b/6523-endpaint-outside-lock?w=1
claunia commented 2026-01-31 01:44:37 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Aug 16, 2022):

D2D has an internal batch size limit for draw commands, so given enough text on the screen, it'll try to call D3D functions potentially many times before EndDraw is even called.
That said, it can't hurt to merge this. Reduces the chance for our issue even further...

@lhecker commented on GitHub (Aug 16, 2022): D2D has an internal batch size limit for draw commands, so given enough text on the screen, it'll try to call D3D functions potentially many times before `EndDraw` is even called. That said, it can't hurt to merge this. Reduces the chance for our issue even further...
claunia commented 2026-01-31 01:44:37 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 22, 2022):

Note to future self: this seemingly did not noticeably improve Terminal perf. Maybe it helps conhost perf, but I didn't have the cycles to further sanity check if this wouldn't just explode (esp. over RDP).

I'm closing this tab out now, see y'all in two more years when I reopen this 😜

@zadjii-msft commented on GitHub (Aug 22, 2022): Note to future self: this seemingly did not noticeably improve Terminal perf. Maybe it helps conhost perf, but I didn't have the cycles to further sanity check if this wouldn't just explode (esp. over RDP). I'm closing this tab out now, see y'all in two more years when I reopen this 😜
claunia commented 2026-01-31 01:44:37 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Oct 10, 2024):

Oh, we do this now in AtlasEngine!

@lhecker commented on GitHub (Oct 10, 2024): Oh, we do this now in AtlasEngine!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Performance Area-Rendering Issue-Task Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9045
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?