Terminal window has white border #9185

@j4james commented on GitHub (Jun 21, 2020):

The border color is affected by a number of settings. Typically it uses the accent color, in which case it could be white (or at least a light gray) if that's the accent color you chose. But I suspect in this case you've probably just turned off Title bars and window borders option, and that's what's responsible for the white border in the Light mode.

I think that might be a bug, but it's different from the original white border issue.

@j4james commented on GitHub (Jun 21, 2020): The border color is affected by a number of settings. Typically it uses the accent color, in which case it could be white (or at least a light gray) if that's the accent color you chose. But I suspect in this case you've probably just turned off _Title bars and window borders_ option, and that's what's responsible for the white border in the _Light_ mode. I think that might be a bug, but it's different from the original white border issue.

claunia commented

@michalhudecek commented on GitHub (Jun 21, 2020):

Here is my setting:

@michalhudecek commented on GitHub (Jun 21, 2020): Here is my setting: ![image](https://user-images.githubusercontent.com/1215304/85223290-43c17280-b3c2-11ea-93e6-631fc3c0eb36.png)

claunia commented

d1a074e315/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp (L680-L696)

@beviu commented on GitHub (Jun 21, 2020):

This is because the Windows Terminal is a Win32 app with a custom title bar and Win32 apps with custom title bars have white borders by default:

Note that when I made the PR #3394 which added a custom title bar by removing the standard Win32 title bar, I did not change the default behavior of having that white border. Because the Windows Terminal wants to look like a UWP app, maybe this should be faked as well, like the title bar, by always making the border dark?

We could do this by chaging _OnNcCreate on NonClientIslandWindow to unconditionally set the black border, something like this:

I can make a PR that does this if the Windows Terminal team wants the black border.

@beviu commented on GitHub (Jun 21, 2020): This is because the Windows Terminal is a Win32 app with a custom title bar and Win32 apps with custom title bars have white borders by default: ![image](https://user-images.githubusercontent.com/56923875/85224589-a9662c80-b3cb-11ea-960d-d4b29e9aa430.png) ![image](https://user-images.githubusercontent.com/56923875/85224764-debf4a00-b3cc-11ea-92bc-9e1e5140378b.png) Note that when I made the PR #3394 which added a custom title bar by removing the standard Win32 title bar, I did not change the default behavior of having that white border. Because the Windows Terminal wants to look like a UWP app, maybe this should be faked as well, like the title bar, by always making the border dark? We could do this by chaging _OnNcCreate on NonClientIslandWindow to unconditionally set the black border, something like this: https://github.com/microsoft/terminal/blob/d1a074e3159efb98128eac0ad3e8aff390334f68/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp#L680-L696 I can make a PR that does this if the Windows Terminal team wants the black border.

claunia commented

@j4james commented on GitHub (Jun 21, 2020):

I don't think it's meant to be black exactly. I suspect it might be version specific, but the border colors I'm seeing on most UWP apps is different on the top and sides, and it's actually a level of transparency, so what you see will depend on the background. I'm talking specifically about the Light mode, with the Title bars and window borders option disabled.

I'm on version 10.0.18362.836. The OP didn't fill in the bug template, so I don't know what version he is using, but his screenshots look different to what I'm seeing.

@j4james commented on GitHub (Jun 21, 2020): I don't think it's meant to be black exactly. I suspect it might be version specific, but the border colors I'm seeing on most UWP apps is different on the top and sides, and it's actually a level of transparency, so what you see will depend on the background. I'm talking specifically about the _Light_ mode, with the _Title bars and window borders_ option disabled. I'm on version 10.0.18362.836. The OP didn't fill in the bug template, so I don't know what version he is using, but his screenshots look different to what I'm seeing.

claunia commented

@michalhudecek commented on GitHub (Jun 21, 2020):

I am using Terminal 1.0.1401.0 (stable) and 1.1.1671.0 (preview). The issue is the same in both.

Here is my Windows version:

@michalhudecek commented on GitHub (Jun 21, 2020): I am using Terminal 1.0.1401.0 (stable) and 1.1.1671.0 (preview). The issue is the same in both. Here is my Windows version: ![image](https://user-images.githubusercontent.com/1215304/85225420-69a24380-b3d1-11ea-9da6-98eff219216d.png)

claunia commented

@beviu commented on GitHub (Jun 21, 2020):

Yes sorry I meant "dark" instead of "black".

j4james, I don't know if you're talking about this when you say that the top and side colors are not the same, but if you are, I think it's a bug because it disappears after a restart:

(see how the top border is dark but other borders are light)

I am on 10.0.18362.900.

@beviu commented on GitHub (Jun 21, 2020): Yes sorry I meant "dark" instead of "black". j4james, I don't know if you're talking about this when you say that the top and side colors are not the same, but if you are, I think it's a bug because it disappears after a restart: ![image](https://user-images.githubusercontent.com/56923875/85225458-c1d94580-b3d1-11ea-8f49-4c0ef131ef0a.png) (see how the top border is dark but other borders are light) I am on 10.0.18362.900.

claunia commented

@j4james commented on GitHub (Jun 21, 2020):

j4james, I don't know if you're talking about this when you say that the top and side colors are not the same, but if you are, I think it's a bug because it disappears after a restart:

That makes sense. That's exactly what I'm seeing. I thought it might be a bug.

@j4james commented on GitHub (Jun 21, 2020): > j4james, I don't know if you're talking about this when you say that the top and side colors are not the same, but if you are, I think it's a bug because it disappears after a restart: That makes sense. That's exactly what I'm seeing. I thought it might be a bug.

claunia commented

@beviu commented on GitHub (Jun 21, 2020):

This is unrelated to the OP but I reported this bug (with the UWP apps, not with the Windows Terminal, again not related to the OP) in the Feedback Hub: https://aka.ms/AA6pqh3.

@beviu commented on GitHub (Jun 21, 2020): This is unrelated to the OP but I reported this bug (with the UWP apps, not with the Windows Terminal, again not related to the OP) in the Feedback Hub: https://aka.ms/AA6pqh3.

claunia commented

@DHowett commented on GitHub (Jun 21, 2020):

Unfortunately, there isn’t a standard here. If somebody wants to remove the theme check around “TrySetDarkMode” in “NonClientIslandWindow.cpp”, I would absolutely accept that pull request.
Thanks for digging up all these counterexamples, @michalhudecek!

@DHowett commented on GitHub (Jun 21, 2020): Unfortunately, there isn’t a standard here. If somebody wants to remove the theme check around “TrySetDarkMode” in “NonClientIslandWindow.cpp”, I would absolutely accept that pull request. Thanks for digging up all these counterexamples, @michalhudecek!

claunia commented

@DHowett commented on GitHub (Jun 21, 2020):

(When I say “there isn’t a standard here,” I mean “terminal even has to use a private API to get its window borders to look like other UWP applications.” It drives me crazy!)

@DHowett commented on GitHub (Jun 21, 2020): (When I say “there isn’t a standard here,” I mean “terminal even has to use a _private API_ to get its window borders to look like other UWP applications.” It drives me crazy!)

claunia commented

@michalhudecek commented on GitHub (Jun 22, 2020):

There is no standard even "on paper"? I mean something like a codified design system: https://atlassian.design/guidelines/product/overview or https://material.io/components

@michalhudecek commented on GitHub (Jun 22, 2020): There is no standard even "on paper"? I mean something like a codified design system: https://atlassian.design/guidelines/product/overview or https://material.io/components

claunia commented

@michalhudecek commented on GitHub (Jun 22, 2020):

That was quick! Good job :)

@michalhudecek commented on GitHub (Jun 22, 2020): That was quick! Good job :)

claunia commented

@ghost commented on GitHub (Jul 22, 2020):

:tada:This issue was addressed in #6624, which has now been successfully released as Windows Terminal Preview v1.2.2022.0.🎉

Handy links:

@ghost commented on GitHub (Jul 22, 2020): :tada:This issue was addressed in #6624, which has now been successfully released as `Windows Terminal Preview v1.2.2022.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.2.2022.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)

claunia commented

@harristom commented on GitHub (Jan 27, 2023):

This problem is back in v1.17, I guess due to the recent changes around theming. The grey border is there to start with until you switch to another window and back (presumably it's part of the dark theme and doesn't get repainted until switching). Once you switch back it is white and will stay so even after closing/re-opening.

Steps to reproduce:

Delete settings.json and state.json
Open Terminal and switch to light theme
Border is grey
Alt tab to another window then back again
Border is now forever white

@harristom commented on GitHub (Jan 27, 2023): This problem is back in v1.17, I guess due to the recent changes around theming. The grey border is there to start with until you switch to another window and back (presumably it's part of the dark theme and doesn't get repainted until switching). Once you switch back it is white and will stay so even after closing/re-opening. Steps to reproduce: * Delete settings.json and state.json * Open Terminal and switch to light theme * Border is grey * Alt tab to another window then back again * Border is now forever white

claunia commented