Add a "remember my decision" checkbox to our confirmation dialogs #9210

Open
opened 2026-01-31 01:48:44 +00:00 by claunia · 5 comments
Owner

Originally created by @Chips1234 on GitHub (Jun 23, 2020).

Description of the new feature/enhancement

Apart from the setting, it will be easier to have a checkbox at the bottom of the CloseAll dialog with the option "Don't ask again" (it will work alongside settings JSON and later GUI)

Proposed technical implementation details (optional)

Checkbox for dialog

Originally created by @Chips1234 on GitHub (Jun 23, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement Apart from the setting, it will be easier to have a checkbox at the bottom of the `CloseAll` dialog with the option "Don't ask again" (it will work alongside settings JSON and later GUI) <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> # Proposed technical implementation details (optional) <!-- A clear and concise description of what you want to happen. --> ![Checkbox for dialog](https://user-images.githubusercontent.com/47545798/85361898-f92f1b80-b4d1-11ea-93b8-1b21424d5eab.jpg)
Author
Owner

@DHowett commented on GitHub (Jun 25, 2020):

I've got some plans here -- I proposed an alternate settings storage location for runtime-generated settings like this that wouldn't show up in the user's JSON file.

Here's a diagram I drew up a couple months ago. It depicts the behavior of different configuration values for confirmCloseAllTabs:

image

@DHowett commented on GitHub (Jun 25, 2020): I've got some plans here -- I proposed an alternate settings storage location for runtime-generated settings like this that wouldn't show up in the user's JSON file. Here's a diagram I drew up a couple months ago. It depicts the behavior of different configuration values for `confirmCloseAllTabs`: ![image](https://user-images.githubusercontent.com/189190/85779166-2ea55600-b6d8-11ea-82a1-88b1da4fb604.png)
Author
Owner

@Chips1234 commented on GitHub (Jun 25, 2020):

Ok.

@Chips1234 commented on GitHub (Jun 25, 2020): Ok.
Author
Owner

@Chips1234 commented on GitHub (Jun 25, 2020):

I would like to work on this.

@Chips1234 commented on GitHub (Jun 25, 2020): I would like to work on this.
Author
Owner

@DHowett commented on GitHub (Jun 25, 2020):

It might be better if you hold off on this one. We need to formalize the place where we are going to store "local application state" without writing it back to the user's settings file.

You're welcome to start work on it, but I can't promise we won't end up working in the same area.

@DHowett commented on GitHub (Jun 25, 2020): It might be better if you hold off on this one. We need to formalize the place where we are going to store "local application state" without writing it back to the user's settings file. You're welcome to start work on it, but I can't promise we won't end up working in the same area.
Author
Owner

@Chips1234 commented on GitHub (Jun 25, 2020):

Ok

@Chips1234 commented on GitHub (Jun 25, 2020): Ok
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9210