starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Command palette search results should bold the matching text #9222

New Issue
Closed
opened 2026-01-31 01:49:00 +00:00 by claunia · 13 comments
claunia commented 2026-01-31 01:49:00 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jun 23, 2020).

Originally assigned to: @DHowett on GitHub.

Omitted from initial implementation in #6635.

I'm really unsure if this is possible in XAML, but hey, I think it would be important.

Originally created by @zadjii-msft on GitHub (Jun 23, 2020). Originally assigned to: @DHowett on GitHub. Omitted from initial implementation in #6635. I'm _really_ unsure if this is possible in XAML, but hey, I think it would be important.
claunia commented 2026-01-31 01:49:02 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 23, 2020):

If we're using TextBlocks we can just fill them with Runs generated at runtime 😄

@DHowett commented on GitHub (Jun 23, 2020): If we're using TextBlocks we can just fill them with `Run`s generated at runtime :smile:
claunia commented 2026-01-31 01:49:02 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 23, 2020):

image

<TextBlock FontFamily="Segoe UI" FontSize="32">
  <Run FontWeight="Bold">N</Run><Run>ew</Run> <Run FontWeight="Bold">T</Run><Run>ab</Run>
</TextBlock>
@DHowett commented on GitHub (Jun 23, 2020): ![image](https://user-images.githubusercontent.com/189190/85454422-c4fb3f80-b551-11ea-9eb9-a71dc5d84cab.png) ```xml <TextBlock FontFamily="Segoe UI" FontSize="32"> <Run FontWeight="Bold">N</Run><Run>ew</Run> <Run FontWeight="Bold">T</Run><Run>ab</Run> </TextBlock> ```
claunia commented 2026-01-31 01:49:02 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 23, 2020):

Yes, that's easy enough, but then we need to hook up a lot more XAML - the Palette knows which characters need to be highlighted, so it would need to set that on each of the commands in the match list, then each of those guys would need to return a Run instead of just a string.

It's not impossible, but it's a lot more XAML binding than anything I've done

@zadjii-msft commented on GitHub (Jun 23, 2020): Yes, that's easy enough, but then we need to hook up a lot more XAML - the Palette knows which characters need to be highlighted, so it would need to set that on each of the commands in the match list, then each of those guys would need to return a `Run` instead of just a `string`. It's not impossible, but it's a lot more XAML binding than anything I've done
claunia commented 2026-01-31 01:49:02 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 25, 2020):

Mind if I bump this one into 2.0? If you don't get to it, I'd like to. 😄

@DHowett commented on GitHub (Jun 25, 2020): Mind if I bump this one into 2.0? If you don't get to it, I'd like to. :smile:
claunia commented 2026-01-31 01:49:02 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 25, 2020):

Sure thing, it's done

@zadjii-msft commented on GitHub (Jun 25, 2020): Sure thing, it's done
claunia commented 2026-01-31 01:49:03 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 25, 2020):

Thanks!

@DHowett commented on GitHub (Jun 25, 2020): Thanks!
claunia commented 2026-01-31 01:49:03 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Oct 19, 2020):

@DHowett, @zadjii-msft - so this was planned to be a nice warmup exercise for Saturday morning. This was a bad decision 😄.. aka how to ruin a half of your weekend..

  • Defining a model that instead of a name stores a vector of matched and not matched segments - easy
  • Now let's bind it to the runs - the WinRT Textblock::Inlines are not bindable (ouch)
  • No problem, let's register an attached property and create runs in code behind - coded everything (even with nice converter), XAML complains on the binding. Reading WinRT docs (ouch 2):
    image
  • Ha, good luck defining imperatively dynamic context without tons of code-behind. No problem, I will simply create a custom control. WinRT TextBlock is sealed (ouch 3)
  • Found myself writing a User Control 😞

On a positive side, it work.. on a negative I need to do a lot of cleanups before this worth a PR
SearchHighlightNoMouse

@Don-Vito commented on GitHub (Oct 19, 2020): @DHowett, @zadjii-msft - so this was planned to be a nice warmup exercise for Saturday morning. This was a bad decision 😄.. aka how to ruin a half of your weekend.. * Defining a model that instead of a name stores a vector of matched and not matched segments - easy * Now let's bind it to the runs - the WinRT Textblock::Inlines are not bindable (ouch) * No problem, let's register an attached property and create runs in code behind - coded everything (even with nice converter), XAML complains on the binding. Reading WinRT docs (ouch 2): ![image](https://user-images.githubusercontent.com/4639110/96410228-3f318d00-11ef-11eb-9863-b0929eb5be8f.png) * Ha, good luck defining imperatively dynamic context without tons of code-behind. No problem, I will simply create a custom control. WinRT TextBlock is sealed (ouch 3) * Found myself writing a User Control 😞 On a positive side, it work.. on a negative I need to do a lot of cleanups before this worth a PR ![SearchHighlightNoMouse](https://user-images.githubusercontent.com/4639110/96410760-1362d700-11f0-11eb-9736-bdf36a91e115.gif)
claunia commented 2026-01-31 01:49:03 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 19, 2020):

Hey! I worked on this for a bit too, actually, during a hackathon! I ended up binding the content of a Border to a property that produces a TextBlock itself with its own inline runs constructed at runtime.

I’ve been meaning to put it up for review, but I can hold off so we don’t have conflicting changes.

Thanks for working on this!

@DHowett commented on GitHub (Oct 19, 2020): Hey! I worked on this for a bit too, actually, during a hackathon! I ended up binding the content of a Border to a property that produces a TextBlock itself with its own inline runs constructed at runtime. I’ve been meaning to put it up for review, but I can hold off so we don’t have conflicting changes. Thanks for working on this!
claunia commented 2026-01-31 01:49:04 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Oct 19, 2020):

@DHowett - I kinda enjoyed 😄 . In any case please let me know if you believe it is something I should continue to productize - since if you have a working solution than probably we can skip mine.

BTW, I am not complaining and not regretting anything, but consider removing "help wanted" - I've seen some additional items, that were marked as "help wanted" but were at different stages of implementation.

@Don-Vito commented on GitHub (Oct 19, 2020): @DHowett - I kinda enjoyed 😄 . In any case please let me know if you believe it is something I should continue to productize - since if you have a working solution than probably we can skip mine. BTW, I am not complaining and not regretting anything, but consider removing "help wanted" - I've seen some additional items, that were marked as "help wanted" but were at different stages of implementation.
claunia commented 2026-01-31 01:49:04 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 19, 2020):

That’s a very good call (about not keeping the help tag on things we start working on). I expect your solution is better than mine—after all, mine was little more than a hack—so I’d love to see you finish it. A label that can highlight specific ranges is a very useful general-purpose UserControl.

@DHowett commented on GitHub (Oct 19, 2020): That’s a very good call (about not keeping the help tag on things we start working on). I expect your solution is better than mine—after all, mine was little more than a hack—so I’d love to see you finish it. A label that can highlight specific ranges is a very useful general-purpose UserControl.
claunia commented 2026-01-31 01:49:04 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Oct 19, 2020):

@DHowett - from what I've learnt observing this community is that your "hacks" are much better than the best contribution I can do! 😄 In any case will continue to productize it during this week (it is in a bad shape, as I didn't work with neither C++, nor XAML in the last 8 years).

@Don-Vito commented on GitHub (Oct 19, 2020): @DHowett - from what I've learnt observing this community is that your "hacks" are much better than the best contribution I can do! :smile: In any case will continue to productize it during this week (it is in a bad shape, as I didn't work with neither C++, nor XAML in the last 8 years).
claunia commented 2026-01-31 01:49:04 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 19, 2020):

@Don-Vito I love it! Looking forward to the PR ☺️

@zadjii-msft commented on GitHub (Oct 19, 2020): @Don-Vito I love it! Looking forward to the PR ☺️
claunia commented 2026-01-31 01:49:04 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 11, 2020):

:tada:This issue was addressed in #7977, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.🎉

Handy links:

@ghost commented on GitHub (Nov 11, 2020): :tada:This issue was addressed in #7977, which has now been successfully released as `Windows Terminal Preview v1.5.3142.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.5.3142.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Task Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9222
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?