starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Far Manager crashes Terminal after commit e7d3dc5d #9252

New Issue
Closed
opened 2026-01-31 01:49:46 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 01:49:46 +00:00
Owner
Copy Link

Originally created by @igorkuzuro on GitHub (Jun 24, 2020).

Environment

Windows build number: Microsoft Windows NT 10.0.20150.0
Windows Terminal Dev build from sources
Far Manager v3.0 build 5625 x64 (2020-06-24) https://farmanager.com

Steps to reproduce

Start new tab for Far Manager or just start far.exe in existing tab from command prompt

Expected behavior

Expected working Far Manger

Actual behavior

Terminal crashed. In debug configuration raised exception in "vector" include file in
function void _Verify_offset(const difference_type _Off) const at line 113
"cannot seek vector iterator after end"

Call stack:
...
problem at
src\renderer\dx\CustomTextLayout.cpp at line 867:
const auto postOriginX = std::accumulate(_glyphAdvances.begin() + run.glyphStart,
_glyphAdvances.begin() + run.glyphStart + run.glyphCount,
mutableOrigin.x);

_glyphAdvances.size(): 0x000000000000001f
run.glyphStart: 0x00000001
run.glyphCount: 0x0000ffff

Same problem in wsl2 (Ubuntu or CentOS not matter) with Midnight Commander... start ok (in user's home directory) but Terminal crashes when trying cd to /home directory with mouse double click under .. or with cd .. in command line.

Originally created by @igorkuzuro on GitHub (Jun 24, 2020). # Environment Windows build number: Microsoft Windows NT 10.0.20150.0 Windows Terminal Dev build from sources Far Manager v3.0 build 5625 x64 (2020-06-24) https://farmanager.com # Steps to reproduce Start new tab for Far Manager or just start far.exe in existing tab from command prompt # Expected behavior Expected working Far Manger # Actual behavior Terminal crashed. In debug configuration raised exception in "vector" include file in function void _Verify_offset(const difference_type _Off) const at line 113 **"cannot seek vector iterator after end"** Call stack: ... problem at src\renderer\dx\CustomTextLayout.cpp at line 867: const auto postOriginX = std::accumulate(_glyphAdvances.begin() + run.glyphStart, _glyphAdvances.begin() + run.glyphStart + run.glyphCount, mutableOrigin.x); _glyphAdvances.size(): 0x000000000000001f run.glyphStart: 0x00000001 run.glyphCount: 0x0000ffff Same problem in wsl2 (Ubuntu or CentOS not matter) with Midnight Commander... start ok (in user's home directory) but Terminal crashes when trying cd to /home directory with mouse double click under .. or with cd .. in command line.
claunia added the Needs-TriageResolution-Fix-CommittedNeeds-Tag-Fix labels 2026-01-31 01:49:46 +00:00
claunia commented 2026-01-31 01:49:47 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 24, 2020):

I think this shares a root cause with #6488. I'm preparing a revert, as I can repro this crash.

@DHowett commented on GitHub (Jun 24, 2020): I think this shares a root cause with #6488. I'm preparing a revert, as I can repro this crash.
claunia commented 2026-01-31 01:49:47 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 24, 2020):

You know, actually, I misread this totally. Thanks for doing the digging.

/cc @miniksa

@DHowett commented on GitHub (Jun 24, 2020): You know, actually, I misread this totally. Thanks for doing the digging. /cc @miniksa
claunia commented 2026-01-31 01:49:48 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Jun 24, 2020):

Nnnnnnnnnnnnnn ok looking.

@miniksa commented on GitHub (Jun 24, 2020): Nnnnnnnnnnnnnn ok looking.
claunia commented 2026-01-31 01:49:48 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 24, 2020):

So, this crash stops reproducing when #6206 is reverted -- it's probably still lurking, but I'm going to roll this bug and #6488 into another workitem, "reintroduce simple text detection but without the crash or the other problem" :P

@DHowett commented on GitHub (Jun 24, 2020): So, this crash stops reproducing when #6206 is reverted -- it's probably still lurking, but I'm going to roll this bug and #6488 into another workitem, "reintroduce simple text detection but without the crash or the other problem" :P
claunia commented 2026-01-31 01:49:48 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Jun 24, 2020):

When looking in the runs, one of the runs is 0xfffe glyphs long which is why there's an index out of range.

Removing the _CorrectBoxDrawing step prevents the crash. So it must be the one responsible for the 0xfffe glyph length calculation. It's probable that it was banking of having some data from one of the analysis/shaping/correction steps that is being skipped when a "simple" run is detected.

I'll dig deeper.

This also correlates well with the reported issue that there is some aliasing problems with glyphs when box drawing is involved (combined with the "simple" run detection.)

@miniksa commented on GitHub (Jun 24, 2020): When looking in the runs, one of the runs is 0xfffe glyphs long which is why there's an index out of range. Removing the `_CorrectBoxDrawing` step prevents the crash. So it must be the one responsible for the 0xfffe glyph length calculation. It's probable that it was banking of having some data from one of the analysis/shaping/correction steps that is being skipped when a "simple" run is detected. I'll dig deeper. This also correlates well with the reported issue that there is some aliasing problems with glyphs when box drawing is involved (combined with the "simple" run detection.)
claunia commented 2026-01-31 01:49:48 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jun 30, 2020):

:tada:This issue was addressed in #6665, which has now been successfully released as Windows Terminal Preview v1.1.1812.0.🎉

Handy links:

@ghost commented on GitHub (Jun 30, 2020): :tada:This issue was addressed in #6665, which has now been successfully released as `Windows Terminal Preview v1.1.1812.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.1.1812.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Needs-Tag-Fix Needs-Triage Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9252
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?