starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Reintroduce simple text analysis escape without crash or box drawing issue #9258

New Issue
Closed
opened 2026-01-31 01:49:56 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 01:49:56 +00:00
Owner
Copy Link

Originally created by @DHowett on GitHub (Jun 24, 2020).

Originally assigned to: @miniksa on GitHub.

Notes from bugs:

From #6488

When I run this in PowerShell (7),

"`e[30;47m`u{2500} What `u{2500}`e[m"

the text comes out without antialiasing. It looks like it's being drawn with FillGeometry just like a box drawing glyph.

image

If I flip the colors, it comes out antialiased.

image

Okay, this is because we're not populating _glyphClusters when text is "simple". When we go to split the run later (we split runs for things other than text analysis!), we try to remap the glyph clusters around the split.

Inevitably, we end up falling into DrawGlyphRun with run.glyphCount = 0 because _SplitCurrentRun stomped the glyphCount because there was no glyph cluster mapping.

Somehow magically we end up doing a "get raw geometry, draw" for the entire string which very handily hides the glyph clustering bug!

This fix works but I do not believe it is correct:

diff --git a/src/renderer/dx/CustomTextLayout.cpp b/src/renderer/dx/CustomTextLayout.cpp
index d19d2d0c3..395a58224 100644
--- a/src/renderer/dx/CustomTextLayout.cpp
+++ b/src/renderer/dx/CustomTextLayout.cpp
@@ -336,6 +336,7 @@ CustomTextLayout::CustomTextLayout(gsl::not_null<IDWriteFactory1*> const factory
             for (size_t i = glyphStart; i < _glyphAdvances.size(); i++)
             {
                 _glyphAdvances.at(i) = (float)_glyphDesignUnitAdvances.at(i) / designUnitsPerEm * _format->GetFontSize() * run.fontScale;
+                _glyphClusters.at(i) = static_cast<UINT16>(i);
             }

             run.glyphCount = textLength;

I'm worried about that "magical" rendering fallthrough. With this fix, are we striking the text twice -- once as a geometry and once as a glyph run?

(I commented out the glyph run drawing, and I think the answer is no.)

From #6664

Terminal crashed. In debug configuration raised exception in "vector" include file in
function void _Verify_offset(const difference_type _Off) const at line 113
"cannot seek vector iterator after end"

Call stack:
...
problem at
src\renderer\dx\CustomTextLayout.cpp at line 867:
const auto postOriginX = std::accumulate(_glyphAdvances.begin() + run.glyphStart,
_glyphAdvances.begin() + run.glyphStart + run.glyphCount,
mutableOrigin.x);

_glyphAdvances.size(): 0x000000000000001f
run.glyphStart: 0x00000001
run.glyphCount: 0x0000ffff

Same problem in wsl2 (Ubuntu or CentOS not matter) with Midnight Commander... start ok (in user's home directory) but Terminal crashes when trying cd to /home directory with mouse double click under .. or with cd .. in command line.
@igorkuzuro

Originally created by @DHowett on GitHub (Jun 24, 2020). Originally assigned to: @miniksa on GitHub. Notes from bugs: From #6488 > When I run this in PowerShell (7), > > ``` > "`e[30;47m`u{2500} What `u{2500}`e[m" > ``` > > the text comes out without antialiasing. It looks like it's being drawn with FillGeometry just like a box drawing glyph. > > ![image](https://user-images.githubusercontent.com/189190/84561566-4e18a800-ad02-11ea-89b8-fe4cc58127bb.png) > > If I flip the colors, it comes out antialiased. > > ![image](https://user-images.githubusercontent.com/189190/84561569-58d33d00-ad02-11ea-83c0-56b763950ae4.png) > Okay, this is because we're not populating `_glyphClusters` when text is "simple". When we go to split the run later (**we split runs for things other than text analysis!**), we try to remap the glyph clusters around the split. > > Inevitably, we end up falling into DrawGlyphRun with `run.glyphCount` = 0 because `_SplitCurrentRun` stomped the glyphCount because there was no glyph cluster mapping. > > Somehow _magically_ we end up doing a "get raw geometry, draw" for the entire string which very handily hides the glyph clustering bug! > > This fix _works_ but I do not believe it is correct: > > ```diff > diff --git a/src/renderer/dx/CustomTextLayout.cpp b/src/renderer/dx/CustomTextLayout.cpp > index d19d2d0c3..395a58224 100644 > --- a/src/renderer/dx/CustomTextLayout.cpp > +++ b/src/renderer/dx/CustomTextLayout.cpp > @@ -336,6 +336,7 @@ CustomTextLayout::CustomTextLayout(gsl::not_null<IDWriteFactory1*> const factory > for (size_t i = glyphStart; i < _glyphAdvances.size(); i++) > { > _glyphAdvances.at(i) = (float)_glyphDesignUnitAdvances.at(i) / designUnitsPerEm * _format->GetFontSize() * run.fontScale; > + _glyphClusters.at(i) = static_cast<UINT16>(i); > } > > run.glyphCount = textLength; > ``` > > I'm worried about that "magical" rendering fallthrough. With this fix, are we striking the text twice -- once as a geometry and once as a glyph run? > > (I commented out the glyph run drawing, and I think the answer is _no_.) From #6664 > Terminal crashed. In debug configuration raised exception in "vector" include file in > function void _Verify_offset(const difference_type _Off) const at line 113 > **"cannot seek vector iterator after end"** > > Call stack: > ... > problem at > src\renderer\dx\CustomTextLayout.cpp at line 867: > const auto postOriginX = std::accumulate(_glyphAdvances.begin() + run.glyphStart, > _glyphAdvances.begin() + run.glyphStart + run.glyphCount, > mutableOrigin.x); > > _glyphAdvances.size(): 0x000000000000001f > run.glyphStart: 0x00000001 > run.glyphCount: 0x0000ffff > > Same problem in wsl2 (Ubuntu or CentOS not matter) with Midnight Commander... start ok (in user's home directory) but Terminal crashes when trying cd to /home directory with mouse double click under .. or with cd .. in command line. > @igorkuzuro
claunia commented 2026-01-31 01:49:57 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 24, 2020):

Reverted in #6665.

@DHowett commented on GitHub (Jun 24, 2020): Reverted in #6665.
claunia commented 2026-01-31 01:49:58 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 24, 2020):

/cc @skyline75489

Michael's offered to bring this back, so there's no direct action required from you right now. Make sure you're on the review! 😄

@DHowett commented on GitHub (Jun 24, 2020): /cc @skyline75489 Michael's offered to bring this back, so there's no direct action required from you right now. Make sure you're on the review! :smile:
claunia commented 2026-01-31 01:49:58 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 22, 2020):

:tada:This issue was addressed in #6695, which has now been successfully released as Windows Terminal Preview v1.2.2022.0.🎉

Handy links:

@ghost commented on GitHub (Jul 22, 2020): :tada:This issue was addressed in #6695, which has now been successfully released as `Windows Terminal Preview v1.2.2022.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.2.2022.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Issue-Bug Priority-1 Product-Terminal Resolution-Fix-Committed Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9258
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?