Megathread: Sometimes, focus moves weirdly #9273

Closed
opened 2026-01-31 01:50:20 +00:00 by claunia · 2 comments
Owner

Originally created by @zadjii-msft on GitHub (Jun 25, 2020).

I'm just making a megathread for all the issues we've got so far, because there's a bunch, and I'm getting the feeling there needs to be some other comprehensive solution.

  • Clicking the current tab to raise the window should focus the text area #3609
  • ESC from the Tab ContextMenu should return focus to the Terminal #5750
  • Launching "Find" from Command Palette doesn't focus the search box #6662
    • Unsure when exactly this was fixed
  • Focus bug 1
    • open command palette
    • press shift+tab
    • your focus is now in the underlying terminal
      • As of 1.7, now the focus is gone from the world?
        • As of at least 1.9, this takes focus to the command list.
  • Focus bug 2
    • open command palette
    • type in asdf, or anything that causes no results to match.
    • press tab
    • your focus is now gone from this world
    • Unsure when exactly this was fixed
  • The "Rename tab" action removes focus from terminal #9160 (PR: #9162)

if we don't manually yeet the focus back into the active control, then pressing esc to close the command palette actually ends up with focus in the first Tab, similar to in #5750.

I do have one open PR: "When the tab receives focus, immediately move focus to the active control #6290", but I have no idea if that's the right solution. It doesn't feel like it is.

Originally created by @zadjii-msft on GitHub (Jun 25, 2020). I'm just making a megathread for all the issues we've got so far, because there's a bunch, and I'm getting the feeling there needs to be some other comprehensive solution. * [x] Clicking the current tab to raise the window should focus the text area #3609 * [x] ESC from the Tab ContextMenu should return focus to the Terminal #5750 * [x] Launching "Find" from Command Palette doesn't focus the search box #6662 - Unsure when exactly this was fixed * [x] Focus bug 1 - open command palette - press shift+tab - your focus is now in the ~~underlying terminal~~ - ~~As of 1.7, now the focus is _gone from the world_?~~ - As of at least 1.9, this takes focus to the command list. * [x] Focus bug 2 - open command palette - type in `asdf`, or anything that causes no results to match. - press tab - your focus is now [_gone from this world_](https://thedarkestfallingstar.files.wordpress.com/2019/03/tumblr_mhv1cxlzim1s3uvpwo6_500.gif?w=354) - Unsure when exactly this was fixed * [x] The "Rename tab" action removes focus from terminal #9160 (PR: #9162) if we don't manually yeet the focus back into the active control, then pressing <kbd>esc</kbd> to close the command palette actually ends up with focus in the first Tab, similar to in #5750. I do have one open PR: "When the tab receives focus, immediately move focus to the active control #6290", but I have no idea if that's the right solution. It doesn't feel like it is.
Author
Owner

@ghost commented on GitHub (May 25, 2021):

:tada:This issue was addressed in #10048, which has now been successfully released as Windows Terminal v1.8.1444.0.🎉

Handy links:

@ghost commented on GitHub (May 25, 2021): :tada:This issue was addressed in #10048, which has now been successfully released as `Windows Terminal v1.8.1444.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.8.1444.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Author
Owner

@ghost commented on GitHub (May 25, 2021):

:tada:This issue was addressed in #10048, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.🎉

Handy links:

@ghost commented on GitHub (May 25, 2021): :tada:This issue was addressed in #10048, which has now been successfully released as `Windows Terminal Preview v1.9.1445.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.9.1445.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9273