starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-09 02:26:45 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Remove workaround "When we add a new tab in compact mode, re-enforce Compact mode" #9280

New Issue
Closed
opened 2026-01-31 01:50:35 +00:00 by claunia · 8 comments
claunia commented 2026-01-31 01:50:35 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jun 25, 2020).

Originally assigned to: @marcelwgn on GitHub.

When we get a version of WinUI with a fix for https://github.com/microsoft/microsoft-ui-xaml/issues/2711, we can go ahead and revert #6670. This task is tracking that future work.

Originally created by @zadjii-msft on GitHub (Jun 25, 2020). Originally assigned to: @marcelwgn on GitHub. When we get a version of WinUI with a fix for https://github.com/microsoft/microsoft-ui-xaml/issues/2711, we can go ahead and revert #6670. This task is tracking that future work.
claunia commented 2026-01-31 01:50:36 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 25, 2020):

Triaged

@DHowett commented on GitHub (Jun 25, 2020): Triaged
claunia commented 2026-01-31 01:50:36 +00:00
Author
Owner
Copy Link

@marcelwgn commented on GitHub (Jul 10, 2020):

The new prerelease of WinUI (2.5.0.prerelease.200708003) contains the fix for TabView, so with that prerelease, the workaround can be removed.

@marcelwgn commented on GitHub (Jul 10, 2020): The new prerelease of WinUI (2.5.0.prerelease.200708003) contains the fix for TabView, so with that prerelease, the workaround can be removed.
claunia commented 2026-01-31 01:50:36 +00:00
Author
Owner
Copy Link

@marcelwgn commented on GitHub (Aug 28, 2020):

I would like to work on this issue.

@marcelwgn commented on GitHub (Aug 28, 2020): I would like to work on this issue.
claunia commented 2026-01-31 01:50:37 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 28, 2020):

Go right ahead! You'll probably need to bump our MUX version up across the entire solution. I'd take a look at https://github.com/microsoft/terminal/blob/master/doc/building.md#updating-nuget-package-references for a quick and dirty script for doing that part ☺️

@zadjii-msft commented on GitHub (Aug 28, 2020): Go right ahead! You'll probably need to bump our MUX version up across the entire solution. I'd take a look at https://github.com/microsoft/terminal/blob/master/doc/building.md#updating-nuget-package-references for a quick and dirty script for doing that part ☺️
claunia commented 2026-01-31 01:50:37 +00:00
Author
Owner
Copy Link

@marcelwgn commented on GitHub (Aug 28, 2020):

Thanks for the link, I just noticed that for some reason, in the documentation, I chose to make the Oldversion higher then the Newversion. Mind if I create a separate PR to fix this? The current way it is presented might be a bit confusing for other folks reading that part.

@marcelwgn commented on GitHub (Aug 28, 2020): Thanks for the link, I just noticed that for some reason, in the documentation, I chose to make the Oldversion higher then the Newversion. Mind if I create a separate PR to fix this? The current way it is presented might be a bit confusing for other folks reading that part.
claunia commented 2026-01-31 01:50:37 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 28, 2020):

Oh yea totally - that's probably my bad from the last time I used this script. It probably also bumped the version number within the script itself 😃

@zadjii-msft commented on GitHub (Aug 28, 2020): Oh yea totally - that's probably my bad from the last time I used this script. It probably also bumped the version number _within the script itself_ 😃
claunia commented 2026-01-31 01:50:37 +00:00
Author
Owner
Copy Link

@marcelwgn commented on GitHub (Aug 28, 2020):

Oh right haha, just noticed it doing this on my machine too! Maybe we should choose some nonexistent versions so this doesn't happen again 🤔?

@marcelwgn commented on GitHub (Aug 28, 2020): Oh right haha, just noticed it doing this on my machine too! Maybe we should choose some nonexistent versions so this doesn't happen again 🤔?
claunia commented 2026-01-31 01:50:37 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 28, 2020):

Yea probably haha

@zadjii-msft commented on GitHub (Aug 28, 2020): Yea probably haha
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Help Wanted Issue-Task Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9280
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?