starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

FontSize not working #9574

New Issue
Closed
opened 2026-01-31 01:58:07 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 01:58:07 +00:00
Owner
Copy Link

Originally created by @frostbitefalls on GitHub (Jul 12, 2020).

Environment

Windows 10 Pro, 10.0.18362.900

Steps to reproduce

Windows Terminal 1.0.1811.0 -- edit settings.json, add the line below with any quoted numbers to "defaults",
or to any profile, or both; save settings.json; any active tabs do not change, exit and restart Windows Terminal.

"fontSize" : "24"

(line ends with or without a trailing comma , as needed; no errors reported after saving settings.json and none after restart)

Expected behavior

Font size should change as directed

Actual behavior

Always the same default font size, never changes; same result with or without specifying any "fontFace".

note: ctrl-+ and ctrl-0 always work OK

Originally created by @frostbitefalls on GitHub (Jul 12, 2020). # Environment Windows 10 Pro, 10.0.18362.900 # Steps to reproduce Windows Terminal 1.0.1811.0 -- edit settings.json, add the line below with any quoted numbers to "defaults", or to any profile, or both; save settings.json; any active tabs do not change, exit and restart Windows Terminal. "fontSize" : "24" (line ends with or without a trailing comma , as needed; no errors reported after saving settings.json and none after restart) # Expected behavior Font size should change as directed # Actual behavior Always the same default font size, never changes; same result with or without specifying any "fontFace". note: ctrl-+ and ctrl-0 always work OK
claunia added the Needs-TriageNeeds-Tag-FixNeeds-Attention labels 2026-01-31 01:58:07 +00:00
claunia commented 2026-01-31 01:58:08 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 12, 2020):

You may need to remove the " around 24!

@DHowett commented on GitHub (Jul 12, 2020): You may need to remove the `"` around `24`!
claunia commented 2026-01-31 01:58:08 +00:00
Author
Owner
Copy Link

@frostbitefalls commented on GitHub (Jul 12, 2020):

Too easy ;) About everything else requires quotes.
This item relates to early struggles with misleading error messages from additions to settings.json .
After the wakeup to drop quotes there's a mild surprise the parser or related code didn't gripe about them;
might be worth an enhancement, possibly reducing duplicates.
fontSize works OK, thanks.

@frostbitefalls commented on GitHub (Jul 12, 2020): Too easy ;) About everything else requires quotes. This item relates to early struggles with misleading error messages from additions to settings.json . After the wakeup to drop quotes there's a mild surprise the parser or related code didn't gripe about them; might be worth an enhancement, possibly reducing duplicates. fontSize works OK, thanks.
claunia commented 2026-01-31 01:58:09 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 12, 2020):

Yeah, we have a couple things coming that’ll make the parser more strict and the settings more obvious. #6590 is a pull request that unifies our JSON parsing around a couple type-checking helpers that’ll carp about things like this, and of course we have #1564 (spec: #6720) for the settings UI that’ll hopefully obviate the need for folks editing JSON.

Thanks for the feedback :)

@DHowett commented on GitHub (Jul 12, 2020): Yeah, we have a couple things coming that’ll make the parser more strict and the settings more obvious. #6590 is a pull request that unifies our JSON parsing around a couple type-checking helpers that’ll carp about things like this, and of course we have #1564 (spec: #6720) for the settings UI that’ll hopefully obviate the need for folks editing JSON. Thanks for the feedback :)
claunia commented 2026-01-31 01:58:09 +00:00
Author
Owner
Copy Link

@frostbitefalls commented on GitHub (Jul 12, 2020):

Excellent.
After seeing an options UI with mintty and the experience editing settings.json, I'd expect a UI for WT settings
will be welcomed. I'll add votes for options to set scrollbar color and a solid cursor! (eg rxvt).
FWIW, consider the wide dissent against the HTML tag <blink> and when that was dropped.

Meanwhile, thanks again.

@frostbitefalls commented on GitHub (Jul 12, 2020): Excellent. After seeing an options UI with `mintty` and the experience editing settings.json, I'd expect a UI for WT settings will be welcomed. I'll add votes for options to set scrollbar color and a `solid` cursor! (eg `rxvt`). FWIW, consider the wide dissent against the HTML tag \<blink> and when that was dropped. Meanwhile, thanks again.
claunia commented 2026-01-31 01:58:09 +00:00
Author
Owner
Copy Link

@XilefNori commented on GitHub (Jul 24, 2020):

You should really make a check config on file save, and show user a message with setting name and problem if the setting cannot not apply! Not just silently discard it!

@XilefNori commented on GitHub (Jul 24, 2020): You should really make a check config on file save, and show user a message with setting name and problem if the setting cannot not apply! Not just silently discard it!
claunia commented 2026-01-31 01:58:09 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 24, 2020):

So, like this?

(quote from two comments above yours, from @DHowett)

Yeah, we have a couple things coming that’ll make the parser more strict and the settings more obvious. #6590 is a pull request that unifies our JSON parsing around a couple type-checking helpers that’ll carp about things like this, and of course we have #1564 (spec: #6720) for the settings UI that’ll hopefully obviate the need for folks editing JSON.

@DHowett commented on GitHub (Jul 24, 2020): So, like this? (quote from two comments above yours, from @DHowett) > Yeah, we have a couple things coming that’ll make the parser more strict and the settings more obvious. #6590 is a pull request that unifies our JSON parsing around a couple type-checking helpers that’ll carp about things like this, and of course we have #1564 (spec: #6720) for the settings UI that’ll hopefully obviate the need for folks editing JSON.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Needs-Attention Needs-Tag-Fix Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9574
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?