starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Command Palette key bindings are unreadable in High Contrast mode #9588

New Issue
Closed
opened 2026-01-31 01:58:32 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 01:58:32 +00:00
Owner
Copy Link

Originally created by @DHowett on GitHub (Jul 13, 2020).

image

Originally created by @DHowett on GitHub (Jul 13, 2020). ![image](https://user-images.githubusercontent.com/189190/87260417-a14b5b00-c466-11ea-8f89-8207415d6544.png)
claunia commented 2026-01-31 01:58:34 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 13, 2020):

Would you look at that, they sure are. Probably regressed after #6833, but hey, that's okay!

@jtippet might have an idea for the best way to fix this. I'm sure it's as easy as "make the text black in HC mode"

@zadjii-msft commented on GitHub (Jul 13, 2020): Would you look at that, they sure are. Probably regressed after #6833, but hey, that's okay! @jtippet might have an idea for the best way to fix this. I'm sure it's as easy as "make the text black in HC mode"
claunia commented 2026-01-31 01:58:34 +00:00
Author
Owner
Copy Link

@jtippet commented on GitHub (Jul 13, 2020):

Yeah I didn't know that UI existed, so I didn't even test it. I've now reverse-engineered how to launch it, and can repro the bug. It looks like the problem is that that UI element's background is using a foreground brush:

<!-- CommandPalette.xml -->
<Border Background="{ThemeResource SystemControlForegroundBaseLowBrush}">
  <TextBlock Foreground="{ThemeResource SystemControlForegroundBaseMediumBrush}"/>
</Border>

I claim that putting a foreground brush into a background attribute should generally be viewed as a datatype mismatch, or at least some sort of red flag.

If nobody beats me to it, I'll cook up a fix tonight (PST) after my day job. I am inclined to remove the backdrop altogether when in HC mode. That'd keep it in line with how MUX does menus:

image

@jtippet commented on GitHub (Jul 13, 2020): Yeah I didn't know that UI existed, so I didn't even test it. I've now reverse-engineered how to launch it, and can repro the bug. It looks like the problem is that that UI element's background is using a foreground brush: ``` <!-- CommandPalette.xml --> <Border Background="{ThemeResource SystemControlForegroundBaseLowBrush}"> <TextBlock Foreground="{ThemeResource SystemControlForegroundBaseMediumBrush}"/> </Border> ``` I claim that putting a foreground brush into a background attribute should generally be viewed as a datatype mismatch, or at least some sort of red flag. If nobody beats me to it, I'll cook up a fix tonight (PST) after my day job. I am inclined to remove the backdrop altogether when in HC mode. That'd keep it in line with how MUX does menus: ![image](https://user-images.githubusercontent.com/10259764/87336134-3f3a3680-c4f6-11ea-8136-bf462b45376d.png)
claunia commented 2026-01-31 01:58:34 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 22, 2020):

:tada:This issue was addressed in #6910, which has now been successfully released as Windows Terminal Preview v1.2.2022.0.🎉

Handy links:

@ghost commented on GitHub (Jul 22, 2020): :tada:This issue was addressed in #6910, which has now been successfully released as `Windows Terminal Preview v1.2.2022.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.2.2022.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Accessibility Area-UserInterface Issue-Bug Priority-1 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9588
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?