starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Epic: Introduce Actions page to the Settings UI #9601

New Issue
Open
opened 2026-01-31 01:58:55 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 01:58:55 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jul 13, 2020).

Originally assigned to: @carlos-zamora on GitHub.

written and maintained by @carlos-zamora

Description

A largely missing part of the Settings UI is actions. This will allow the user to customize their command palette and key bindings without the need to go into the JSON.

Much like the implementation plan for the Settings UI, there are many moving pieces to this that are outside of the TerminalSettingsEditor project:

Some follow-up work items:

  • Key chord editor/listener
    • Instead of parsing key chord text, it'd be nice if we could listen for key chords.
    • Inspiration: We should take a look at how PowerToys got around this problem.
    • Inspiration: An old version of SUI also had this implemented (back during the hackathon).
    • PR Portable tabs between windows. (#10652)
  • "the unbound bug"
    • Edit switchToTab to win+shift+q. Save. Edit switchToTab to ctrl+shift+t.
    • "unbound": "win+shift+q" appears but doesn't need to exist.
  • Actions::_GetContainerIndexByKeyChord optimization
    • We're just doing a O(n) search for a matching key chord, but we could technically do this much faster.
    • The list is already sorted by command name, so if we...
      1. use GetActionByKeyChord() to get the Command
      2. perform a binary search on the list using Command::Name() (assuming it has a name)
    • we should be able to accomplish this search in O(log n) time (usually)'
  • Performance
    • Clicking Actions in the left bar of Settings takes about 3 seconds to load and doesn't cache/keep it
  • "Touch Keyboard and Handwriting Panel Service" isn't running (#11341)

Bugs:

  • Settings Model:
    • #10365: not serializing top-level "iterateOn" commands! (PR #10373)
    • GetKeyBindingForAction doesn't always find the given action (PR #10341)
  • Settings UI:
    • #10406: Edit button on actions page is invisible with light theme

References

#7175 should be kept in mind during this design.

Originally created by @zadjii-msft on GitHub (Jul 13, 2020). Originally assigned to: @carlos-zamora on GitHub. _written and maintained by @carlos-zamora_ ## Description A largely missing part of the Settings UI is actions. This will allow the user to customize their command palette and key bindings without the need to go into the JSON. Much like the implementation plan for the Settings UI, there are many moving pieces to this that are outside of the `TerminalSettingsEditor` project: - [x] #8100: Inheritance for actions - enables ability to track where an action came from - PR #9621 - [x] serialization for actions - step 1: general serialization - step 2: only serialize meaningful changes into settings.json (don't serialize the whole thing) - PR #9926 - [x] Design Settings UI representation - PR #9427 - [x] Implement proposed design - Foundation (PR #9949) - delete a key binding - set the key chord for a key binding - miscellaneous work (i.e. keyboard navigation, accessibility, etc...) - Set Action - change the action for a key binding (PR #10220) - add a new key binding (PR #10550) Some follow-up work items: - [x] Key chord editor/listener - Instead of parsing key chord text, it'd be nice if we could listen for key chords. - Inspiration: We should take a look at how PowerToys got around this problem. - Inspiration: An old version of SUI also had this implemented (back during the hackathon). - PR #10652 - [ ] "the unbound bug" - Edit `switchToTab` to `win+shift+q`. Save. Edit `switchToTab` to `ctrl+shift+t`. - `"unbound": "win+shift+q"` appears but doesn't need to exist. - [ ] `Actions::_GetContainerIndexByKeyChord` optimization - We're just doing a O(n) search for a matching key chord, but we could technically do this much faster. - The list is already sorted by command name, so if we... 1. use `GetActionByKeyChord()` to get the `Command` 2. perform a binary search on the list using `Command::Name()` (assuming it has a name) - we should be able to accomplish this search in O(log n) time (usually)' - **Performance** - [ ] Clicking Actions in the left bar of Settings takes about 3 seconds to load and doesn't cache/keep it - [ ] #11341 Bugs: - Settings Model: - [X] #10365: not serializing top-level "iterateOn" commands! (PR #10373) - [x] `GetKeyBindingForAction` doesn't always find the given action (PR #10341) - Settings UI: - [x] #10406: Edit button on actions page is invisible with light theme ## References #7175 should be kept in mind during this design.
claunia added the Product-TerminalIssue-ScenarioArea-SettingsUI labels 2026-01-31 01:58:55 +00:00
claunia commented 2026-01-31 01:58:55 +00:00
Author
Owner
Copy Link

@gpotter2 commented on GitHub (May 27, 2021):

You can add your feedback as comments in this issue

Here are some personal suggestions regarding the UI. Sorry if I missed something, I didn't try out https://github.com/microsoft/terminal/pull/10220 yet

  • Group the actions by category (e.g. Keybinds that handle tabs, keybinds that handle panes, custom keybinds...). This will make it infinetly more user friendly. Alphabetical sorting (current) isn't really useful, when even the default order of ALL_SHORTCUT_ACTIONS is better.
  • (I personally thought it would have been fancier if simply clicking on the key combo allowed to replace it instead of having to click on the pencil that only appears once the cursor is already on said key combo)

Also massive +1 on follow-up - Key chord editor/listener. That would be pretty life-changing

Thanks again for this amazing work

@gpotter2 commented on GitHub (May 27, 2021): > You can add your feedback as comments in [this issue](https://github.com/microsoft/terminal/issues/6900) Here are some personal suggestions regarding the UI. Sorry if I missed something, I didn't try out https://github.com/microsoft/terminal/pull/10220 yet - Group the actions by category (e.g. Keybinds that handle tabs, keybinds that handle panes, custom keybinds...). This will make it infinetly more user friendly. Alphabetical sorting (current) isn't really useful, when even the default order of `ALL_SHORTCUT_ACTIONS` is better. - (I personally thought it would have been fancier if simply clicking on the key combo allowed to replace it instead of having to click on the pencil that only appears once the cursor is already on said key combo) Also massive +1 on `follow-up - Key chord editor/listener`. That would be pretty life-changing Thanks again for this amazing work
claunia commented 2026-01-31 01:58:56 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 16, 2021):

@carlos-zamora This is in main now, and enabled by default. Should we close this one out?

@zadjii-msft commented on GitHub (Nov 16, 2021): @carlos-zamora This is in main now, and enabled by default. Should we close this one out?
claunia commented 2026-01-31 01:58:56 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Nov 17, 2021):

@carlos-zamora This is in main now, and enabled by default. Should we close this one out?

Oh, good call. I'll handle that today. I just want to promote some of the unfinished work items to issues for tracking.

@carlos-zamora commented on GitHub (Nov 17, 2021): > @carlos-zamora This is in main now, and enabled by default. Should we close this one out? Oh, good call. I'll handle that today. I just want to promote some of the unfinished work items to issues for tracking.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Issue-Scenario Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9601
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?