starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Ctrl+j = Ctrl+return for some reason #9607

New Issue
Closed
opened 2026-01-31 01:59:04 +00:00 by claunia · 8 comments
claunia commented 2026-01-31 01:59:04 +00:00
Owner
Copy Link

Originally created by @catvec on GitHub (Jul 14, 2020).

Environment

Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): 1.0.1401.0

Any other software? Yes, see below.

I initially saw this behavior in PowerShell 7. However I have reproduced it in cmd.exe as well as the old powershell (powershell.exe compared to the new pwsh.exe).

Since this issue has to do with key chords here is my full Windows Terminal configuration file: https://gist.github.com/Noah-Huppert/6d73079767fcc08edea810cd6beb5a89

One will notice that in an effort to isolate the cause of this bug I have unbound every command that was in the default.json keybindings section except for copy and paste.

Steps to reproduce

  1. Open Windows Terminal with PowerShell 7
  2. Enter the following command to see what key is being pressed: 
    [console]::ReadKey()
  3. Press Ctrl+j (Press and hold down the control key (left or right) and then press and hold down the "j" key. Then release both keys.)

Expected behavior

The key chord sent to the shell should be J with a Control modifier. The ReadKey() command should return:

KeyChar Key Modifiers
------- --- ---------

   J   Control

Actual behavior

The key chord sent to the shell is Enter. The ReadKey() command returns:

KeyChar   Key Modifiers
-------   --- ---------
      … Enter   Control

This behavior only occurs in Windows Terminal. If I open up Powershell 7 in the Cmder terminal emulator the expected behavior occurs. The behavior described here in the actual behavior section seems to only occur in Windows Terminal on my machine.

This behavior occurs in any application running within Windows Terminal. Which is what has led me to believe that this is an issue with Windows Terminal and not something else. I initially saw this behavior in Emacs where it kept saying C-<return> was not bound to any commands when I would press C-j. I tested Emacs in powershell.exe and cmd.exe within Windows Terminal and was able to reproduce the bug. Making me confident that pwsh.exe nor powershell.exe nor cmd.exe are causing the issue. The steps to reproduce above are a minimal reproducible example. I write this paragraph only to show that this issue does not have to do with any specifics of how the PowerShell [console]::ReadKey() works.

Originally created by @catvec on GitHub (Jul 14, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ``` Windows build number: 10.0.18363.0 Windows Terminal version (if applicable): 1.0.1401.0 Any other software? Yes, see below. ``` I initially saw this behavior in PowerShell 7. However I have reproduced it in `cmd.exe` as well as the old powershell (`powershell.exe` compared to the new `pwsh.exe`). Since this issue has to do with key chords here is my full Windows Terminal configuration file: https://gist.github.com/Noah-Huppert/6d73079767fcc08edea810cd6beb5a89 One will notice that in an effort to isolate the cause of this bug I have unbound every command that was in the `default.json` `keybindings` section except for copy and paste. # Steps to reproduce 1. Open Windows Terminal with PowerShell 7 2. Enter the following command to see what key is being pressed: ```powershell [console]::ReadKey() ``` 3. Press Ctrl+j (Press and hold down the control key (left or right) and then press and hold down the "j" key. Then release both keys.) <!-- A description of how to trigger this bug. --> # Expected behavior The key chord sent to the shell should be J with a Control modifier. The `ReadKey()` command should return: ``` KeyChar Key Modifiers ------- --- --------- J Control ``` <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> # Actual behavior The key chord sent to the shell is Enter. The `ReadKey()` command returns: ``` KeyChar Key Modifiers ------- --- --------- … Enter Control ``` This behavior only occurs in Windows Terminal. If I open up Powershell 7 in the Cmder terminal emulator the expected behavior occurs. The behavior described here in the actual behavior section seems to only occur in Windows Terminal on my machine. This behavior occurs in any application running within Windows Terminal. Which is what has led me to believe that this is an issue with Windows Terminal and not something else. I initially saw this behavior in Emacs where it kept saying `C-<return>` was not bound to any commands when I would press `C-j`. I tested Emacs in `powershell.exe` and `cmd.exe` within Windows Terminal and was able to reproduce the bug. Making me confident that `pwsh.exe` nor `powershell.exe` nor `cmd.exe` are causing the issue. The steps to reproduce above are a minimal reproducible example. I write this paragraph only to show that this issue does not have to do with any specifics of how the PowerShell `[console]::ReadKey()` works. <!-- What's actually happening? -->
claunia added the Area-InputResolution-DuplicateProduct-Terminal labels 2026-01-31 01:59:04 +00:00
claunia commented 2026-01-31 01:59:05 +00:00
Author
Owner
Copy Link

@catvec commented on GitHub (Jul 14, 2020):

I do have emacs mode enabled in powershell which these issues talk about: https://github.com/microsoft/terminal/issues/3890 and https://github.com/microsoft/terminal/issues/879.

However I don't think this is a duplicate or related to PSReadline because even in cmd.exe the problem occurs.

@catvec commented on GitHub (Jul 14, 2020): I do have emacs mode enabled in powershell which these issues talk about: https://github.com/microsoft/terminal/issues/3890 and https://github.com/microsoft/terminal/issues/879. However I don't think this is a duplicate or related to PSReadline because even in `cmd.exe` the problem occurs.
claunia commented 2026-01-31 01:59:06 +00:00
Author
Owner
Copy Link

@eryksun commented on GitHub (Jul 14, 2020):

I took a look at the result of PowerShell's ReadConsoleInputW calls for ReadKey() and Ctrl+J when running with a console session provided by conhost.exe vs. a session provided by openconsole.exe under Windows Terminal.

conhost.exe:

struct _KEY_EVENT_RECORD
   +0x000 bKeyDown         : 0n1
   +0x004 wRepeatCount     : 1
   +0x006 wVirtualKeyCode  : 0x4a
   +0x008 wVirtualScanCode : 0x24
   +0x00a uChar            : _KEY_EVENT_RECORD::<unnamed-type-uChar>
   +0x00c dwControlKeyState : 8

union _KEY_EVENT_RECORD::<unnamed-type-uChar>
   +0x000 UnicodeChar      : 0xa ''
   +0x000 AsciiChar        : 10 ''

openconsole.exe:

struct _KEY_EVENT_RECORD
   +0x000 bKeyDown         : 0n1
   +0x004 wRepeatCount     : 1
   +0x006 wVirtualKeyCode  : 0xd
   +0x008 wVirtualScanCode : 0x1c
   +0x00a uChar            : _KEY_EVENT_RECORD::<unnamed-type-uChar>
   +0x00c dwControlKeyState : 8

union _KEY_EVENT_RECORD::<unnamed-type-uChar>
   +0x000 UnicodeChar      : 0xa ''
   +0x000 AsciiChar        : 10 ''

It's the same LF (U+000A) Unicode character in each case. But the virtual-key code from conhost.exe is 0x4A ("J"), while openconsole.exe under Windows Terminal returns 0xD (VK_RETURN).

@eryksun commented on GitHub (Jul 14, 2020): I took a look at the result of PowerShell's `ReadConsoleInputW` calls for `ReadKey()` and Ctrl+J when running with a console session provided by conhost.exe vs. a session provided by openconsole.exe under Windows Terminal. conhost.exe: ``` struct _KEY_EVENT_RECORD +0x000 bKeyDown : 0n1 +0x004 wRepeatCount : 1 +0x006 wVirtualKeyCode : 0x4a +0x008 wVirtualScanCode : 0x24 +0x00a uChar : _KEY_EVENT_RECORD::<unnamed-type-uChar> +0x00c dwControlKeyState : 8 union _KEY_EVENT_RECORD::<unnamed-type-uChar> +0x000 UnicodeChar : 0xa '' +0x000 AsciiChar : 10 '' ``` openconsole.exe: ``` struct _KEY_EVENT_RECORD +0x000 bKeyDown : 0n1 +0x004 wRepeatCount : 1 +0x006 wVirtualKeyCode : 0xd +0x008 wVirtualScanCode : 0x1c +0x00a uChar : _KEY_EVENT_RECORD::<unnamed-type-uChar> +0x00c dwControlKeyState : 8 union _KEY_EVENT_RECORD::<unnamed-type-uChar> +0x000 UnicodeChar : 0xa '' +0x000 AsciiChar : 10 '' ``` It's the same LF (U+000A) Unicode character in each case. But the virtual-key code from conhost.exe is 0x4A ("J"), while openconsole.exe under Windows Terminal returns 0xD (`VK_RETURN`).
claunia commented 2026-01-31 01:59:06 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 14, 2020):

This is probably caused by conpty arbitrarily picking one of the two keys. I bet this is better on Terminal Preview, 1.1+. Could you verify for me?

For more info, check out #4999

@zadjii-msft commented on GitHub (Jul 14, 2020): This is probably caused by conpty arbitrarily picking one of the two keys. I _bet_ this is better on Terminal Preview, 1.1+. Could you verify for me? For more info, check out #4999
claunia commented 2026-01-31 01:59:06 +00:00
Author
Owner
Copy Link

@catvec commented on GitHub (Jul 14, 2020):

@zadjii-msft You would be correct. On Windows Terminal 1.1.1812.0:

% [console]::ReadKey()


KeyChar Key Modifiers
------- --- ---------
      …   J   Control

And key combinations which use Ctrl+j work in Emacs as well. 😄

@catvec commented on GitHub (Jul 14, 2020): @zadjii-msft You would be correct. On Windows Terminal 1.1.1812.0: ``` % [console]::ReadKey() KeyChar Key Modifiers ------- --- --------- … J Control ``` And key combinations which use Ctrl+j work in Emacs as well. 😄
claunia commented 2026-01-31 01:59:07 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 14, 2020):

Root cause is that there is no encoding for ^J in VT that is different from that of Ctrl+Enter. This is true of all non-Windows terminals. xterm is worse: it treats Ctrl+Enter as ^M by default.

It just so happens that Windows once let people get more info than that.

/dup #4999

@DHowett commented on GitHub (Jul 14, 2020): Root cause is that _there is no encoding for `^J` in VT that is different from that of <kbd>Ctrl+Enter</kbd>_. This is true of all non-Windows terminals. xterm is worse: it treats <kbd>Ctrl+Enter</kbd> as `^M` by default. It just so happens that Windows once let people get more info than that. /dup #4999
claunia commented 2026-01-31 01:59:07 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 14, 2020):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Jul 14, 2020): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
claunia commented 2026-01-31 01:59:08 +00:00
Author
Owner
Copy Link

@catvec commented on GitHub (Jul 14, 2020):

Thanks Microsoft Terminal team for such a switch response and resolution 👍

@catvec commented on GitHub (Jul 14, 2020): Thanks Microsoft Terminal team for such a switch response and resolution 👍
claunia commented 2026-01-31 01:59:08 +00:00
Author
Owner
Copy Link

@GiorgosXou commented on GitHub (Jun 15, 2022):

It is both a bug and a feature

@GiorgosXou commented on GitHub (Jun 15, 2022): [It is both a bug and a feature](https://stackoverflow.com/a/72633786/11465149)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Input Product-Terminal Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9607
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?