starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

_compareCommandNames should use locale-aware string comparisons #9656

New Issue
Closed
opened 2026-01-31 02:00:19 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 02:00:19 +00:00
Owner
Copy Link

Originally created by @jtippet on GitHub (Jul 16, 2020).

_compareCommandNames operates on strings that are presented to the end-user, so it should sort like a human, not by codepoint. I'm not sure whether this project prefers CompareStringEx or lstrcmp or some CRT routine.

Originally created by @jtippet on GitHub (Jul 16, 2020). [_compareCommandNames ](https://github.com/microsoft/terminal/blob/934ad98786e33407e5549c36e2288601a3a083d8/src/cascadia/TerminalApp/CommandPalette.cpp#L253)operates on strings that are presented to the end-user, so it should sort like a human, not by codepoint. I'm not sure whether this project prefers `CompareStringEx` or `lstrcmp` or some CRT routine.
claunia commented 2026-01-31 02:00:20 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 16, 2020):

If there's some STL wstring locale-sensitive compare, I'd index towards that one. Thanks for pointing this out!

@DHowett commented on GitHub (Jul 16, 2020): If there's some STL wstring locale-sensitive compare, I'd index towards that one. Thanks for pointing this out!
claunia commented 2026-01-31 02:00:21 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Oct 15, 2020):

@DHowett - is something like this STL enough?

static bool _compareCommandNames(const Command& lhs, const Command& rhs)
{
        const auto& f = std::use_facet<std::collate<wchar_t>>(std::locale());
        const auto lhsName = lhs.Name();
        const auto rhsName = rhs.Name();
        return f.compare(lhsName.data(), lhsName.data() + lhsName.size(), rhsName.data(), rhsName.data() + rhsName.size()) < 0;            
}

I am just confused what locale should we use.. just written commands in 3 languages and now wondering what should happen 😄

@Don-Vito commented on GitHub (Oct 15, 2020): @DHowett - is something like this STL enough? ``` static bool _compareCommandNames(const Command& lhs, const Command& rhs) { const auto& f = std::use_facet<std::collate<wchar_t>>(std::locale()); const auto lhsName = lhs.Name(); const auto rhsName = rhs.Name(); return f.compare(lhsName.data(), lhsName.data() + lhsName.size(), rhsName.data(), rhsName.data() + rhsName.size()) < 0; } ``` I am just confused what locale should we use.. just written commands in 3 languages and now wondering what should happen 😄
claunia commented 2026-01-31 02:00:21 +00:00
Author
Owner
Copy Link

@PankajBhojwani commented on GitHub (Oct 16, 2020):

Based on what I see here, @Don-Vito 's way seems the way to go, would you mind making a PR with the change?

@PankajBhojwani commented on GitHub (Oct 16, 2020): Based on what I see [here](https://www.oreilly.com/library/view/c-cookbook/0596007612/ch13s06.html), @Don-Vito 's way seems the way to go, would you mind making a PR with the change?
claunia commented 2026-01-31 02:00:21 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Oct 16, 2020):

@PankajBhojwani - I can absolutely create a PR, but I am not sure what locale should be used. Is std::locale() good enough?

@Don-Vito commented on GitHub (Oct 16, 2020): @PankajBhojwani - I can absolutely create a PR, but I am not sure what locale should be used. Is std::locale() good enough?
claunia commented 2026-01-31 02:00:21 +00:00
Author
Owner
Copy Link

@PankajBhojwani commented on GitHub (Oct 20, 2020):

I think std::locale("") obtains the native locale (source), so that might be what we want actually. Will look into it more and let you know!

@PankajBhojwani commented on GitHub (Oct 20, 2020): I think `std::locale("")` obtains the native locale ([source](https://stdcxx.apache.org/doc/stdlibug/24-3.html)), so that might be what we want actually. Will look into it more and let you know!
claunia commented 2026-01-31 02:00:22 +00:00
Author
Owner
Copy Link

@PankajBhojwani commented on GitHub (Oct 22, 2020):

@Don-Vito at this point I want to say it probably is a fine implementation for now, and to go ahead and make the PR for it if you'd like! We can handle potential issues in post

@PankajBhojwani commented on GitHub (Oct 22, 2020): @Don-Vito at this point I want to say it probably is a fine implementation for now, and to go ahead and make the PR for it if you'd like! We can handle potential issues in post
claunia commented 2026-01-31 02:00:22 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Oct 22, 2020):

@PankajBhojwani - great! I am creating one.

@Don-Vito commented on GitHub (Oct 22, 2020): @PankajBhojwani - great! I am creating one.
claunia commented 2026-01-31 02:00:22 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Oct 23, 2020):

@PankajBhojwani - made it work by explicitly invoking winapi's GetUserDefaultLocaleName. Still need to cleanup the code but please take a look.

@Don-Vito commented on GitHub (Oct 23, 2020): @PankajBhojwani - made it work by explicitly invoking winapi's GetUserDefaultLocaleName. Still need to cleanup the code but please take a look.
claunia commented 2026-01-31 02:00:23 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 19, 2020):

After some additional thought, we're going to try and solve this with #7039 instead. Thanks for all the investigation everyone!

@zadjii-msft commented on GitHub (Nov 19, 2020): After some additional thought, we're going to try and solve this with #7039 instead. Thanks for all the investigation everyone!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Localization Area-UserInterface Help Wanted Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9656
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?