starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Improvements to TerminalInput #966

New Issue
Closed
opened 2026-01-30 22:12:38 +00:00 by claunia · 2 comments
claunia commented 2026-01-30 22:12:38 +00:00
Owner
Copy Link

Originally created by @Nicholas-Baron on GitHub (May 10, 2019).

This line could use = default syntax. This would also reduce the number of lines in the associated cpp.

bf460ab7fe/src/terminal/input/terminalInput.hpp (L26)

Originally created by @Nicholas-Baron on GitHub (May 10, 2019). This line could use ` = default` syntax. This would also reduce the number of lines in the associated cpp. https://github.com/microsoft/Terminal/blob/bf460ab7feed7e203f1c5cf1bc06a1c732742870/src/terminal/input/terminalInput.hpp#L26
claunia commented 2026-01-30 22:12:40 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 11, 2019):

Hey Nicholas,
Thanks for the report. We’re glad to accept pull requests for issues like this!

From: Nicholas Baron notifications@github.com
Sent: Friday, May 10, 2019 3:30:01 PM
To: microsoft/Terminal
Cc: Subscribed
Subject: [microsoft/Terminal] Improvements to TerminalInput (#685)

This line could use = default syntax. This would also reduce the number of lines in the associated cpp.

bf460ab7fe/src/terminal/input/terminalInput.hpp (L26)https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTerminal%2Fblob%2Fbf460ab7feed7e203f1c5cf1bc06a1c732742870%2Fsrc%2Fterminal%2Finput%2FterminalInput.hpp%23L26&data=01%7C01%7Cduhowett%40microsoft.com%7C04c35bbc97b9461602b708d6d5970abd%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=H6ih1sI%2B7kBB9zz2oCmdVqR5ITumQ%2BfDrfu%2FA8CH1JY%3D&reserved=0

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTerminal%2Fissues%2F685&data=01%7C01%7Cduhowett%40microsoft.com%7C04c35bbc97b9461602b708d6d5970abd%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=r9ZC3yMUHZLAbhs8PJJ%2Bl1Ss2Py%2BB%2FZTA59TkHYU5V0%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADNHLGW5ROOZCAES27BZAPTPUXZOTANCNFSM4HMGTLTA&data=01%7C01%7Cduhowett%40microsoft.com%7C04c35bbc97b9461602b708d6d5970abd%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=1zzpQbZuJbRdwSCtPUH66JRJDwLxqyQnl44cGA0%2BzpQ%3D&reserved=0.

@DHowett-MSFT commented on GitHub (May 11, 2019): Hey Nicholas, Thanks for the report. We’re glad to accept pull requests for issues like this! ________________________________ From: Nicholas Baron <notifications@github.com> Sent: Friday, May 10, 2019 3:30:01 PM To: microsoft/Terminal Cc: Subscribed Subject: [microsoft/Terminal] Improvements to TerminalInput (#685) This line could use = default syntax. This would also reduce the number of lines in the associated cpp. https://github.com/microsoft/Terminal/blob/bf460ab7feed7e203f1c5cf1bc06a1c732742870/src/terminal/input/terminalInput.hpp#L26<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTerminal%2Fblob%2Fbf460ab7feed7e203f1c5cf1bc06a1c732742870%2Fsrc%2Fterminal%2Finput%2FterminalInput.hpp%23L26&data=01%7C01%7Cduhowett%40microsoft.com%7C04c35bbc97b9461602b708d6d5970abd%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=H6ih1sI%2B7kBB9zz2oCmdVqR5ITumQ%2BfDrfu%2FA8CH1JY%3D&reserved=0> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTerminal%2Fissues%2F685&data=01%7C01%7Cduhowett%40microsoft.com%7C04c35bbc97b9461602b708d6d5970abd%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=r9ZC3yMUHZLAbhs8PJJ%2Bl1Ss2Py%2BB%2FZTA59TkHYU5V0%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADNHLGW5ROOZCAES27BZAPTPUXZOTANCNFSM4HMGTLTA&data=01%7C01%7Cduhowett%40microsoft.com%7C04c35bbc97b9461602b708d6d5970abd%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=1zzpQbZuJbRdwSCtPUH66JRJDwLxqyQnl44cGA0%2BzpQ%3D&reserved=0>.
claunia commented 2026-01-30 22:12:40 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 15, 2021):

Oh weird, this was fixed in #690, just never marked as closed.

@zadjii-msft commented on GitHub (Jul 15, 2021): Oh weird, this was fixed in #690, just never marked as closed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Area-Input good first issue Help Wanted Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#966
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?