starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Let terminal consumers provide click handlers and pattern recognizers for buffer text #9679

New Issue
Open
opened 2026-01-31 02:00:47 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 02:00:47 +00:00
Owner
Copy Link

Originally created by @ghost on GitHub (Jul 17, 2020).

Description of the new feature/enhancement

Terminal consumers have a need to provide their own handlers for clickable regions of text in the terminal. For example: In VS this could enable clicking on build errors and opening up a document to the line and column called out in the error.

Proposed technical implementation details (optional)

There needs to be two additions to the terminal in order to enable this:

  • Consumers of the terminal must be able to provide a pattern that will identify regions of clickable text
  • Consumers will provide a callback that is called with the clicked text as a parameter
Originally created by @ghost on GitHub (Jul 17, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement Terminal consumers have a need to provide their own handlers for clickable regions of text in the terminal. For example: In VS this could enable clicking on build errors and opening up a document to the line and column called out in the error. <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> # Proposed technical implementation details (optional) There needs to be two additions to the terminal in order to enable this: - Consumers of the terminal must be able to provide a pattern that will identify regions of clickable text - Consumers will provide a callback that is called with the clicked text as a parameter <!-- A clear and concise description of what you want to happen. -->
claunia added the Issue-FeatureArea-OutputProduct-TerminalArea-WPFControl labels 2026-01-31 02:00:47 +00:00
claunia commented 2026-01-31 02:00:48 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 31, 2020):

This will require some part of #204/#574, but is a distinct ask that control consumers be able to add matching conditions and intercept click events.

@DHowett commented on GitHub (Jul 31, 2020): This will require some part of #204/#574, but is a distinct ask that control consumers be able to add matching conditions and intercept click events.
claunia commented 2026-01-31 02:00:48 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 31, 2020):

Triaged into BL, Spec needed.

@DHowett commented on GitHub (Jul 31, 2020): Triaged into BL, Spec needed.
claunia commented 2026-01-31 02:00:48 +00:00
Author
Owner
Copy Link

@vnagarnaik commented on GitHub (Sep 7, 2021):

Would it be possible to work on this FR, now that the #204/#574 have been closed?

@vnagarnaik commented on GitHub (Sep 7, 2021): Would it be possible to work on this FR, now that the #204/#574 have been closed?
claunia commented 2026-01-31 02:00:48 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 7, 2021):

I don't see why not, but whatever design we come up with should appropriately account for #8849, #7562, #8294, #2671, et. al. in #5001.

Actually, should this just be duped to some combination of those?

@zadjii-msft commented on GitHub (Sep 7, 2021): I don't see why not, but whatever design we come up with should appropriately account for #8849, #7562, #8294, #2671, et. al. in #5001. Actually, should this just be duped to some combination of those?
claunia commented 2026-01-31 02:00:49 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 8, 2021):

I'm leaving this open and separate from #8849 because of one key factor:

For example: In VS this could enable clicking on build errors and opening up a document to the line and column called out in the error.

The ControlInteractivity needs a way of raising these events up to the hosting application to figure out what to do with them, not just the TermControl. Right now the control only really recognizes "ShellExecute this URL" as an action. People using the WPFControl will need to be able to say "If you see this pattern, then raise some identifier type of event", and be able to handle that event.

@zadjii-msft commented on GitHub (Sep 8, 2021): I'm leaving this open and separate from #8849 because of one key factor: > For example: In VS this could enable clicking on build errors and opening up a document to the line and column called out in the error. The `ControlInteractivity` needs a way of raising these events up to the hosting application to figure out what to do with them, not just the `TermControl`. Right now the control only really recognizes "ShellExecute this URL" as an action. People using the `WPFControl` will need to be able to say "If you see `this pattern`, then raise `some identifier` type of event", and be able to handle that event.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Output Area-WPFControl Issue-Feature Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9679
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?