starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Underline ANSI escape sequence does not work with space before reset sequence #9693

New Issue
Closed
opened 2026-01-31 02:01:05 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 02:01:05 +00:00
Owner
Copy Link

Originally created by @patriksvensson on GitHub (Jul 20, 2020).

I've noticed that using ANSI escape sequence ESC[4mFOO ESC[0m does not underline the text as expected.
If I remove the space before the reset code ESC[0m, it works as expected.

This works as expected in cmd.exe/powershell.exe (which I assume both uses conhost), conemu and cmder.

Environment

Windows build number: Microsoft Windows NT 10.0.19041.0
Windows Terminal version (if applicable): 1.0.1811.0

Steps to reproduce

  1. Open PowerShell console in Windows Terminal
  2. Run Write-Host "$([char]27)[1mBold$([char]27)[0m $([char]27)[4mUnderline$([char]27)[0m Normal"
    This underlines the text "Underline" as expected.
  3. Run Write-Host "$([char]27)[1mBold $([char]27)[0m$([char]27)[4mUnderline$([char]27)[0m Normal"
    This fails with underlining the text.

They say that a picture is worth a thousand words, so here's a screenshot as well of the repro.

image

Expected behavior

In the third step in the repro, I would expect the text Underline to be underlined.

Actual behavior

The text Underline is not underlined.

Originally created by @patriksvensson on GitHub (Jul 20, 2020). I've noticed that using ANSI escape sequence `ESC[4mFOO ESC[0m` does not underline the text as expected. If I remove the space before the reset code `ESC[0m`, it works as expected. This works as expected in `cmd.exe`/`powershell.exe` (which I assume both uses conhost), `conemu` and `cmder`. # Environment ```none Windows build number: Microsoft Windows NT 10.0.19041.0 Windows Terminal version (if applicable): 1.0.1811.0 ``` # Steps to reproduce 1. Open PowerShell console in Windows Terminal 2. Run `Write-Host "$([char]27)[1mBold$([char]27)[0m $([char]27)[4mUnderline$([char]27)[0m Normal"` *This underlines the text "Underline" as expected.* 3. Run `Write-Host "$([char]27)[1mBold $([char]27)[0m$([char]27)[4mUnderline$([char]27)[0m Normal"` *This fails with underlining the text.* They say that a picture is worth a thousand words, so here's a screenshot as well of the repro. ![image](https://user-images.githubusercontent.com/357872/87888639-45686f80-ca2e-11ea-93e8-9190ca76ec54.png) # Expected behavior In the third step in the repro, I would expect the text `Underline` to be underlined. # Actual behavior The text `Underline` is not underlined.
claunia added the Resolution-Duplicate label 2026-01-31 02:01:05 +00:00
claunia commented 2026-01-31 02:01:05 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 20, 2020):

I believe this was fixed in #6506 (I know it says color, but it applies to all attributes.). I can't reproduce this, or a very similar vim issue (changing colors/changing rendition but not toggling underline turned underline off), after 6506 with the about-to-come-out 1.2 previe

@DHowett commented on GitHub (Jul 20, 2020): I _believe_ this was fixed in #6506 (I know it says color, but it applies to all attributes.). I can't reproduce this, or a very similar vim issue (changing colors/changing rendition but not toggling underline turned underline off), after 6506 with the about-to-come-out 1.2 previe
claunia commented 2026-01-31 02:01:06 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 20, 2020):

If you can build from source, would you mind validating that? If not, no big deal 😄

@DHowett commented on GitHub (Jul 20, 2020): If you can build from source, would you mind validating that? If not, no big deal :smile:
claunia commented 2026-01-31 02:01:06 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 20, 2020):

(For now, /dup #3076)

@DHowett commented on GitHub (Jul 20, 2020): (For now, /dup #3076)
claunia commented 2026-01-31 02:01:06 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 20, 2020):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Jul 20, 2020): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
claunia commented 2026-01-31 02:01:06 +00:00
Author
Owner
Copy Link

@patriksvensson commented on GitHub (Jul 20, 2020):

@DHowett I can reproduce #3076 (which have been fixed) so hopefully, that fix will fix my problem. I will build Windows Terminal from the source tomorrow and verify it.

image

@patriksvensson commented on GitHub (Jul 20, 2020): @DHowett I can reproduce #3076 (which have been fixed) so hopefully, that fix will fix my problem. I will build Windows Terminal from the source tomorrow and verify it. ![image](https://user-images.githubusercontent.com/357872/87889485-2835a000-ca32-11ea-9959-c7183bfc3ad3.png)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9693
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?