starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Tests we should maybe write one day #9722

New Issue
Open
opened 2026-01-31 02:02:14 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 02:02:14 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jul 22, 2020).

I'm gonna use this thread to track things that I think of that probably should be tested, but didn't get a test during the PR for one reason or another. Usually those reasons are

  • We don't have a good testing framework in place for something like that
  • It's a feature / UI test, which is a lot trickier to author a test for
  • It wasn't worth blocking the PR over

I'll add more to this list as I think of them.

Unit Tests

Feature / UI Tests

  • #8183 As we move focus though panes, make sure the MRU order is updated
  • #8183 Make sure that exiting the "last" pane, then trying to MRU to it does the right thing (by going to the pane before it)
  • #8183 Ensure that Pane IDs are assigned sensibly, and are moved correctly when a pane is closed
  • #8549 / Closing a tab in focus mode causes terminal to become unresponsive #7916
  • how #7180 interacts with Provide manual refresh of settings.json or have refresh code follow symlinks (#8610)
  • Introduce startupActions in settings #8770
    • This is a good one. Add a local test for setting startupActions, then verify the layout is as expected
    • Make sure that parsing these args with warnings results in warnings being added to the AppLogic::_warnings
      • and in the awrning case, that only a single tab is created
    • And test that providing args at the commandline will override this setting
  • Tests to make sure that closing other tabs works as expected
  • Tests to make sure "close tabs after" works as expected
  • No idea how to test: "Fix settings not updating on reload #9289"
  • That one time a fragment extension didn't define a Public folder, so it ended up being null, right around March 12th 2021
  • Manually configured Git Bash popped up in a standalone window (#10806)
Originally created by @zadjii-msft on GitHub (Jul 22, 2020). I'm gonna use this thread to track things that I think of that probably should be tested, but didn't get a test during the PR for one reason or another. Usually those reasons are * We don't have a good testing framework in place for something like that * It's a feature / UI test, which is a lot trickier to author a test for * It wasn't worth blocking the PR over I'll add more to this list as I think of them. ## Unit Tests * [ ] https://github.com/microsoft/terminal/pull/8348#discussion_r533606490: If we change the `DefaultProfile`, then serialize the settings, it should be serialized as the value we set it to. * [ ] Tests for `OSC 9 ; 9`, #8330 * [ ] Test the newline stripping/replacing in #8634. Don't really have TermControl tests, so that's something. * [ ] From "Teach flyouts and palette to prefer user bindings over defaults #8725" - test that looking up a binding for an action returns the last one in the settings file - [ ] Similarly, ensure that the layering multiple files, the lookup returns the value from the last file * [ ] #8875 filter control characters pasted to the `TermControl` * [ ] #9392 - test that combining `--suppressApplicationTitle` (or in the `NewTerminalArgs`) works as expected * [ ] Fix selection logic with shift on multi-click #9403 - For this we'd need unit tests for a terminal control. What we really need are unit tests for `ControlInteractivity` (which wraps the UI-like logic around the `ControlCore`). We could do just unit tests for ControlInteractivity, since that would be UI-independent. Oh but if it's in the same lib as TermControl, then do we have the problem that the TermControl is going to want to link with Resources, and load them at runtime (even if the test doesn't have a TermControl in it?) yikes. * [ ] Fix profile name generation to allocate unique name #9816 * [ ] `ControlInteractivity::CopySelectionToClipboard` returns false if there's no selection * [ ] `ControlInteractivityTests::TestPanWithTouch` - does what it says on the label. Never got around to writing it. * [ ] Serialize stub for dynamic profiles #9964 * [ ] Attempt to heal settings files damaged by #9962 #10143 * [x] Scrolling up, then trying to send mouse events shouldn't send VT (from https://github.com/microsoft/terminal/pull/10642#discussion_r673494665) * [ ] Fix SSE2 variant of TextColor::GetColor #10867 * [ ] Monarch methods added in #10972 - `Monarch::SignalClose`, `Monarch::GetNumberOfPeasants`, creating and closing window events * [ ] #11290 * [ ] #11325 * [ ] #11427 * [ ] #13706 * [ ] #5843 * [ ] https://github.com/microsoft/terminal/pull/15822#issuecomment-1679608265 * [ ] more... ## Feature / UI Tests * [ ] #8183 As we move focus though panes, make sure the MRU order is updated * [ ] #8183 Make sure that `exit`ing the "last" pane, then trying to MRU to it does the right thing (by going to the pane before it) * [ ] #8183 Ensure that Pane IDs are assigned sensibly, and are moved correctly when a pane is closed * [ ] #8549 / Closing a tab in focus mode causes terminal to become unresponsive #7916 * [ ] how #7180 interacts with #8610 * [ ] Introduce startupActions in settings #8770 - This is a good one. Add a local test for setting startupActions, then verify the layout is as expected - Make sure that parsing these args with warnings results in warnings being added to the `AppLogic::_warnings` - and in the awrning case, that only a single tab is created - And test that providing args at the commandline will override this setting * [ ] Tests to make sure that closing other tabs works as expected * [ ] Tests to make sure "close tabs after" works as expected * [ ] No idea how to test: "Fix settings not updating on reload #9289" * [ ] That one time a fragment extension didn't define a `Public` folder, so it ended up being null, right around March 12th 2021 * [ ] #10806
claunia added the Help WantedProduct-MetaArea-CodeHealthIssue-Scenario labels 2026-01-31 02:02:14 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Help Wanted Issue-Scenario Product-Meta
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9722
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?