starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

WT and git bash ssh-add not accepting passphrase #9839

New Issue
Closed
opened 2026-01-31 02:05:12 +00:00 by claunia · 8 comments
claunia commented 2026-01-31 02:05:12 +00:00
Owner
Copy Link

Originally created by @chrismetz on GitHub (Jul 25, 2020).

Environment

Windows build number: Windows Version 2004 (OS Build 19041.388)
Windows Terminal version (if applicable): 1.1.2021.0

Any other software?
git bash: 4.4.23(1)-release (installed with git for windows 2.27.0.windows.1)

Steps to reproduce

Unable to reliably reproduce, sometimes it works and other times it does not.

Expected behavior

  1. Start ssh-agent via eval $(ssh-agent -s)
  2. Add ssh key using ssh-add ~/.ssh/id_rsa
  3. Paste ssh key passphrase and have ssh key added.

Actual behavior

  1. Start ssh-agent via eval $(ssh-agent -s)
  2. Add ssh key using ssh-add ~/.ssh/id_rsa
  3. ssh key passphrase is not being accepted. In the below screen show I have attempted to insert the passphrase using ctrl + shift + V multiple times. When it was not accepted I exited the process with ctrl + c and attempted again. A no point did I change the value stored in the clipboard but it was finally accepted.

image

Originally created by @chrismetz on GitHub (Jul 25, 2020). # Environment Windows build number: Windows Version 2004 (OS Build 19041.388) Windows Terminal version (if applicable): 1.1.2021.0 Any other software? git bash: 4.4.23(1)-release (installed with git for windows 2.27.0.windows.1) # Steps to reproduce Unable to reliably reproduce, sometimes it works and other times it does not. # Expected behavior 1. Start ssh-agent via ***eval $(ssh-agent -s)*** 2. Add ssh key using ***ssh-add ~/.ssh/id_rsa*** 3. Paste ssh key passphrase and have ssh key added. # Actual behavior 1. Start ssh-agent via ***eval $(ssh-agent -s)*** 2. Add ssh key using ***ssh-add ~/.ssh/id_rsa*** 3. ssh key passphrase is not being accepted. In the below screen show I have attempted to insert the passphrase using ctrl + shift + V multiple times. When it was not accepted I exited the process with ctrl + c and attempted again. A no point did I change the value stored in the clipboard but it was finally accepted. ![image](https://user-images.githubusercontent.com/16770430/88443632-5bc26100-ce5c-11ea-810c-0249eb025eb3.png)
claunia added the Needs-TriageNeeds-Tag-FixNeeds-Attention labels 2026-01-31 02:05:12 +00:00
claunia commented 2026-01-31 02:05:13 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 27, 2020):

Unfortunately, I can't reproduce this. If you can reproduce it using a test key with a fake password (because I'm going to ask you to capture an input log, and I don't want your actual password!), would you mind generating an input log?

generating an input log
  • Set the following values at the top level of Terminal settings
"debugFeatures": true,
  • Open a new tab in Terminal while holding down Left Alt and Right Alt
    • When you do this, you should get two panes, one of which contains VT sequences. Like this:

image

  • Repro the issue
  • Copy/paste the log out of the right pane, and perhaps include a screenshot (because copying it will strip the coloring)
@DHowett commented on GitHub (Jul 27, 2020): Unfortunately, I can't reproduce this. If you can reproduce it using a test key with a fake password (because I'm going to ask you to capture an input log, and I don't want your actual password!), would you mind generating an input log? <details> <summary>generating an input log</summary> * Set the following values at the top level of Terminal settings ``` "debugFeatures": true, ``` * Open a new tab in Terminal while holding down <kbd>Left Alt</kbd> **and** <kbd>Right Alt</kbd> * When you do this, you should get two panes, one of which contains VT sequences. Like this: ![image](https://user-images.githubusercontent.com/189190/88598033-5bbd8f00-d01d-11ea-8e34-a8ad26cb10f1.png) * Repro the issue * Copy/paste the log out of the right pane, and perhaps include a screenshot (because copying it will strip the coloring) </details>
claunia commented 2026-01-31 02:05:13 +00:00
Author
Owner
Copy Link

@chrismetz commented on GitHub (Jul 28, 2020):

@DHowett will do and I will get back to you

@chrismetz commented on GitHub (Jul 28, 2020): @DHowett will do and I will get back to you
claunia commented 2026-01-31 02:05:14 +00:00
Author
Owner
Copy Link

@chrismetz commented on GitHub (Jul 28, 2020):

@DHowett I was able to replicate using my existing key. The passphrase used came from a password manager so I am ok exposing it, I have also destroyed my key and removed it from anywhere that it was in use. Please see attached screen shot and log file.

ssh-add
ssh-add-log.txt

@chrismetz commented on GitHub (Jul 28, 2020): @DHowett I was able to replicate using my existing key. The passphrase used came from a password manager so I am ok exposing it, I have also destroyed my key and removed it from anywhere that it was in use. Please see attached screen shot and log file. ![ssh-add](https://user-images.githubusercontent.com/16770430/88601817-ccfc5100-d0b4-11ea-90c3-b8768a2187c5.png) [ssh-add-log.txt](https://github.com/microsoft/terminal/files/4985126/ssh-add-log.txt)
claunia commented 2026-01-31 02:05:14 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 28, 2020):

This might seem weird, but.. the only difference between the working attempts and the failing attempts is that the passphrase when it works is ... a space character. In its entirety, the successful passphrase is a space character.

failing

| pressing ctrl,shift             | passphrase                     | releasing ctrl/shift           | pressing/releasing enter
^[[17;29;0;1;4;1_^[[16;54;0;1;20;1_b3bdf6b42fff16bbcbd8384fb1eef8cf^[[16;54;0;0;4;1_^[[17;29;0;0;0;1_^[[13;28;13;1;0;1_^[[13;28;13;0;0;1_
| pressing shift,ctrl              | passphrase                     | releasing ctrl/shift           | pressing/releasing enter
^[[16;54;0;1;16;1_^[[17;29;0;1;20;1_b3bdf6b42fff16bbcbd8384fb1eef8cf^[[17;29;0;0;16;1_^[[16;54;0;0;0;1_^[[13;28;13;1;0;1_^[[13;28;13;0;0;1_

(you got both ctrl-first and shift-first in the above trace; cool!)

also failing

| pressing ctrl/shift             |!| releasing ctrl/shift           | pressing/releasing VK 220            | pressing/releasing enter
^[[17;29;0;1;4;1_^[[16;54;0;1;20;1_␣^[[16;54;0;0;4;1_^[[17;29;0;0;0;1_^[[220;43;92;1;0;1_^[[220;43;92;0;0;1_^[[13;28;13;1;0;1_^[[13;28;13;0;0;1_

VK 220 corresponds to \| on a US-104 keyboard

succeeding

| pressing ctrl/shift             |!| releasing ctrl/shift           | pressing/releasing enter
^[[17;29;0;1;4;1_^[[16;54;0;1;20;1_␣^[[16;54;0;0;4;1_^[[17;29;0;0;0;1_^[[13;28;13;1;0;1_^[[13;28;13;0;0;1_

the ␣, which I've marked with a ! (in the explainer above), is a space character. The debug engine uses ␣ to represent it because, well, spaces would otherwise be invisible 😄

Your password manager may blank the clipboard after a little bit, which might serve to explain why the behavior changes.

Any ideas?

@DHowett commented on GitHub (Jul 28, 2020): This might seem weird, but.. the only difference between the working attempts and the failing attempts is that the passphrase when it _works_ is ... a space character. In its entirety, the successful passphrase is a space character. ### failing ``` | pressing ctrl,shift | passphrase | releasing ctrl/shift | pressing/releasing enter ^[[17;29;0;1;4;1_^[[16;54;0;1;20;1_b3bdf6b42fff16bbcbd8384fb1eef8cf^[[16;54;0;0;4;1_^[[17;29;0;0;0;1_^[[13;28;13;1;0;1_^[[13;28;13;0;0;1_ | pressing shift,ctrl | passphrase | releasing ctrl/shift | pressing/releasing enter ^[[16;54;0;1;16;1_^[[17;29;0;1;20;1_b3bdf6b42fff16bbcbd8384fb1eef8cf^[[17;29;0;0;16;1_^[[16;54;0;0;0;1_^[[13;28;13;1;0;1_^[[13;28;13;0;0;1_ ``` (you got both ctrl-first and shift-first in the above trace; cool!) ### also failing ``` | pressing ctrl/shift |!| releasing ctrl/shift | pressing/releasing VK 220 | pressing/releasing enter ^[[17;29;0;1;4;1_^[[16;54;0;1;20;1_␣^[[16;54;0;0;4;1_^[[17;29;0;0;0;1_^[[220;43;92;1;0;1_^[[220;43;92;0;0;1_^[[13;28;13;1;0;1_^[[13;28;13;0;0;1_ ``` VK 220 corresponds to `\|` on a US-104 keyboard ### succeeding ``` | pressing ctrl/shift |!| releasing ctrl/shift | pressing/releasing enter ^[[17;29;0;1;4;1_^[[16;54;0;1;20;1_␣^[[16;54;0;0;4;1_^[[17;29;0;0;0;1_^[[13;28;13;1;0;1_^[[13;28;13;0;0;1_ ``` the `␣`, which I've marked with a `!` (in the explainer above), is a space character. The debug engine uses ␣ to represent it because, well, spaces would otherwise be invisible :smile: Your password manager may blank the clipboard after a little bit, which might serve to explain why the behavior _changes_. Any ideas?
claunia commented 2026-01-31 02:05:14 +00:00
Author
Owner
Copy Link

@chrismetz commented on GitHub (Jul 28, 2020):

🤦 @DHowett thank you, this has been driving me crazy. I use lastpass extension in chrome and wasn't aware that by default it cleared the clipboard after 60 secs.
Going by what you said above when I generated the key I created it with an empty passphrase due to the clipboard been cleared.

@chrismetz commented on GitHub (Jul 28, 2020): 🤦 @DHowett thank you, this has been driving me crazy. I use lastpass extension in chrome and wasn't aware that by default it cleared the clipboard after 60 secs. Going by what you said above when I generated the key I created it with an empty passphrase due to the clipboard been cleared.
claunia commented 2026-01-31 02:05:14 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 28, 2020):

happy to help 😀

@DHowett commented on GitHub (Jul 28, 2020): happy to help 😀
claunia commented 2026-01-31 02:05:14 +00:00
Author
Owner
Copy Link

@dinyelum commented on GitHub (Jul 26, 2024):

@DHowett Thanks a lot for this answer. My passphrase was working on powershell but wasn't working on git bash, so I got really confused and I got tired of reading anything because I already read so many things from different sources including SO but none seemed to work. I wasn't going to read your answer too but then I just saw where you wrote something about ctrl and shift and I ran off to delete my previous keys and create new keys without touching either ctrl or shift and it worked! Thanks a lot man. Thanks @chrismetz for this question and for not giving up too.

@dinyelum commented on GitHub (Jul 26, 2024): @DHowett Thanks a lot for this answer. My passphrase was working on powershell but wasn't working on git bash, so I got really confused and I got tired of reading anything because I already read so many things from different sources including SO but none seemed to work. I wasn't going to read your answer too but then I just saw where you wrote something about ctrl and shift and I ran off to delete my previous keys and create new keys without touching either ctrl or shift and it worked! Thanks a lot man. Thanks @chrismetz for this question and for not giving up too.
claunia commented 2026-01-31 02:05:14 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 26, 2024):

Wow, I'm happy I was able to help!

@DHowett commented on GitHub (Jul 26, 2024): Wow, I'm happy I was able to help!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Needs-Attention Needs-Tag-Fix Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9839
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?