OSC 12 cursor colour update doesn't appear to be working #9900

Closed
opened 2026-01-31 02:06:58 +00:00 by claunia · 4 comments
Owner

Originally created by @TBBle on GitHub (Jul 28, 2020).

Environment

Windows build number: `Microsoft Windows [Version 10.0.19041.388]`
Windows Terminal version: `1.2.2022.0` (Preview)

Any other software?

Steps to reproduce

In a bash shell:

echo -e '\e]12;rgb:fd/f6/e3\e\'

I've confirmed that changing the 12 to a 10 correctly changes the text foreground colour, and 11 correctly changes the background colour.

I've also tried the same thing in PowerShell, with the same lack of effect.

${ESC}=[char]27
Write-Host "${ESC}]12;rgb:fd/f6/e3${ESC}\"

I've tried both the default cursorShape, and the filledBox shape.

Changes to the cursorColor in the current scheme do take effect correctly.

Expected behavior

The cursor should change from the theme-defined colour into the off-white background of Solarized Light.

Actual behavior

Cursor colour does not change.

Originally created by @TBBle on GitHub (Jul 28, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: `Microsoft Windows [Version 10.0.19041.388]` Windows Terminal version: `1.2.2022.0` (Preview) Any other software? ``` # Steps to reproduce In a bash shell: ```bash echo -e '\e]12;rgb:fd/f6/e3\e\' ``` I've confirmed that changing the 12 to a 10 correctly changes the text foreground colour, and 11 correctly changes the background colour. I've also tried the same thing in PowerShell, with the same lack of effect. ```PowerShell ${ESC}=[char]27 Write-Host "${ESC}]12;rgb:fd/f6/e3${ESC}\" ``` I've tried both the default `cursorShape`, and the `filledBox` shape. Changes to the `cursorColor` in the current scheme do take effect correctly. # Expected behavior The cursor should change from the theme-defined colour into the off-white background of Solarized Light. # Actual behavior Cursor colour does not change.
Author
Owner

@zadjii-msft commented on GitHub (Jul 28, 2020):

Weird, that should be working. It looks like SetCursorColor was never implemented in TerminalDispatch 😧

Maybe we shouldn't have TerminalDispatch extend from TermDispatch, so we know when we forget to implement a method in the Terminal side of things?

@zadjii-msft commented on GitHub (Jul 28, 2020): Weird, that _should_ be working. It looks like `SetCursorColor` was never implemented in `TerminalDispatch` 😧 Maybe we shouldn't have `TerminalDispatch` extend from `TermDispatch`, so we know when we forget to implement a method in the Terminal side of things?
Author
Owner

@TBBle commented on GitHub (Jul 28, 2020):

Speaking of Easy Fixes, whoever picks this up might want to fix the comment on AdaptDispatch::SetCursorColor, since it's currently a copy of the comment on AdaptDispatch::SetColorTableEntry.

@TBBle commented on GitHub (Jul 28, 2020): Speaking of Easy Fixes, whoever picks this up might want to fix the comment on [`AdaptDispatch::SetCursorColor`](https://github.com/microsoft/terminal/blob/76de2aedc2d805481ae323bba6f34cb41878a461/src/terminal/adapter/adaptDispatch.cpp#L2202-L2209), since it's currently a copy of the comment on [`AdaptDispatch::SetColorTableEntry`](https://github.com/microsoft/terminal/blob/76de2aedc2d805481ae323bba6f34cb41878a461/src/terminal/adapter/adaptDispatch.cpp#L2230-L2237).
Author
Owner

@DHowett commented on GitHub (Jul 28, 2020):

-triage +2.0 good call on "easy starter"

@DHowett commented on GitHub (Jul 28, 2020): -triage +2.0 good call on "easy starter"
Author
Owner

@ghost commented on GitHub (Aug 13, 2020):

:tada:This issue was addressed in #7123, which has now been successfully released as Windows Terminal Preview v1.2.2234.0.🎉

Handy links:

@ghost commented on GitHub (Aug 13, 2020): :tada:This issue was addressed in #7123, which has now been successfully released as `Windows Terminal Preview v1.2.2234.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.2.2234.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9900