starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Fix "blurry" new tab icon on 100% DPI #9908

New Issue
Open
opened 2026-01-31 02:07:05 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 02:07:05 +00:00
Owner
Copy Link

Originally created by @moxwel on GitHub (Jul 29, 2020).

Description of the new feature/enhancement

This is a little graphic detail that I noticed long ago. The "new tab" icon in Windows Terminal (1.1.2021.0) with 100% DPI scaling level is somewhat "blurry" or "thick", in comparison of other "new tab" icons like Microsoft Edge.

issue1

This graphic detail does not occur when the DPI scaling is at 125%.
issue2

Proposed technical implementation details (optional)

Update the "new tab" icon to a more "cleaner" version when DPI scaling is at 100%. An example:

issue3

Originally created by @moxwel on GitHub (Jul 29, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> This is a little graphic detail that I noticed long ago. The "new tab" icon in Windows Terminal (1.1.2021.0) **with 100% DPI scaling level** is somewhat _"blurry"_ or _"thick"_, in comparison of other "new tab" icons like Microsoft Edge. ![issue1](https://user-images.githubusercontent.com/49621788/88761685-99b1d480-d13d-11ea-976c-478121b280bd.png) > This graphic detail **does not occur when the DPI scaling is at 125%**. > ![issue2](https://user-images.githubusercontent.com/49621788/88761704-a5050000-d13d-11ea-9814-8d50870b1774.png) # Proposed technical implementation details (optional) <!-- A clear and concise description of what you want to happen. --> Update the "new tab" icon to a more _"cleaner"_ version when DPI scaling is at 100%. An example: ![issue3](https://user-images.githubusercontent.com/49621788/88762129-9408be80-d13e-11ea-9748-52fcac304746.png)
claunia commented 2026-01-31 02:07:06 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 29, 2020):

Thanks for finding this! I'm gonna move this over to the WinUI repo, since I think they'll be better prepared to take care of this issue (and we can just ingest an updated version from them).

Follow up on https://github.com/microsoft/microsoft-ui-xaml/issues/3006

@zadjii-msft commented on GitHub (Jul 29, 2020): Thanks for finding this! I'm gonna move this over to the [WinUI repo](https://github.com/microsoft/microsoft-ui-xaml), since I think they'll be better prepared to take care of this issue (and we can just ingest an updated version from them). Follow up on https://github.com/microsoft/microsoft-ui-xaml/issues/3006
claunia commented 2026-01-31 02:07:07 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 29, 2020):

This one is actually us; we have our own new tab button (made up of a split button with the plus glyph in it.)

@DHowett commented on GitHub (Jul 29, 2020): This one is actually us; we have our own new tab button (made up of a split button with the plus glyph in it.)
claunia commented 2026-01-31 02:07:07 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 29, 2020):

So, this needs @cinnamon-msft to sign off. We actually had a PR that fixed this completely, just before 1.0, that was rejected on the grounds of "i don't like it". #5681.

@DHowett commented on GitHub (Jul 29, 2020): So, this needs @cinnamon-msft to sign off. We actually had a PR that _fixed this completely_, just before 1.0, that was rejected on the grounds of "i don't like it". #5681.
claunia commented 2026-01-31 02:07:07 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 31, 2020):

Assigning @cinnamon-msft by way of passing the baton. She's next up 😄

@DHowett commented on GitHub (Jul 31, 2020): Assigning @cinnamon-msft by way of passing the baton. She's next up :smile:
claunia commented 2026-01-31 02:07:07 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 25, 2021):

I've had this tab open for months and months, and I think it's related to this issue?

https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.uielement.uselayoutrounding?view=winrt-19041

It's been so long that I honestly don't remember any more.

@zadjii-msft commented on GitHub (Mar 25, 2021): I've had this tab open for months and _months_, and I think it's related to this issue? https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.uielement.uselayoutrounding?view=winrt-19041 It's been so long that I honestly don't remember any more.
claunia commented 2026-01-31 02:07:07 +00:00
Author
Owner
Copy Link

@moxwel commented on GitHub (Mar 25, 2021):

What happens if UseLayoutRounding is set to false in src/cascadia/TerminalApp/TabRowControl.xaml ?

Just to know, I really don't know anything about that 😅

@moxwel commented on GitHub (Mar 25, 2021): What happens if `UseLayoutRounding` is set to `false` in [src/cascadia/TerminalApp/TabRowControl.xaml](https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalApp/TabRowControl.xaml#L30) ? Just to know, I really don't know anything about that 😅
claunia commented 2026-01-31 02:07:07 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 15, 2022):

Hmm, seems like this was fixed sometime recently.

image

Probably when we updated to Controlsv2. @moxwel do you see this on 1.14 (stable) or 1.15 (preview) anymore/?

@zadjii-msft commented on GitHub (Jul 15, 2022): Hmm, seems like this was fixed sometime recently. ![image](https://user-images.githubusercontent.com/18356694/179297002-fd49cafb-a429-4974-8081-af6ee304b55e.png) Probably when we updated to Controlsv2. @moxwel do you see this on 1.14 (stable) or 1.15 (preview) anymore/?
claunia commented 2026-01-31 02:07:08 +00:00
Author
Owner
Copy Link

@moxwel commented on GitHub (Jul 15, 2022):

I still have not recieved 1.14 stable from Microsoft Store.

Just installed 1.15 preview from Store. The '+' symbol is still the same with 100% DPI.

2

On another PC with 125% DPI is normal.

image

I'm still using Windows 10. I've not tested it on Windows 11.

@moxwel commented on GitHub (Jul 15, 2022): I still have not recieved 1.14 stable from Microsoft Store. Just installed 1.15 preview from Store. The '+' symbol is still the same with 100% DPI. ![2](https://user-images.githubusercontent.com/49621788/179317680-9e8b271c-024b-4011-8c43-29eb2154564c.png) On another PC with 125% DPI is normal. ![image](https://user-images.githubusercontent.com/49621788/179317802-b08c3ce1-7a5a-40bf-a8e2-c28140abe0f3.png) I'm still using Windows 10. I've not tested it on Windows 11.
claunia commented 2026-01-31 02:07:08 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 19, 2022):

I'm still using Windows 10. I've not tested it on Windows 11

~Hmm. I wonder if that's actually why I'm seeing a difference. Perhaps the glyph is just hinted better in Segoe UI Fluent vs MDL2. I'll need to pull out an old Win10 laptop to confirm my suspicions. If that's the case, then we might be out of luck here on Win10 😕 ~

update 2022-09-09: Looks like I was mistaken, I totally still see this.
image

@zadjii-msft commented on GitHub (Jul 19, 2022): > I'm still using Windows 10. I've not tested it on Windows 11 ~Hmm. I wonder if that's actually why I'm seeing a difference. Perhaps the glyph is just hinted better in Segoe UI Fluent vs MDL2. I'll need to pull out an old Win10 laptop to confirm my suspicions. If that's the case, then we might be out of luck here on Win10 😕 ~ update 2022-09-09: Looks like I was mistaken, I totally still see this. ![image](https://user-images.githubusercontent.com/18356694/189394394-cb647fb9-f918-4022-8d5a-4c9495f96cef.png)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Help Wanted Issue-Bug Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9908
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?