starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Incorrect tab behavior after using Ctrl+w #991

New Issue
Closed
opened 2026-01-30 22:13:17 +00:00 by claunia · 2 comments
claunia commented 2026-01-30 22:13:17 +00:00
Owner
Copy Link

Originally created by @sasmithjr on GitHub (May 11, 2019).

  • Your Windows build number:

    • Microsoft Windows [Version 10.0.18362.86]
    • Did a git pull master before using VS2019 to deploy locally.

  • What you're doing and what's happening:

    1. To start, have 4 tabs open.
    2. Go to the 1st tab
    3. Hit Ctrl + w to close it. Terminal behaves as expected and closes the tab
    4. Both a and b below are where the bug shows up:
      a. Hit Ctrl + w again. The new 2nd tab (originally the 3rd tab) closes instead
      b. Hit Ctrl + Tab to cycle. Focus will change from the 1st tab to the 3rd tab (originally 4th) tab. 1st tab will also retain focused coloring.

    Also: If you start with 3 tabs open and then close the first one with Ctrl + w, you're not able to use Ctrl + Tab to cycle to the next tab.

    4a and 4b are not consecutive steps. They're different actions which can mess up after step 3

  • What's wrong / what should be happening instead:
    For 4a: focused tab should close
    For 4b: 2nd tab should become selected, not the 3rd.

If there's any more information you need, please let me know!

Originally created by @sasmithjr on GitHub (May 11, 2019). * Your Windows build number: * Microsoft Windows [Version 10.0.18362.86] * Did a `git pull master` before using VS2019 to deploy locally. * What you're doing and what's happening: 1. To start, have 4 tabs open. 2. Go to the 1st tab 3. Hit Ctrl + w to close it. Terminal behaves as expected and closes the tab 4. Both a and b below are where the bug shows up: a. Hit Ctrl + w again. The new 2nd tab (originally the 3rd tab) closes instead b. Hit Ctrl + Tab to cycle. Focus will change from the 1st tab to the 3rd tab (originally 4th) tab. 1st tab will also retain focused coloring. Also: If you start with 3 tabs open and then close the first one with Ctrl + w, you're not able to use Ctrl + Tab to cycle to the next tab. 4a and 4b are not consecutive steps. They're different actions which can mess up after step 3 * What's wrong / what should be happening instead: For 4a: focused tab should close For 4b: 2nd tab should become selected, not the 3rd. If there's any more information you need, please let me know!
claunia added the Help WantedIssue-BugArea-UserInterface labels 2026-01-30 22:13:18 +00:00
claunia commented 2026-01-30 22:13:18 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 13, 2019):

Oh lawd that looks messed up. Good catch.

Anyone who's taking a look at this, I'd direct your attention to src/cascadia/TerminalApp/App.cpp. That manages the entire list of tabs, so it's probably where we're focusing tabs incorrectly.

@zadjii-msft commented on GitHub (May 13, 2019): Oh lawd that looks messed up. Good catch. Anyone who's taking a look at this, I'd direct your attention to `src/cascadia/TerminalApp/App.cpp`. That manages the entire list of tabs, so it's probably where we're focusing tabs incorrectly.
claunia commented 2026-01-30 22:13:18 +00:00
Author
Owner
Copy Link

@bef178 commented on GitHub (May 13, 2019):

This is even worse with mouse-click.
Repo:
1 open 4 tabs, say a, b, c and d
2 activate a
3 click a's close button, then b
4 actual: tabview exists; all items in tabview is grayed; tab shows b's content and user can still operate on it

@bef178 commented on GitHub (May 13, 2019): This is even worse with mouse-click. Repo: 1 open 4 tabs, say a, b, c and d 2 activate a 3 click a's close button, then b 4 actual: tabview exists; all items in tabview is grayed; tab shows b's content and user can still operate on it
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Help Wanted Issue-Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#991
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?