starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Duplicate WT_SESSION and WT_PROFILE_ID in WSLENV env var #9931

New Issue
Closed
opened 2026-01-31 02:07:47 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 02:07:47 +00:00
Owner
Copy Link

Originally created by @abarani on GitHub (Jul 30, 2020).

Environment

Windows build number: 10.0.19041.388
Windows Terminal version (if applicable): 1.1.2021.0

Steps to reproduce

  • Open Windows Terminal
  • setx WSLENV "${env:WSLENV}:TEST/p"
  • Close and reopen Windows Terminal
  • echo $env:WSLENV

Expected behavior

WT_SESSION:WT_PROFILE_ID:TEST/p

Actual behavior

WT_SESSION:WT_SESSION::WT_PROFILE_ID:TEST/p:WT_PROFILE_ID

I think the right thing to do here is to split WSLENV by : and check those vars are already set instead of just simply prepending and appending a string.

Probable related PRs:

Originally created by @abarani on GitHub (Jul 30, 2020). # Environment ```none Windows build number: 10.0.19041.388 Windows Terminal version (if applicable): 1.1.2021.0 ``` # Steps to reproduce - Open Windows Terminal - `setx WSLENV "${env:WSLENV}:TEST/p"` - Close and reopen Windows Terminal - `echo $env:WSLENV` # Expected behavior WT_SESSION:WT_PROFILE_ID:TEST/p # Actual behavior WT_SESSION:WT_SESSION::WT_PROFILE_ID:TEST/p:WT_PROFILE_ID --- I think the right thing to do here is to split `WSLENV` by `:` and check those vars are already set instead of just simply prepending and appending a string. Probable related PRs: - https://github.com/microsoft/terminal/pull/4157 - https://github.com/microsoft/terminal/pull/4852
claunia commented 2026-01-31 02:07:49 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 30, 2020):

Good catch! There's an inherent danger in using setx to immortalize the contents of an environment variable at runtime, because even TEST/p is going to get duplicated if you keep doing that ...

I'm not sure it harms anything other than aesthetics, but I'll tag this one up as a code health issue.

@DHowett commented on GitHub (Jul 30, 2020): Good catch! There's an inherent danger in using `setx` to immortalize the contents of an environment variable at runtime, because even `TEST/p` is going to get duplicated if you keep doing that ... I'm not sure it harms anything other than aesthetics, but I'll tag this one up as a code health issue.
claunia commented 2026-01-31 02:07:49 +00:00
Author
Owner
Copy Link

@huiyooumich commented on GitHub (Mar 21, 2022):

Hello, this is my first time making a contribution here! I would like to work on this.

@huiyooumich commented on GitHub (Mar 21, 2022): Hello, this is my first time making a contribution here! I would like to work on this.
claunia commented 2026-01-31 02:07:49 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 21, 2022):

@huiyooumich awesome, go for it! I don't think you'd be stepping on anyone's toes here. I'm pretty sure ConptyConnection::_LaunchAttachedClient in ConptyConnection.cpp is where we're setting up the environment variables. Let us know if you need any pointers ☺️

@zadjii-msft commented on GitHub (Mar 21, 2022): @huiyooumich awesome, go for it! I don't think you'd be stepping on anyone's toes here. I'm pretty sure `ConptyConnection::_LaunchAttachedClient` in `ConptyConnection.cpp` is where we're setting up the environment variables. Let us know if you need any pointers ☺️
claunia commented 2026-01-31 02:07:50 +00:00
Author
Owner
Copy Link

@huiyooumich commented on GitHub (Jun 30, 2022):

Unfortunately, I have stopped working on this due to lack of time. But thank you so much for the advice and I hope if anyone else wants to give this a go they'll find it a lot easier.

@huiyooumich commented on GitHub (Jun 30, 2022): Unfortunately, I have stopped working on this due to lack of time. But thank you so much for the advice and I hope if anyone else wants to give this a go they'll find it a lot easier.
claunia commented 2026-01-31 02:07:50 +00:00
Author
Owner
Copy Link

@Weichenleeeee123 commented on GitHub (Jul 22, 2025):

Hi , I'm a newcomer here and i would like to take this task if there's no one had taken it.

@Weichenleeeee123 commented on GitHub (Jul 22, 2025): Hi , I'm a newcomer here and i would like to take this task if there's no one had taken it.
claunia commented 2026-01-31 02:07:50 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 28, 2025):

@Weichenleeeee123 thanks for working on this bug!

@DHowett commented on GitHub (Jul 28, 2025): @Weichenleeeee123 thanks for working on this bug!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Area-TerminalConnection good first issue Help Wanted In-PR Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9931
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?