starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add top-level nested commands #9994

New Issue
Closed
opened 2026-01-31 02:09:37 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 02:09:37 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Aug 4, 2020).

Originally assigned to: @DHowett, @miniksa on GitHub.

I'm filing this one to get team feedback for what commands we should include in the defaults once #6856 lands. I'm gonna throw the usual suspects on the Assigned To line, and remove yourself when you've shared thoughts

Shouldn't we replace the "newTab" and "splitPane" entries here with nested/iterable commands?

I was thinking, something neat would be to make the tree look like this:

<Command Palette>
└─ Open Profile...
   ├─ Profile 1...
   |  ├─ New Tab
   |  ├─ Split Automatically
   |  ├─ Split Vertically
   |  └─ Split Horizontally
   ├─ Profile 2...
   |  ├─ New Tab
   |  ├─ Split Automatically
   |  ├─ Split Vertically
   |  └─ Split Horizontally
   └─ Profile 3...
      ├─ New Tab
      ├─ Split Automatically
      ├─ Split Vertically
      └─ Split Horizontally

_Originally posted by @carlos-zamora in #6856

Yea, that's what I was thinking too, but I think I wanted to open a broader discussion with the team for what these commands should be. I was thinking that there's be two top-level ones (Split pane... and New Tab...), but I want a team consensus on those.

In my head, this is how I pictured it:

  {
    "name": "New tab...",
    "commands": [
      {
        "iterateOn": "profiles",
        "icon": "${profile.icon}",
        "name": "${profile.name}",
        "command": { "action": "newTab", "profile": "${profile.name}" }
      }
    ]
  },
  {
    "name": "Split pane...",
    "commands": [
      {
        "iterateOn": "profiles",
        "icon": "${profile.icon}",
        "name": "${profile.name}...",
        "commands": [
          {
            "name": "Split automatically",
            "command": { "action": "splitPane", "profile": "${profile.name}", "split": "automatic" }
          },
          {
            "name": "Split vertically",
            "command": { "action": "splitPane", "profile": "${profile.name}", "split": "vertical" }
          },
          {
            "name": "Split horizontally",
            "command": { "action": "splitPane", "profile": "${profile.name}", "split": "horizontal" }
          }
        ]
      }
    ]
  }

Which then would evaluate to

<Command Palette>
├─ New tab...
|  ├─ Profile 1
|  ├─ Profile 2
|  └─ Profile 3
└─ Split pane...
   ├─ Profile 1...
   |  ├─ Split Automatically
   |  ├─ Split Vertically
   |  └─ Split Horizontally
   ├─ Profile 2...
   |  ├─ Split Automatically
   |  ├─ Split Vertically
   |  └─ Split Horizontally
   └─ Profile 3...
      ├─ Split Automatically
      ├─ Split Vertically
      └─ Split Horizontally
Originally created by @zadjii-msft on GitHub (Aug 4, 2020). Originally assigned to: @DHowett, @miniksa on GitHub. I'm filing this one to get **team feedback** for what commands we should include in the defaults once #6856 lands. I'm gonna throw the usual suspects on the Assigned To line, and remove yourself when you've shared thoughts <hr> Shouldn't we replace the "newTab" and "splitPane" entries here with nested/iterable commands? I was thinking, something neat would be to make the tree look like this: ``` <Command Palette> └─ Open Profile... ├─ Profile 1... | ├─ New Tab | ├─ Split Automatically | ├─ Split Vertically | └─ Split Horizontally ├─ Profile 2... | ├─ New Tab | ├─ Split Automatically | ├─ Split Vertically | └─ Split Horizontally └─ Profile 3... ├─ New Tab ├─ Split Automatically ├─ Split Vertically └─ Split Horizontally ``` _Originally posted by @carlos-zamora in #6856 <hr> > Yea, that's what I was thinking too, but I think I wanted to open a broader discussion with the team for what these commands should be. I was thinking that there's be two top-level ones (Split pane... and New Tab...), but I want a team consensus on those. <hr> In my head, this is how I pictured it: ```json { "name": "New tab...", "commands": [ { "iterateOn": "profiles", "icon": "${profile.icon}", "name": "${profile.name}", "command": { "action": "newTab", "profile": "${profile.name}" } } ] }, { "name": "Split pane...", "commands": [ { "iterateOn": "profiles", "icon": "${profile.icon}", "name": "${profile.name}...", "commands": [ { "name": "Split automatically", "command": { "action": "splitPane", "profile": "${profile.name}", "split": "automatic" } }, { "name": "Split vertically", "command": { "action": "splitPane", "profile": "${profile.name}", "split": "vertical" } }, { "name": "Split horizontally", "command": { "action": "splitPane", "profile": "${profile.name}", "split": "horizontal" } } ] } ] } ``` Which then would evaluate to ``` <Command Palette> ├─ New tab... | ├─ Profile 1 | ├─ Profile 2 | └─ Profile 3 └─ Split pane... ├─ Profile 1... | ├─ Split Automatically | ├─ Split Vertically | └─ Split Horizontally ├─ Profile 2... | ├─ Split Automatically | ├─ Split Vertically | └─ Split Horizontally └─ Profile 3... ├─ Split Automatically ├─ Split Vertically └─ Split Horizontally ```
claunia commented 2026-01-31 02:09:38 +00:00
Author
Owner
Copy Link

@cinnamon-msft commented on GitHub (Aug 18, 2020):

I prefer the layout of option 2. However, I could see a use case for people searching for a specific profile and the default behavior would be to open a new tab.

@cinnamon-msft commented on GitHub (Aug 18, 2020): I prefer the layout of option 2. However, I could see a use case for people searching for a specific profile and the default behavior would be to open a new tab.
claunia commented 2026-01-31 02:09:38 +00:00
Author
Owner
Copy Link

@leonMSFT commented on GitHub (Aug 19, 2020):

I like 2 better as well, its layout seems more logical to me. IMO I feel like if I wanted to open a New Tab or Split Pane (with a specific profile or not), I'd look through the cmdpal for those commands verbatim instead of looking for Open Profile.

In addition to the nested New Tab and Split Pane, I'd still like to leave in a non-nested version of New Tab and Split Pane that do their default behaviors for quick one-shot enter keypresses instead of double/triple keypress to navigate through the nested versions.

@leonMSFT commented on GitHub (Aug 19, 2020): I like 2 better as well, its layout seems more logical to me. IMO I feel like if I wanted to open a `New Tab` or `Split Pane` (with a specific profile or not), I'd look through the cmdpal for those commands verbatim instead of looking for `Open Profile`. In addition to the nested `New Tab` and `Split Pane`, I'd still like to leave in a non-nested version of `New Tab` and `Split Pane` that do their default behaviors for quick one-shot <kbd>enter</kbd> keypresses instead of double/triple keypress to navigate through the nested versions.
claunia commented 2026-01-31 02:09:38 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 19, 2020):

Alright well that's enough consensus for me to go on. I'll ship a PR for option 2, and we'll finish discussion in the PR. Thanks guys!

@zadjii-msft commented on GitHub (Aug 19, 2020): Alright well that's enough consensus for me to go on. I'll ship a PR for option 2, and we'll finish discussion in the PR. Thanks guys!
claunia commented 2026-01-31 02:09:38 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Aug 26, 2020):

:tada:This issue was addressed in #7348, which has now been successfully released as Windows Terminal Preview v1.3.2382.0.🎉

Handy links:

@ghost commented on GitHub (Aug 26, 2020): :tada:This issue was addressed in #7348, which has now been successfully released as `Windows Terminal Preview v1.3.2382.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.3.2382.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Question Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#9994
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?