mirror of
https://github.com/microsoft/terminal.git
synced 2026-04-21 05:31:37 +00:00
### User Stories:
1. A user wants to be able to use the executable path as their starting title
- Does anyone want this?
2. A user wants to be able to set a custom starting title, but have that title be overridable
3. A user wants to be able to set an overridable starting title, different from the profile name
- Presumably someone will want this
4. A user totally wants to ignore the VT title and use something else
- This will make more sense in the post [#1320] "Support runtime variables in the custom user title" settings
### Solutions:
1. `name`, `startingTitle`, `tabTitle`
* a. `name` is only ever used as the profile name.
* b. If `startingTitle` isn't set, then the executable path is used
* c. If `startingTitle` is set, it's used as the initial title
* d. If `tabTitle` is set, it overrides the title from the terminal
* e. Current users of `tabTitle` need to manually update to the new behavior.
2. `name` as starting title, `tabTitle` as a different starting title
* a. `name` is used as the starting title and the profile name in the dropdown
* b. If `tabTitle` is set, we'll use that as the overridable starting title instead.
* c. In the future, `dynamicTabTitle` or `tabTitleOverride` could be added to support [#1320]
* d. Current users of `tabTitle` automatically get the new (different!) behavior.
* e. User Story 1 is impossible
- Does anyone want the behavior _ever_? Perhaps making that scenario impossible is good?
3. `name` unchanged, `tabTitle` as the starting title
* a. `name` is only ever used as the profile name.
* b. If `tabTitle` is set, we'll use that as the overridable starting title.
* c. In the future, `dynamicTabTitle` or `tabTitleOverride` could be added to support [#1320]
* d. Current users of `tabTitle` automatically get the new (different!) behavior.
4. `name` as starting title, `tabTitle` as different starting title, `suppressApplicationTitle` Boolean to force it to override
* a. `name`, `tabTitle` work as in Solution 2.
* b. When someone wants to be able to statically totally override that title (story 4), they can use `suppressApplicationTitle`
* c. `suppressApplicationTitle` name is WIP
* d. We'll add `suppressApplicationTitle` when someone complains
* e. If you really want story 1, use `tabTitle: c:\path\to\foo.exe` and `suppressApplicationTitle`.
[#1320]: https://github.com/microsoft/terminal/issues/1320
We've decided to pursue path 4.
221 lines
7.1 KiB
C++
221 lines
7.1 KiB
C++
// Copyright (c) Microsoft Corporation.
|
|
// Licensed under the MIT license.
|
|
|
|
#include "pch.h"
|
|
#include "ConhostConnection.h"
|
|
#include "windows.h"
|
|
#include <sstream>
|
|
|
|
#include "ConhostConnection.g.cpp"
|
|
|
|
#include <conpty-universal.h>
|
|
#include "../../types/inc/Utils.hpp"
|
|
#include "../../types/inc/UTF8OutPipeReader.hpp"
|
|
|
|
using namespace ::Microsoft::Console;
|
|
|
|
namespace winrt::Microsoft::Terminal::TerminalConnection::implementation
|
|
{
|
|
ConhostConnection::ConhostConnection(const hstring& commandline,
|
|
const hstring& startingDirectory,
|
|
const hstring& startingTitle,
|
|
const uint32_t initialRows,
|
|
const uint32_t initialCols,
|
|
const guid& initialGuid) :
|
|
_initialRows{ initialRows },
|
|
_initialCols{ initialCols },
|
|
_commandline{ commandline },
|
|
_startingDirectory{ startingDirectory },
|
|
_startingTitle{ startingTitle },
|
|
_guid{ initialGuid }
|
|
{
|
|
if (_guid == guid{})
|
|
{
|
|
_guid = Utils::CreateGuid();
|
|
}
|
|
}
|
|
|
|
winrt::guid ConhostConnection::Guid() const noexcept
|
|
{
|
|
return _guid;
|
|
}
|
|
|
|
winrt::event_token ConhostConnection::TerminalOutput(Microsoft::Terminal::TerminalConnection::TerminalOutputEventArgs const& handler)
|
|
{
|
|
return _outputHandlers.add(handler);
|
|
}
|
|
|
|
void ConhostConnection::TerminalOutput(winrt::event_token const& token) noexcept
|
|
{
|
|
_outputHandlers.remove(token);
|
|
}
|
|
|
|
winrt::event_token ConhostConnection::TerminalDisconnected(Microsoft::Terminal::TerminalConnection::TerminalDisconnectedEventArgs const& handler)
|
|
{
|
|
return _disconnectHandlers.add(handler);
|
|
}
|
|
|
|
void ConhostConnection::TerminalDisconnected(winrt::event_token const& token) noexcept
|
|
{
|
|
_disconnectHandlers.remove(token);
|
|
}
|
|
|
|
void ConhostConnection::Start()
|
|
{
|
|
std::wstring cmdline{ _commandline.c_str() };
|
|
std::optional<std::wstring> startingDirectory;
|
|
if (!_startingDirectory.empty())
|
|
{
|
|
startingDirectory = _startingDirectory;
|
|
}
|
|
|
|
EnvironmentVariableMapW extraEnvVars;
|
|
{
|
|
// Convert connection Guid to string and ignore the enclosing '{}'.
|
|
std::wstring wsGuid{ Utils::GuidToString(_guid) };
|
|
wsGuid.pop_back();
|
|
|
|
const wchar_t* const pwszGuid{ wsGuid.data() + 1 };
|
|
|
|
// Ensure every connection has the unique identifier in the environment.
|
|
extraEnvVars.emplace(L"WT_SESSION", pwszGuid);
|
|
}
|
|
|
|
// Create our own output handling thread
|
|
// Each connection needs to make sure to drain the output from its backing host.
|
|
_hOutputThread.reset(CreateThread(nullptr,
|
|
0,
|
|
StaticOutputThreadProc,
|
|
this,
|
|
0,
|
|
nullptr));
|
|
|
|
THROW_LAST_ERROR_IF_NULL(_hOutputThread);
|
|
|
|
STARTUPINFO si = { 0 };
|
|
si.cb = sizeof(STARTUPINFOW);
|
|
|
|
// If we have a startingTitle, create a mutable character buffer to add
|
|
// it to the STARTUPINFO.
|
|
std::unique_ptr<wchar_t[]> mutableTitle{ nullptr };
|
|
if (!_startingTitle.empty())
|
|
{
|
|
mutableTitle = std::make_unique<wchar_t[]>(_startingTitle.size() + 1);
|
|
THROW_IF_NULL_ALLOC(mutableTitle);
|
|
THROW_IF_FAILED(StringCchCopy(mutableTitle.get(), _startingTitle.size() + 1, _startingTitle.c_str()));
|
|
si.lpTitle = mutableTitle.get();
|
|
}
|
|
|
|
THROW_IF_FAILED(
|
|
CreateConPty(cmdline,
|
|
startingDirectory,
|
|
static_cast<short>(_initialCols),
|
|
static_cast<short>(_initialRows),
|
|
&_inPipe,
|
|
&_outPipe,
|
|
&_signalPipe,
|
|
&_piConhost,
|
|
0,
|
|
si,
|
|
extraEnvVars));
|
|
|
|
_connected = true;
|
|
}
|
|
|
|
void ConhostConnection::WriteInput(hstring const& data)
|
|
{
|
|
if (!_connected || _closing.load())
|
|
{
|
|
return;
|
|
}
|
|
|
|
// convert from UTF-16LE to UTF-8 as ConPty expects UTF-8
|
|
std::string str = winrt::to_string(data);
|
|
bool fSuccess = !!WriteFile(_inPipe.get(), str.c_str(), (DWORD)str.length(), nullptr, nullptr);
|
|
fSuccess;
|
|
}
|
|
|
|
void ConhostConnection::Resize(uint32_t rows, uint32_t columns)
|
|
{
|
|
if (!_connected)
|
|
{
|
|
_initialRows = rows;
|
|
_initialCols = columns;
|
|
}
|
|
else if (!_closing.load())
|
|
{
|
|
SignalResizeWindow(_signalPipe.get(), Utils::ClampToShortMax(columns, 1), Utils::ClampToShortMax(rows, 1));
|
|
}
|
|
}
|
|
|
|
void ConhostConnection::Close()
|
|
{
|
|
if (!_connected)
|
|
{
|
|
return;
|
|
}
|
|
|
|
if (!_closing.exchange(true))
|
|
{
|
|
// It is imperative that the signal pipe be closed first; this triggers the
|
|
// pseudoconsole host's teardown. See PtySignalInputThread.cpp.
|
|
_signalPipe.reset();
|
|
_inPipe.reset();
|
|
_outPipe.reset();
|
|
|
|
// Tear down our output thread -- now that the output pipe was closed on the
|
|
// far side, we can run down our local reader.
|
|
WaitForSingleObject(_hOutputThread.get(), INFINITE);
|
|
_hOutputThread.reset();
|
|
|
|
// Wait for conhost to terminate.
|
|
WaitForSingleObject(_piConhost.hProcess, INFINITE);
|
|
|
|
_hJob.reset(); // This is a formality.
|
|
_piConhost.reset();
|
|
}
|
|
}
|
|
|
|
DWORD WINAPI ConhostConnection::StaticOutputThreadProc(LPVOID lpParameter)
|
|
{
|
|
ConhostConnection* const pInstance = (ConhostConnection*)lpParameter;
|
|
return pInstance->_OutputThread();
|
|
}
|
|
|
|
DWORD ConhostConnection::_OutputThread()
|
|
{
|
|
UTF8OutPipeReader pipeReader{ _outPipe.get() };
|
|
std::string_view strView{};
|
|
|
|
// process the data of the output pipe in a loop
|
|
while (true)
|
|
{
|
|
HRESULT result = pipeReader.Read(strView);
|
|
if (FAILED(result) || result == S_FALSE)
|
|
{
|
|
if (_closing.load())
|
|
{
|
|
// This is okay, break out to kill the thread
|
|
return 0;
|
|
}
|
|
|
|
_disconnectHandlers();
|
|
return (DWORD)-1;
|
|
}
|
|
|
|
if (strView.empty())
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
// Convert buffer to hstring
|
|
auto hstr{ winrt::to_hstring(strView) };
|
|
|
|
// Pass the output to our registered event handlers
|
|
_outputHandlers(hstr);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
}
|