SabreTools/BinaryObjectScanner
1
0
Fork 0
mirror of https://github.com/SabreTools/BinaryObjectScanner.git synced 2026-04-24 23:30:07 +00:00
Code Issues 295 Packages Projects Releases 20 Wiki Activity

This can fail?

Browse Source
This commit is contained in:
Matt Nadareski
2025-09-03 10:51:29 -04:00
parent b1600ad7d2
commit 0efc6aef10
1 changed files with 17 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
BinaryObjectScanner/FileType/Executable.cs
View File

@@ -279,17 +279,25 @@ namespace BinaryObjectScanner.FileType
if (nex.Header == null || nex.SegmentTable == null || nex.ResourceTable?.ResourceTypes == null)
return null;
// Get the overlay data, if possible
byte[]? overlayData = nex.OverlayData;
if (overlayData == null || overlayData.Length == 0)
try
{
_overlayStrings[nex] = [];
// Get the overlay data, if possible
byte[]? overlayData = nex.OverlayData;
if (overlayData == null || overlayData.Length == 0)
{
_overlayStrings[nex] = [];
return [];
}
// Otherwise, cache and return the strings
_overlayStrings[nex] = ReadStringsFrom(overlayData, charLimit: 3) ?? [];
return _overlayStrings[nex];
}
catch
{
// Ignore the error for now
return [];
}
// Otherwise, cache and return the strings
_overlayStrings[nex] = ReadStringsFrom(overlayData, charLimit: 3) ?? [];
return _overlayStrings[nex];
}
}
@@ -369,7 +377,7 @@ namespace BinaryObjectScanner.FileType
_sectionStringData[pex]![index] = [];
return [];
}
// Otherwise, cache and return the strings
_sectionStringData[pex]![index] = ReadStringsFrom(sectionData, charLimit: 4) ?? [];
return _sectionStringData[pex]![index];