SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-04 05:35:52 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

Replace "We" comments

Browse Source
This commit is contained in:
Matt Nadareski
2025-10-11 16:06:53 -04:00
parent 65b9735941
commit cd8b484ae3
14 changed files with 123 additions and 122 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELIST.md
View File

@@ -8,6 +8,7 @@
- Use WriteToFile extension for zip entries
- Move output file implementations to separate namespace
- Conditionally require state
- Replace "We" comments
### 3.5.0 (2025-10-10)

4
MPF.Frontend/DumpEnvironment.cs
View File

@@ -771,7 +771,7 @@ namespace MPF.Frontend
}
catch
{
// We don't care what the error is
// Absorb the exception
return false;
}
@@ -827,7 +827,7 @@ namespace MPF.Frontend
}
catch
{
// We don't care what the error is
// Absorb the exception
return false;
}

4
MPF.Frontend/Tools/IRDTool.cs
View File

@@ -36,7 +36,7 @@ namespace MPF.Frontend.Tools
}
catch (Exception)
{
// We don't care what the error is
// Absorb the exception
return false;
}
}
@@ -91,7 +91,7 @@ namespace MPF.Frontend.Tools
}
catch (Exception)
{
// We don't care what the error is
// Absorb the exception
return false;
}
}

36
MPF.Frontend/Tools/PhysicalTool.cs
View File

@@ -57,7 +57,7 @@ namespace MPF.Frontend.Tools
}
catch
{
// We don't care what the error is
// Absorb the exception
return null;
}
}
@@ -93,7 +93,7 @@ namespace MPF.Frontend.Tools
}
catch
{
// We don't care what the error is
// Absorb the exception
return null;
}
@@ -149,7 +149,7 @@ namespace MPF.Frontend.Tools
}
catch
{
// We don't care what the error is
// Absorb the exception
return false;
}
}
@@ -205,7 +205,7 @@ namespace MPF.Frontend.Tools
}
catch
{
// We don't care what the error is, assume SYSTEM.CNF doesn't exist
// Absorb the exception, assume SYSTEM.CNF doesn't exist
}
// If the SYSTEM.CNF value can't be found, try PSX.EXE
@@ -274,7 +274,7 @@ namespace MPF.Frontend.Tools
}
catch
{
// We don't care what the error is
// Absorb the exception
return null;
}
}
@@ -306,7 +306,7 @@ namespace MPF.Frontend.Tools
}
catch
{
// We don't care what the error was
// Absorb the exception
return null;
}
}
@@ -327,7 +327,7 @@ namespace MPF.Frontend.Tools
}
catch
{
// We don't care what the error was
// Absorb the exception
return null;
}
}
@@ -364,7 +364,7 @@ namespace MPF.Frontend.Tools
}
catch
{
// We don't care what the error was
// Absorb the exception
return null;
}
}
@@ -385,7 +385,7 @@ namespace MPF.Frontend.Tools
}
catch
{
// We don't care what the error was
// Absorb the exception
return null;
}
}
@@ -430,7 +430,7 @@ namespace MPF.Frontend.Tools
}
catch
{
// We don't care what the error was
// Absorb the exception
return null;
}
}
@@ -468,7 +468,7 @@ namespace MPF.Frontend.Tools
}
catch
{
// We don't care what the error was
// Absorb the exception
return null;
}
}
@@ -506,7 +506,7 @@ namespace MPF.Frontend.Tools
}
catch
{
// We don't care what the error was
// Absorb the exception
return null;
}
}
@@ -559,7 +559,7 @@ namespace MPF.Frontend.Tools
}
catch
{
// We don't care what the error was
// Absorb the exception
return null;
}
}
@@ -582,7 +582,7 @@ namespace MPF.Frontend.Tools
}
catch
{
// We don't care what the error was
// Absorb the exception
return null;
}
}
@@ -605,7 +605,7 @@ namespace MPF.Frontend.Tools
}
catch
{
// We don't care what the error was
// Absorb the exception
return null;
}
}
@@ -657,7 +657,7 @@ namespace MPF.Frontend.Tools
}
catch
{
// We don't care what the error was
// Absorb the exception
return null;
}
}
@@ -710,7 +710,7 @@ namespace MPF.Frontend.Tools
}
catch
{
// We don't care what the error was
// Absorb the exception
return null;
}
}
@@ -747,7 +747,7 @@ namespace MPF.Frontend.Tools
}
catch
{
// We don't care what the error is
// Absorb the exception
return null;
}
}

2
MPF.Frontend/ViewModels/MainViewModel.cs
View File

@@ -1526,7 +1526,7 @@ namespace MPF.Frontend.ViewModels
return null;
}
// We're going to assume for floppies, HDDs, and removable drives
// Floppies, HDDs, and removable drives are assumed
if (drive.InternalDriveType != InternalDriveType.Optical)
return RedumpSystem.IBMPCcompatible;

8
MPF.Processors/Aaru.cs
View File

@@ -1174,7 +1174,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return long.MaxValue;
}
}
@@ -1317,7 +1317,7 @@ namespace MPF.Processors
{
foreach (ChecksumType checksum in dmi.Checksums)
{
// We only care about the CRC32
// Only CRC is collected
if (checksum.type == ChecksumTypeType.crc32)
{
dmihash = checksum.Value;
@@ -1335,7 +1335,7 @@ namespace MPF.Processors
{
foreach (ChecksumType checksum in pfi.Checksums)
{
// We only care about the CRC32
// Only CRC is collected
if (checksum.type == ChecksumTypeType.crc32)
{
pfihash = checksum.Value;
@@ -1355,7 +1355,7 @@ namespace MPF.Processors
{
foreach (ChecksumType checksum in security.Checksums)
{
// We only care about the CRC32
// Only CRC is collected
if (checksum.type == ChecksumTypeType.crc32)
{
// TODO: Validate correctness for all 3 fields

6
MPF.Processors/BaseProcessor.cs
View File

@@ -328,7 +328,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the error is
// Absorb the exception
return;
}
finally
@@ -730,7 +730,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the error was right now
// Absorb the exception right now
return null;
}
}
@@ -784,7 +784,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the error is
// Absorb the exception
return false;
}
}

8
MPF.Processors/CleanRip.cs
View File

@@ -152,7 +152,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the error was right now
// Absorb the exception right now
return null;
}
}
@@ -225,7 +225,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -265,7 +265,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the error was right now
// Absorb the exception right now
return null;
}
}
@@ -380,7 +380,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return false;
}
}

48
MPF.Processors/DiscImageCreator.cs
View File

@@ -351,7 +351,7 @@ namespace MPF.Processors
if (GetXGDAuxInfo($"{basePath}_disc.txt", out _, out _, out _, out var xgd1SS, out _))
{
// We no longer care about SS Version from DIC
// SS Version from DIC is ignored now
//info.CommonDiscInfo!.CommentsSpecialFields![SiteCode.SSVersion] = xgd1SSVer ?? string.Empty;
info.Extras!.SecuritySectorRanges = xgd1SS ?? string.Empty;
}
@@ -363,7 +363,7 @@ namespace MPF.Processors
info.CommonDiscInfo!.CommentsSpecialFields![SiteCode.DMIHash] = xgd1DMIHash ?? string.Empty;
info.CommonDiscInfo.CommentsSpecialFields[SiteCode.PFIHash] = xgd1PFIHash ?? string.Empty;
info.CommonDiscInfo.CommentsSpecialFields[SiteCode.SSHash] = xgd1SSHash ?? string.Empty;
// We no longer care about SS Version from DIC
// SS Version from DIC is ignored now
//info.CommonDiscInfo.CommentsSpecialFields[SiteCode.SSVersion] = xgd1SSVer ?? string.Empty;
info.Extras!.SecuritySectorRanges = xgd1SS ?? string.Empty;
}
@@ -397,7 +397,7 @@ namespace MPF.Processors
if (GetXGDAuxInfo($"{basePath}_disc.txt", out _, out _, out _, out var xgd23SS, out _))
{
// We no longer care about SS Version from DIC
// SS Version from DIC is ignored now
//info.CommonDiscInfo!.CommentsSpecialFields![SiteCode.SSVersion] = xgd23SSVer ?? string.Empty;
info.Extras!.SecuritySectorRanges = xgd23SS ?? string.Empty;
}
@@ -409,7 +409,7 @@ namespace MPF.Processors
info.CommonDiscInfo!.CommentsSpecialFields![SiteCode.DMIHash] = xgd23DMIHash ?? string.Empty;
info.CommonDiscInfo.CommentsSpecialFields[SiteCode.PFIHash] = xgd23PFIHash ?? string.Empty;
info.CommonDiscInfo.CommentsSpecialFields[SiteCode.SSHash] = xgd23SSHash ?? string.Empty;
// We no longer care about SS Version from DIC
// SS Version from DIC is ignored now
//info.CommonDiscInfo.CommentsSpecialFields[SiteCode.SSVersion] = xgd23SSVer ?? string.Empty;
info.Extras!.SecuritySectorRanges = xgd23SS ?? string.Empty;
}
@@ -934,7 +934,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -1003,7 +1003,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -1078,7 +1078,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
discTypeOrBookType = null;
return false;
}
@@ -1257,7 +1257,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return -1;
}
}
@@ -1289,7 +1289,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the error is
// Absorb the exception
return false;
}
}
@@ -1343,7 +1343,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return false;
}
}
@@ -1401,7 +1401,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -1582,7 +1582,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -1620,7 +1620,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -1716,7 +1716,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return false;
}
}
@@ -1773,7 +1773,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -1829,7 +1829,7 @@ namespace MPF.Processors
if (line == null)
return null;
// We assume the first non-LBA0/4 sector listed is the proper one
// Assume the first non-LBA0/4 sector listed is the proper one
// Fast forward to the PVD
while ((line = sr.ReadLine())?.StartsWith("0310") == false) ;
@@ -1842,7 +1842,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -1874,7 +1874,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the error is
// Absorb the exception
return false;
}
}
@@ -1925,7 +1925,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
secuROMScheme = SecuROMScheme.None;
return null;
}
@@ -1984,7 +1984,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the error is
// Absorb the exception
return false;
}
}
@@ -2052,7 +2052,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -2136,7 +2136,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
volLabels = [];
return false;
}
@@ -2204,7 +2204,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -2328,7 +2328,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return false;
}
}

6
MPF.Processors/Enumerations.cs
View File

@@ -1,6 +1,6 @@
namespace MPF.Processors
{
/// <summary>
/// <summary>
/// Indicates the type of compression used for logs
/// </summary>
public enum LogCompression
@@ -14,7 +14,7 @@ namespace MPF.Processors
/// PKZIP using DEFLATE level 9
/// </summary>
DeflateMaximum,
/// <summary>
/// PKZIP using Zstd level 19
/// </summary>
@@ -53,4 +53,4 @@ namespace MPF.Processors
/// </summary>
V4Plus,
}
}
}

12
MPF.Processors/ProcessingTool.cs
View File

@@ -61,7 +61,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -117,7 +117,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -136,7 +136,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the error was
// Absorb the exception
return null;
}
}
@@ -297,7 +297,7 @@ namespace MPF.Processors
if (di?.Units == null || di.Units.Length < 1)
return null;
// We assume the identifier is consistent across all units
// Assume the identifier is consistent across all units
return di.Units[0]?.Body?.DiscTypeIdentifier;
}
@@ -584,7 +584,7 @@ namespace MPF.Processors
}
catch
{
// We are not concerned with the error
// Absorb the exception
return false;
}
@@ -705,7 +705,7 @@ namespace MPF.Processors
}
catch
{
// We are not concerned with the error
// Absorb the exception
return false;
}

76
MPF.Processors/Redumper.cs
View File

@@ -773,7 +773,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return false;
}
}
@@ -811,7 +811,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return false;
}
}
@@ -855,7 +855,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -878,7 +878,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -919,7 +919,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -963,7 +963,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
discProfile = null;
return false;
}
@@ -1018,7 +1018,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
discType = null;
return false;
}
@@ -1280,7 +1280,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
redumpErrors = -1; c2Errors = -1;
return false;
}
@@ -1356,7 +1356,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -1401,12 +1401,12 @@ namespace MPF.Processors
}
}
// We couldn't detect it then
// Required lines were not found
return false;
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return false;
}
}
@@ -1483,7 +1483,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return false;
}
}
@@ -1537,7 +1537,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -1577,7 +1577,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -1617,7 +1617,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -1700,7 +1700,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return false;
}
}
@@ -1738,7 +1738,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -1778,7 +1778,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -1816,7 +1816,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -1854,7 +1854,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -1892,7 +1892,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -1921,12 +1921,12 @@ namespace MPF.Processors
return line.Substring("non-zero data sample range: [".Length).Trim().Split(' ')[0];
}
// We couldn't detect it then
// Required lines were not found
return null;
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -1965,12 +1965,12 @@ namespace MPF.Processors
}
}
// We couldn't detect it then
// Required lines were not found
return null;
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -2003,7 +2003,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the error is
// Absorb the exception
return false;
}
}
@@ -2089,7 +2089,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -2163,7 +2163,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return -1;
}
}
@@ -2223,7 +2223,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
secuROMScheme = SecuROMScheme.None;
return null;
}
@@ -2295,7 +2295,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -2324,12 +2324,12 @@ namespace MPF.Processors
return line.Substring("Universal Hash (SHA-1): ".Length).Trim();
}
// We couldn't detect it then
// Required lines were not found
return null;
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -2374,7 +2374,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -2407,12 +2407,12 @@ namespace MPF.Processors
return line.Substring("arguments: ".Length).Trim();
}
// We couldn't detect any arguments
// Required lines were not found
return null;
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -2467,7 +2467,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
volLabels = [];
return false;
}
@@ -2497,12 +2497,12 @@ namespace MPF.Processors
return line.Substring("disc write offset: ".Length).Trim();
}
// We couldn't detect it then
// Required lines were not found
return null;
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}

6
MPF.Processors/UmdImageCreator.cs
View File

@@ -146,7 +146,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -210,7 +210,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return false;
}
}
@@ -293,7 +293,7 @@ namespace MPF.Processors
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
volLabels = [];
return false;
}

28
MPF.Processors/XboxBackupCreator.cs
View File

@@ -241,12 +241,12 @@ namespace MPF.Processors
}
}
// We couldn't find a successful dump
// Required lines were not found
return false;
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return false;
}
}
@@ -280,12 +280,12 @@ namespace MPF.Processors
return line.Substring("Xbox Backup Creator ".Length).Trim();
}
// We couldn't detect the version
// Required lines were not found
return null;
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -322,12 +322,12 @@ namespace MPF.Processors
}
}
// We couldn't detect the drive model
// Required lines were not found
return null;
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -366,12 +366,12 @@ namespace MPF.Processors
}
}
// We couldn't detect the Layerbreak
// Required lines were not found
return false;
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return false;
}
}
@@ -441,12 +441,12 @@ namespace MPF.Processors
}
}
// We couldn't detect the read error count
// Required lines were not found
return false;
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return false;
}
}
@@ -486,12 +486,12 @@ namespace MPF.Processors
}
}
// We couldn't detect the Layerbreak
// Required lines were not found
return null;
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return null;
}
}
@@ -620,12 +620,12 @@ namespace MPF.Processors
}
}
// We couldn't detect the replay table
// Required lines were not found
return false;
}
catch
{
// We don't care what the exception is right now
// Absorb the exception
return false;
}
}