mirror of
https://github.com/SabreTools/MPF.git
synced 2026-07-02 17:24:48 +00:00
Clean up a couple more TODOs
This commit is contained in:
@@ -155,7 +155,6 @@ namespace MPF.Check
|
||||
string filepath = Path.GetFullPath(args[i].Trim('"'));
|
||||
|
||||
// Now populate an environment
|
||||
// TODO: Replace this with Dictionary constructor
|
||||
var options = new Options
|
||||
{
|
||||
InternalProgram = Converters.ToInternalProgram(internalProgram),
|
||||
|
||||
@@ -75,7 +75,6 @@ namespace MPF.Data
|
||||
public KnownSystem? System { get; set; }
|
||||
|
||||
// Name not defined by Redump
|
||||
// TODO: Have this convert to a new `RedumpMedia?` if possible, for submission
|
||||
[JsonProperty(PropertyName = "d_media", Required = Required.AllowNull)]
|
||||
[JsonConverter(typeof(MediaTypeConverter))]
|
||||
public MediaType? Media { get; set; }
|
||||
|
||||
@@ -6,8 +6,10 @@ namespace MPF
|
||||
{
|
||||
public class UIOptions
|
||||
{
|
||||
// TODO: Is there any way that this can be made private?
|
||||
public Options Options { get; set; }
|
||||
/// <summary>
|
||||
/// Internal Options object for settings storage
|
||||
/// </summary>
|
||||
public Options Options { get; private set; }
|
||||
|
||||
/// <summary>
|
||||
/// Default constructor
|
||||
|
||||
@@ -7,14 +7,12 @@
|
||||
{
|
||||
private readonly UIOptions _uiOptions;
|
||||
|
||||
/// <summary>
|
||||
/// Access to the only setting needed cross-domain
|
||||
/// </summary>
|
||||
public bool VerboseLogging
|
||||
{
|
||||
get { return _uiOptions.Options.VerboseLogging; }
|
||||
set
|
||||
{
|
||||
_uiOptions.Options.VerboseLogging = value;
|
||||
_uiOptions.Save(); // TODO: Why does this save here?
|
||||
}
|
||||
}
|
||||
|
||||
public OptionsViewModel(UIOptions uiOptions)
|
||||
|
||||
Reference in New Issue
Block a user