[PR #620] [MERGED] Support ringcode and PIC for triple/quad-layer #1063

New Issue

Open

opened 2026-01-29 16:25:10 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:25:10 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/620
Author: @fuzz6001
Created: 1/7/2024
Status: ✅ Merged
Merged: 1/8/2024
Merged by: @mnadareski

Base: master ← Head: support-triple-quad-layer

---

📝 Commits (6)

• 9792b49 Support ringcodes for triple/quad-layer
• a4b9d68 Increase PIC length of triple/quad-layer for dic
• dccc015 Increase PIC length of triple/quad-layer for redumper
• c9bf1b8 Change the method of determining PIC length
• 454e0d7 Update change logs
• 7bbc652 Remove braces from if statements

📊 Changes

4 files changed (+53 additions, -2 deletions)

View changed files

📝 CHANGELIST.md (+1 -0)
📝 MPF.Core/Modules/DiscImageCreator/Parameters.cs (+6 -1)
📝 MPF.Core/Modules/Redumper/Parameters.cs (+6 -1)
📝 MPF.Core/SubmissionInfoTool.cs (+40 -0)

📄 Description

• Output ringcode information of layer 2 and 3 to !submissionInfo.txt
• Increase PIC length

Ringocde Information samples

triple-layer

Layer 0 (Outer) Mastering Code (laser branded/etched): (REQUIRED, IF EXISTS)
Layer 0 (Outer) Mastering SID Code: (REQUIRED, IF EXISTS)
Layer 0 (Outer) Toolstamp or Mastering Code (engraved/stamped): (REQUIRED, IF EXISTS)
Data Side Mould SID Code: (REQUIRED, IF EXISTS)
Data Side Additional Mould: (REQUIRED, IF EXISTS)
Layer 1 Mastering Code (laser branded/etched): (REQUIRED, IF EXISTS)
Layer 1 Mastering SID Code: (REQUIRED, IF EXISTS)
Layer 1 Toolstamp or Mastering Code (engraved/stamped): (REQUIRED, IF EXISTS)
Label Side Mould SID Code: (REQUIRED, IF EXISTS)
Layer 2 (Inner) Mastering Code (laser branded/etched): (REQUIRED, IF EXISTS)
Layer 2 (Inner) Mastering SID Code: (REQUIRED, IF EXISTS)
Layer 2 (Inner) Toolstamp or Mastering Code (engraved/stamped): (REQUIRED, IF EXISTS)

quad-layer

Layer 0 (Outer) Mastering Code (laser branded/etched): (REQUIRED, IF EXISTS)
Layer 0 (Outer) Mastering SID Code: (REQUIRED, IF EXISTS)
Layer 0 (Outer) Toolstamp or Mastering Code (engraved/stamped): (REQUIRED, IF EXISTS)
Data Side Mould SID Code: (REQUIRED, IF EXISTS)
Data Side Additional Mould: (REQUIRED, IF EXISTS)
Layer 1 Mastering Code (laser branded/etched): (REQUIRED, IF EXISTS)
Layer 1 Mastering SID Code: (REQUIRED, IF EXISTS)
Layer 1 Toolstamp or Mastering Code (engraved/stamped): (REQUIRED, IF EXISTS)
Label Side Mould SID Code: (REQUIRED, IF EXISTS)
Layer 2 Mastering Code (laser branded/etched): (REQUIRED, IF EXISTS)
Layer 2 Mastering SID Code: (REQUIRED, IF EXISTS)
Layer 2 Toolstamp or Mastering Code (engraved/stamped): (REQUIRED, IF EXISTS)
Layer 3 (Inner) Mastering Code (laser branded/etched): (REQUIRED, IF EXISTS)
Layer 3 (Inner) Mastering SID Code: (REQUIRED, IF EXISTS)
Layer 3 (Inner) Toolstamp or Mastering Code (engraved/stamped): (REQUIRED, IF EXISTS)

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/620 **Author:** [@fuzz6001](https://github.com/fuzz6001) **Created:** 1/7/2024 **Status:** ✅ Merged **Merged:** 1/8/2024 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `support-triple-quad-layer` --- ### 📝 Commits (6) - [`9792b49`](https://github.com/SabreTools/MPF/commit/9792b4909e4d0b199dd9e82b1a84493a2dce40f6) Support ringcodes for triple/quad-layer - [`a4b9d68`](https://github.com/SabreTools/MPF/commit/a4b9d68ab7d82aaa9e861907e1fff8c931e9b123) Increase PIC length of triple/quad-layer for dic - [`dccc015`](https://github.com/SabreTools/MPF/commit/dccc0152dcf95e231c75076790cec3155756a354) Increase PIC length of triple/quad-layer for redumper - [`c9bf1b8`](https://github.com/SabreTools/MPF/commit/c9bf1b8f23ae292115b305175e8161a71c4f6235) Change the method of determining PIC length - [`454e0d7`](https://github.com/SabreTools/MPF/commit/454e0d7cfdf5f37043b913bcbc145c6f61994083) Update change logs - [`7bbc652`](https://github.com/SabreTools/MPF/commit/7bbc652fe1e624abf635b61560b23c18f32d5c3b) Remove braces from if statements ### 📊 Changes **4 files changed** (+53 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELIST.md` (+1 -0) 📝 `MPF.Core/Modules/DiscImageCreator/Parameters.cs` (+6 -1) 📝 `MPF.Core/Modules/Redumper/Parameters.cs` (+6 -1) 📝 `MPF.Core/SubmissionInfoTool.cs` (+40 -0) </details> ### 📄 Description * Output ringcode information of layer 2 and 3 to !submissionInfo.txt * Increase PIC length # Ringocde Information samples ## triple-layer ``` Layer 0 (Outer) Mastering Code (laser branded/etched): (REQUIRED, IF EXISTS) Layer 0 (Outer) Mastering SID Code: (REQUIRED, IF EXISTS) Layer 0 (Outer) Toolstamp or Mastering Code (engraved/stamped): (REQUIRED, IF EXISTS) Data Side Mould SID Code: (REQUIRED, IF EXISTS) Data Side Additional Mould: (REQUIRED, IF EXISTS) Layer 1 Mastering Code (laser branded/etched): (REQUIRED, IF EXISTS) Layer 1 Mastering SID Code: (REQUIRED, IF EXISTS) Layer 1 Toolstamp or Mastering Code (engraved/stamped): (REQUIRED, IF EXISTS) Label Side Mould SID Code: (REQUIRED, IF EXISTS) Layer 2 (Inner) Mastering Code (laser branded/etched): (REQUIRED, IF EXISTS) Layer 2 (Inner) Mastering SID Code: (REQUIRED, IF EXISTS) Layer 2 (Inner) Toolstamp or Mastering Code (engraved/stamped): (REQUIRED, IF EXISTS) ``` ## quad-layer ``` Layer 0 (Outer) Mastering Code (laser branded/etched): (REQUIRED, IF EXISTS) Layer 0 (Outer) Mastering SID Code: (REQUIRED, IF EXISTS) Layer 0 (Outer) Toolstamp or Mastering Code (engraved/stamped): (REQUIRED, IF EXISTS) Data Side Mould SID Code: (REQUIRED, IF EXISTS) Data Side Additional Mould: (REQUIRED, IF EXISTS) Layer 1 Mastering Code (laser branded/etched): (REQUIRED, IF EXISTS) Layer 1 Mastering SID Code: (REQUIRED, IF EXISTS) Layer 1 Toolstamp or Mastering Code (engraved/stamped): (REQUIRED, IF EXISTS) Label Side Mould SID Code: (REQUIRED, IF EXISTS) Layer 2 Mastering Code (laser branded/etched): (REQUIRED, IF EXISTS) Layer 2 Mastering SID Code: (REQUIRED, IF EXISTS) Layer 2 Toolstamp or Mastering Code (engraved/stamped): (REQUIRED, IF EXISTS) Layer 3 (Inner) Mastering Code (laser branded/etched): (REQUIRED, IF EXISTS) Layer 3 (Inner) Mastering SID Code: (REQUIRED, IF EXISTS) Layer 3 (Inner) Toolstamp or Mastering Code (engraved/stamped): (REQUIRED, IF EXISTS) ``` --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:25:10 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#1063